Message Threads | The Odoo Community Association

Single product description for sales, purchases, pickings...

Hello Contributors!

I’ve opened an issue to propose a new module to support single product description:

If you are interested or you have solved before (I guess it! This is common!) please participate in https://github.com/OCA/stock-logistics-workflow/issues/1067

Thank you

Regards,

Rafael

by Rafael Blasco (Moduon) - 06:25 - 16 Aug 2022

1 attachments 1 attachments

How do you solve invoicing period?

Hello Contributors!

I write because I don’t see a common straight solution (and user friendly) for this general use case.

Usually, I have been using the OCA module “sale_order_type” when a client have the need of defining invoicing periods like:

Monthly
B-weekly
Weekly
Daily

With sale_order_type +plus+ sale_order_invoicing_grouping_criteria you can group by. This module allow multiple criterias.

In the other hand there is the OCA module “account_invoice_base_invoicing_mode”, this looks like more specific but it has a huge dependency (I don’t know why): depends: account, queue_job, sale

With account_invoice_base_invoicing_mode +plus+ account_invoice_mode_monthly and other modules becomes the logic, but the customer cannot create their invoicing modes themselves, and need from us a new module each time.

The usability (UX) in my mind looks like clients (users) have a field like “invoicing period” (like invoicing mode) where they can create monthly, weekly, etc. (like payment terms) and after that they can set it in the partners form (customers or supplier). And after that improve with more modules automatism.

What do you think?

I write here before opening an issue in GitHub (maybe sale-workflow, maybe account-invoicing).

Thank you in advance

Best regards

Rafael

by Rafael Blasco (Moduon) - 05:31 - 16 Aug 2022

3 replies 3 replies

Re: How do you solve invoicing period?
Hello Raphael,

> With account_invoice_base_invoicing_mode +plus+ account_invoice_mode_monthly and other modules becomes the logic, but the customer cannot create their invoicing modes themselves, and need from us a new module each time.

This is correct. That is for automatic invoicing according to the mode defined on the partner. You currently have the possibility to choose monthly, weekly and daily (v14 open PR). Each mode needs its module for the implementation.
The generation of the invoice is done with a cron job that generates a queue job at a defined time. This allows to control the load and track what occurred with the job, and see the log in case of error.
It also supports returns to generate credit notes.

Kind regards
J-E

Le mar. 16 août 2022 à 17:32, Rafael Blasco <notifications@odoo-community.org> a écrit :
Hello Contributors!

I write because I don’t see a common straight solution (and user friendly) for this general use case.

Usually, I have been using the OCA module “sale_order_type” when a client have the need of defining invoicing periods like:

Monthly
B-weekly
Weekly
Daily

With sale_order_type +plus+ sale_order_invoicing_grouping_criteria you can group by. This module allow multiple criterias.

In the other hand there is the OCA module “account_invoice_base_invoicing_mode”, this looks like more specific but it has a huge dependency (I don’t know why): depends: account, queue_job, sale

With account_invoice_base_invoicing_mode +plus+ account_invoice_mode_monthly and other modules becomes the logic, but the customer cannot create their invoicing modes themselves, and need from us a new module each time.

The usability (UX) in my mind looks like clients (users) have a field like “invoicing period” (like invoicing mode) where they can create monthly, weekly, etc. (like payment terms) and after that they can set it in the partners form (customers or supplier). And after that improve with more modules automatism.

What do you think?

I write here before opening an issue in GitHub (maybe sale-workflow, maybe account-invoicing).

Thank you in advance
Best regards
Rafael

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Jacques-Etienne Baudoux - 09:15 - 19 Aug 2022

Re: How do you solve invoicing period?

Rafael,

have a look at contract repository https://github.com/OCA/contract, contract module that allows for creation of invoices. With contract_sale_generation you can generate sale orders instead of invoices.

Hope it helps

Best regards

Radovan

Sent via BlackBerry Hub+ Inbox for Android

From: notifications@odoo-community.org

Sent: August 16, 2022 18:32

To: contributors@odoo-community.org

Reply-to: contributors@odoo-community.org

Subject: How do you solve invoicing period?

Hello Contributors!

I write because I don’t see a common straight solution (and user friendly) for this general use case.

Usually, I have been using the OCA module “sale_order_type” when a client have the need of defining invoicing periods like:

Monthly
B-weekly
Weekly
Daily

With sale_order_type +plus+ sale_order_invoicing_grouping_criteria you can group by. This module allow multiple criterias.

In the other hand there is the OCA module “account_invoice_base_invoicing_mode”, this looks like more specific but it has a huge dependency (I don’t know why): depends: account, queue_job, sale

With account_invoice_base_invoicing_mode +plus+ account_invoice_mode_monthly and other modules becomes the logic, but the customer cannot create their invoicing modes themselves, and need from us a new module each time.

The usability (UX) in my mind looks like clients (users) have a field like “invoicing period” (like invoicing mode) where they can create monthly, weekly, etc. (like payment terms) and after that they can set it in the partners form (customers or supplier). And after that improve with more modules automatism.

What do you think?

I write here before opening an issue in GitHub (maybe sale-workflow, maybe account-invoicing).

Thank you in advance

Best regards

Rafael

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by Radovan Skolnik - 05:45 - 16 Aug 2022

Re: How do you solve invoicing period?
Hello,

I don't know if this is what you want, but I'm using date_range module, plus another one that creates months, quarters, semesters and years via ir.cron.

Then, I added some date_range_id fields on account.move.line model.

Regards,

João Jerónimo

Às 16:32 de 16/08/2022, Rafael Blasco escreveu:

Hello Contributors!

I write because I don’t see a common straight solution (and user friendly) for this general use case.

Usually, I have been using the OCA module “sale_order_type” when a client have the need of defining invoicing periods like:

Monthly

B-weekly

Weekly

Daily

With sale_order_type +plus+ sale_order_invoicing_grouping_criteria you can group by. This module allow multiple criterias.

In the other hand there is the OCA module “account_invoice_base_invoicing_mode”, this looks like more specific but it has a huge dependency (I don’t know why): depends: account, queue_job, sale

With account_invoice_base_invoicing_mode +plus+ account_invoice_mode_monthly and other modules becomes the logic, but the customer cannot create their invoicing modes themselves, and need from us a new module each time.

The usability (UX) in my mind looks like clients (users) have a field like “invoicing period” (like invoicing mode) where they can create monthly, weekly, etc. (like payment terms) and after that they can set it in the partners form (customers or supplier). And after that improve with more modules automatism.

What do you think?

I write here before opening an issue in GitHub (maybe sale-workflow, maybe account-invoicing).

Thank you in advance

Best regards

Rafael

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by j_j_b_o_devel - 05:41 - 16 Aug 2022

Call for Speakers - OCA Days 2022 - Deadline 31st August

Hello OCA Contributors.

We are so excited to see so many of you heading to the OCA Days in October. We are almost at capacity!
I wanted to make sure you were aware that our "Call for Speakers" deadline is 31st of August.

We have some great proposals that have been sent through already and we would love to have more! We want to hear about what you have been up to, have you got a new module to share, an update, a tutorial, a workshop, a great discussion topic.....?

We want to know about it. Share your talk proposals here.

We look forward to hearing from you.

Rebecca

--

Rebecca Gellatly

General Secretary

Odoo Community Association

by Rebecca Gellatly - 03:31 - 16 Aug 2022

OCA Days 2022 - Info Blog Post

Hello Dear OCA Contributors.

I hope this email finds you all well.

I wanted to draw your attention to our latest blog post with a few more details about the OCA Days. Please have a read here.

Please note, that we only have 200 spaces (in past years we've only been able to sit around 150 in person, we are excited to be able to increase this), but we need to know who is coming and spaces are starting to fill up! Register here.

We are so excited to hear your talk proposals too - the deadline is 31st August.

We can't wait to see you in Liège!

Warmest regards,

Rebecca

--

Rebecca Gellatly

General Secretary

Odoo Community Association

by Rebecca Gellatly - 10:46 - 10 Aug 2022

Firebase integration with Odoo

Hello everybody,

for a potential project, we need to integrate Odoo with Firebase DB and 
create a lot of Endpoint to exchange data like customer, product, sale 
order and so on.

Has anyone done something similar?

Thanks


-- 

Stefano Sforzi
Tel (CH): +41 91 210 23 40
Tel (IT): +39 0331 158 7090
https://www.agilebg.com

by stefano sforzi - 04:20 - 8 Aug 2022

Migrating custom modules of Point of Sale from v13 to v15

Hi,

We're trying to upgrade a custom module from v13 to v15. post_statement_id field which is included in class AccountBankStatementLine model via inheritance in point_of_sale module in Odoo Community addons v13 but it doesn't exist in v15 and this field is used in our custom module.

What is replaced with pos_statement_id field of AccountBankStatementLine in v15?

v13:

in point_of_sale module:

class AccountBankStatementLine(models.Model):

_inherit = 'account.bank.statement.line'

pos_statement_id = fields.Many2one('pos.order', string="POS statement", ondelete='cascade')

custom module in v13:

class POSOrder(models.Model):

_inherit = 'pos.order'

statement_ids = fields.One2many(

'account.bank.statement.line',

'pos_statement_id',

string='Bank Payments',

states={'draft': [('readonly', False)]},

readonly=True)

v15:

No inherited account.bank.statement.line class and no pos_statement_id field

I need a detailed description of how module designs changed from v13 to v15. There are several similar issues in our custom module. Could you please give some suggestions? Is there any descriptive document that explains how module structures changed to take into account for developers?

Regards

by duygutuncay - 10:50 - 22 Jul 2022

Procedure to create 16.0 branches

Dear contributors,

I'm starting to think about the process to create the 16.0 branches. And the more I think about it, the more I'm convinced we should do it by adding "installable": False in the module manifests, instead of creating empty branches.

This would have several benefits:

Improve security. Indeed, currently migration PRs have a lot of commits and reviewers only look at the last 2 commits. By accident or malice, it would be easy for a contributor to sneak bad code in older commits, that would go unnoticed. As the community grows, I think this a very important topic.
Avoid CLA bot issues: currently, the CLA bot is flagging old commits that were ok at the time they were created, but may not be valid today as contributors may have changed email, or revoked their CLA.
Reduce oca-github-bot complexity: work has to be done to make the bot aware of other branches in migration PRs (notably to look-up maintainers). This would be unnecessary if a migration PR is a normal PR to an existing addon directory. On the contrary, the bot could even detect migration PRs automatically by noticing the change to the installable flag, so this could simplify some processes.
Slow git repo growth: by avoiding the recreation of identical commits in several branches we would slow down the git repo size increase.

About the possible drawbacks, I am under the impression that all the reasons we had back then to create empty branches have faded away:

Today, Odoo and all the OCA tooling work perfectly well when there are addons marked as uninstallable. They are correctly ignored by linters, tests, and Odoo does not attempt to import the code.
Regarding discoverability, the addons table in the README shows a clear view of what is not migrated.

The migration procedure and tools should continue to work as today, to pick up commits that would have been added after branching (basically the git-am process would simply work as it does today)

All we'd need maybe is to agree on a process to remove modules that have not been migrated for several versions. But in a first approach, regular PRs to remove now useless modules would probably be sufficient.

Are there any other arguments (pro or con) that I would have missed ?

Looking forward to reading your feedback on this proposal.

-Stéphane

by Stéphane Bidoul - 12:45 - 20 Jul 2022

36 replies 36 replies

Re: Procedure to create 16.0 branches
Hi,

I'm no techie, and don't pretend to deeply understand this stuff. Also not a PSC of any repo. I am not very personally affected by whatever decision is made here and will happily defer to any decision.

Regards benefits of this approach, the first question I ask is can this be achieved in other ways. Usually people tell me it is impossible immediately. I won't argue back, just random thoughts.
Improve security. One thought regards nefarious commits injected into migration. Is this solvable in other ways? Something like an AST/semantic diff maybe or even just a regular diff against last release. In fact a regular diff against last release may identify missed commits too. But anyway some kind of semantic diff outside of migration may be useful too as it would just ignore format changes. However, I think security is a separate important topic that needs a wider discussion regardless of whatever outcomes here are and we should be vigilant to those risks. But also as a reviewer, I think I'd rather review a semantic diff anyway.
Avoid CLA bot issues: Do we really need to preserve ALL history every release - what about a squash merge - that maintains all the prior authors? Then maybe we can get an excpetion for that case in bot. For that 1 time ever you need a blame on a file 6 years ago, you can still traceback through versions.
Reduce oca-github-bot complexity: I actually thought that work was done already. But in any case, is the argument here valid? Because not all modules in prior repo(s) would be merged at time the new one is created. So don't you avoid the complexity, until you don't? Wouldn't we need the functionality regardless? I don't know, genuine question.
Slow git repo growth: As above for CLA Bot.

My general feeling I am getting -

Maintainers with tightly controlled, homogenous repos with a small number of maintainers and modules are in favour. These also tend to be "additive" repos, i.e. it is new functionality with not a lot of integration points. They also tend to be a bit more "technical". There is a very high likelihood of migration and also fairly rapidly. However, the contributors on those repos are more than capable of a 5 minute dance to do the port work.
PSC's with large heterogeneous repos with many modules and contributors aren't so much in favour. Of course in these repos there tends to be a LOT of flux from version to version. Place like product-attribute, sale-workflow. These are often "insertive" type modules, putting themselves in middle of business processes. Design changes, upstream functionality changes, lots of modules dropping, reappearing.

I know for myself and some modules I have some involvement with.
office 365 auth - hasn't changed between versions for 7 years. I don't even have any clients paying for it anymore - but 1 guy emails me once a year asking me to bump version number because it still works.
partner statements - we did a big refactor for 11 or 12.0 maybe, a few minor changes for 13.0 accounting but less than you'd think because it is fundamentally just adding a couple reports.
Now when I'm doing/reviewing those, I'll admit it does seem a bit wasteful this whole dance but it is no big deal.

operating-unit - literally just a bunch of modules sticking a single field on a model, these are often awful to migrate because that happens in the middle of all sorts of functions, lots of interdependencies, stupid broken Odoo record rules. Plus they look easy, so often people seem to pick them for their first ever migration, review sucks on these and we get quite a few unexpected oversights. You really do need to download and test these PR's.
I know it should make no difference, but my head just thinks better starting clean.

sale-workflow/product-attribute type repos - honestly, a lot of the time in these repos it is about merging modules, deprecating modules, combining functionality, finding better repos as focus changes. I'm probably wrong, but I feel like prepopulating uninstallable is probably more work and missed opportunities.

Anyway just my thoughts.

But also, even if it is OK for 16, what about odd number version :) (This is a joke).

On Thu, Jul 21, 2022 at 10:42 PM Pedro M. Baeza (Tecnativa) <notifications@odoo-community.org> wrote:
> To make sure people reason about the correct arguments, let me emphasize again that the migration process would be strictly identical.

Although theoretically you can use the same commands (but I repeat, I remember some problems in the past with this - I will try to dig on the history to find any -), what will happen for sure is that people forget to do/don't know such initial steps and appear that the migration pull request is correct, while it doesn't contain the missing commits, charging on the reviews to check this, so that's the real issue, together with other strong arguments like the IDE search, cleaning, etc.

And I also agree having some repositories with one approach and another with the other approach is a mess. You have done the installable=False approach in the past for your specific repositories (mis-builder, storage, product-pim and queue mostly), because you do the migration yourself, not involving other contributors, but the rest of the repositories can't apply this method.

Regards.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Graeme Gellatly - 03:15 - 21 Jul 2022
Re: Procedure to create 16.0 branches

> To make sure people reason about the correct arguments, let me emphasize again that the migration process would be strictly identical.

Although theoretically you can use the same commands (but I repeat, I remember some problems in the past with this - I will try to dig on the history to find any -), what will happen for sure is that people forget to do/don't know such initial steps and appear that the migration pull request is correct, while it doesn't contain the missing commits, charging on the reviews to check this, so that's the real issue, together with other strong arguments like the IDE search, cleaning, etc.

And I also agree having some repositories with one approach and another with the other approach is a mess. You have done the installable=False approach in the past for your specific repositories (mis-builder, storage, product-pim and queue mostly), because you do the migration yourself, not involving other contributors, but the rest of the repositories can't apply this method.

Regards.

by Pedro M. Baeza - 12:41 - 21 Jul 2022
Re: Procedure to create 16.0 branches
To make sure people reason about the correct arguments, let me emphasize again that the migration process would be strictly identical.

On Thu, Jul 21, 2022 at 11:26 AM LuisDaniel Lafaurie <notifications@odoo-community.org> wrote:
Hello everyone,

I agree with what Rémi has just explained.

It wouldn't be wise to put more pressure on the migration process for the ones (PSCs and/or reviewers) working more actively on that subject.

Keeping the current method will be the best option so far, IMHO.

Thus, my vote is -1

Thanks,

On Thu, 21 Jul 2022 at 10:02, Rémi CAZENAVE - Le Filament <notifications@odoo-community.org> wrote:
Hi all,

I like better the current method (having only working/tested/maintained modules in each branch) for the following reasons :
- I find it easier to see what is available un a given version, what would still need to be migrated, and also to get an idea of which versions are being actively used (though I guess I could look at READMEs, migration issues and overall statistics to get the same info)
- on each Odoo instance we deploy we download specific branch and having lots of unusable code would increase bandwidth and storage (although mostly text that could be compressed, so probably not dramatic neither)

I agree that the process to migrate a module from one version to another is not really easy (at least the first times), but I understand that it would still probably need to be done in order to make sure you get the latest commits from previous branch. I am afraid that this would often be forgotten if not strictly necessary in migration process, and for sure we do not want to transfer this extra burden of checking for each PR whether based on latest commits or not to reviewers / PSC.

Last, I am not in favour of having 2 different processes that can be applied per repo, since it would increase complexity for understanding why 2 repos are not behaving the same, and we may lose newcomers (but also for people not so much involved in OCA) - although here again I understand from discussions this is already the case for some repos.

My 2 cents...

Best Regards,
Rémi CAZENAVE
SCOP Le Filament

Le July 21, 2022 3:52:02 AM UTC, "Raphaël Valyi" <notifications@odoo-community.org> a écrit :

Hello,

My vote goes to the opt-in option at least unless Pedro get convinced, because going against the will of somebody processing such a large portion of the PRs would be a terrible shot in the feet.

That being said, earlier Pedro raised the concern about the possibility to craft an attack commit inside a missing commit that would be cherry-picked just like with the current way of migrating. But:

On Wed, Jul 20, 2022, 3:42 PM Roussel, Denis <notifications@odoo-community.org> wrote:
To summarize:

commits SHA are different with current behaviour
commits SHA are equal with proposed one

Denis could you confirm this SHA conservation could make us safe against such crafted attack commits in the middle of the missing commits that one would need to cherry-pick with the new procedure?

This crafted commit attack thing is indeed extremely concerning...

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Stéphane Bidoul - 12:05 - 21 Jul 2022
Re: Procedure to create 16.0 branches
Hi,

For the moment, I prefer the empty branches. The lifecycle of the module is really different from the lifecycle of major version releases.
I think the focus should be on improving tools /workflows for keeping in sync modules across versions.

Regards,

Le jeu. 21 juil. 2022 à 10:02, Rémi CAZENAVE - Le Filament <notifications@odoo-community.org> a écrit :
Hi all,

I like better the current method (having only working/tested/maintained modules in each branch) for the following reasons :
- I find it easier to see what is available un a given version, what would still need to be migrated, and also to get an idea of which versions are being actively used (though I guess I could look at READMEs, migration issues and overall statistics to get the same info)
- on each Odoo instance we deploy we download specific branch and having lots of unusable code would increase bandwidth and storage (although mostly text that could be compressed, so probably not dramatic neither)

I agree that the process to migrate a module from one version to another is not really easy (at least the first times), but I understand that it would still probably need to be done in order to make sure you get the latest commits from previous branch. I am afraid that this would often be forgotten if not strictly necessary in migration process, and for sure we do not want to transfer this extra burden of checking for each PR whether based on latest commits or not to reviewers / PSC.

Last, I am not in favour of having 2 different processes that can be applied per repo, since it would increase complexity for understanding why 2 repos are not behaving the same, and we may lose newcomers (but also for people not so much involved in OCA) - although here again I understand from discussions this is already the case for some repos.

My 2 cents...

Best Regards,
Rémi CAZENAVE
SCOP Le Filament

Le July 21, 2022 3:52:02 AM UTC, "Raphaël Valyi" <notifications@odoo-community.org> a écrit :

Hello,

My vote goes to the opt-in option at least unless Pedro get convinced, because going against the will of somebody processing such a large portion of the PRs would be a terrible shot in the feet.

That being said, earlier Pedro raised the concern about the possibility to craft an attack commit inside a missing commit that would be cherry-picked just like with the current way of migrating. But:

On Wed, Jul 20, 2022, 3:42 PM Roussel, Denis <notifications@odoo-community.org> wrote:
To summarize:

commits SHA are different with current behaviour
commits SHA are equal with proposed one

Denis could you confirm this SHA conservation could make us safe against such crafted attack commits in the middle of the missing commits that one would need to cherry-pick with the new procedure?

This crafted commit attack thing is indeed extremely concerning...

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--
Raphaël Reverdy
Mobile +33 6 38 02 03 93
Fixe +33 4 82 53 84 60
by Raphaël Reverdy - 11:46 - 21 Jul 2022
Re: Procedure to create 16.0 branches
Hi All,

I am not in favor of this and most of this has already been said by others, but I want to re-iterate:

1. It is currently easy to see at a glance the state of the branch and which modules have been migrated

2. The current migration process for most modules is relatively easy

3. If it hinders or causes friction for current OCA contributors and causes them to engage less in OCA it shouldn't be done. Period.

4. The most important reason:

Except for the few modules that are widely used most modules are migrated after 1+ years of the Odoo SA version release. Quite a few modules are also migrated after more than 1 Odoo SA version release. I.E. version 12 module skips 13 and is migrated to 14 and then someone else migrates it to 13. This will create chaos.

I am also not in favor of an opt-in option because it's just an additional difference that we (developers and users) have to keep in mind (re: #1) and frankly the purported benefits do not outweigh the headaches it will cause.

Regards,

Mike.

On 21/07/2022 12:12, Aarón Henríquez Quintana wrote:

As a developer I love the way it is now.

You know clearly what is migrated, and all the history

Easy to track what is being migrated

The process is clean, and you get used to it very fast, barely 4 commands in git.

I think it is safe also, it is a responsibility of the repo maintainer that approves the PR to look at the code and check everything is correct.

If we apply the proposal:

It is way more complex for developers, it open a bunch of possibilities:

If it was not in v15 at the time the 16.0 branch was created: in this case we will be doing the current procedure

If it was, and there is no improvement, then we will do a "normal" migration with 1 single commit, that's ok

if it was, but it was improved, we have to include those improvements as well, the diff is not reduced as well.

Deleted modules will create greater diffs.

If the module was deleted because no one wanted to use it, but later on someone decides to migrate it, the diff is going to be super huge.

It is going to be harder to know what is migrated, and being migrated, and what is not necessary.

I understand the improvements of the change but I think those improvements are now important enough with respect to the drawbacks.

On Thu, 21 Jul 2022 at 10:02, Rémi CAZENAVE - Le Filament <notifications@odoo-community.org> wrote:

Hi all,

I like better the current method (having only working/tested/maintained modules in each branch) for the following reasons :
- I find it easier to see what is available un a given version, what would still need to be migrated, and also to get an idea of which versions are being actively used (though I guess I could look at READMEs, migration issues and overall statistics to get the same info)
- on each Odoo instance we deploy we download specific branch and having lots of unusable code would increase bandwidth and storage (although mostly text that could be compressed, so probably not dramatic neither)

I agree that the process to migrate a module from one version to another is not really easy (at least the first times), but I understand that it would still probably need to be done in order to make sure you get the latest commits from previous branch. I am afraid that this would often be forgotten if not strictly necessary in migration process, and for sure we do not want to transfer this extra burden of checking for each PR whether based on latest commits or not to reviewers / PSC.

Last, I am not in favour of having 2 different processes that can be applied per repo, since it would increase complexity for understanding why 2 repos are not behaving the same, and we may lose newcomers (but also for people not so much involved in OCA) - although here again I understand from discussions this is already the case for some repos.

My 2 cents...

Best Regards,
Rémi CAZENAVE
SCOP Le Filament

Le July 21, 2022 3:52:02 AM UTC, "Raphaël Valyi" <notifications@odoo-community.org> a écrit :

Hello,

My vote goes to the opt-in option at least unless Pedro get convinced, because going against the will of somebody processing such a large portion of the PRs would be a terrible shot in the feet.

That being said, earlier Pedro raised the concern about the possibility to craft an attack commit inside a missing commit that would be cherry-picked just like with the current way of migrating. But:

On Wed, Jul 20, 2022, 3:42 PM Roussel, Denis <notifications@odoo-community.org> wrote:

To summarize:

commits SHA are different with current behaviour

commits SHA are equal with proposed one

Denis could you confirm this SHA conservation could make us safe against such crafted attack commits in the middle of the missing commits that one would need to cherry-pick with the new procedure?

This crafted commit attack thing is indeed extremely concerning...

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Raphael Makonnen - 11:41 - 21 Jul 2022

One stop shop (OSS) Tax with foreign fixed establishment

Hi all,

Has anymore already faced or/and solved the case where you need to apply the tax based on your fixed establishment providing the goods.

My company is in country C only (no multi-company) and I have a warehouse in country C and D. So accounting is declared in country C, taxes are declared in country C and D according to their respective shipments.

When the SO is placed, the shipping country is not known yet.

If country D is shipping goods to a customer address in country D, this is a national delivery with the VAT of the delivery address country.

If country D is shipping goods to a B2B EU customer address not in country D, this is an intracom delivery without VAT.

Worst use case is if for one SO line of 10 units, you ship 4 from country C to country C (national delivery) and 6 from country D to country C (intracom delivery). You need an invoice for each delivering country and apply different tax while it's related to the same SO line.

For B2C, the tax rate is always the one based on the customer delivery address but the declaration is done to the tax department of the delivering country.

The 2 possible approaches I see are:

- change the SO line at delivery to put the correct tax. But this could lead to SO line splitting and the SO does not reflect the original SO confirmation anymore. This can cause issues in the connections to e-commerce platforms. So I'm not in favor of it

- change the tax set on the invoice at invoice generation. This will need to know what tax to apply, meaning we need to refine the qty_to_invoice to have one qty_to_invoice per delivering country.

Of course, this should also work with returns and credit notes and the goods can be returned to a different country than the one that initially shipped the goods.

Any input is welcome. I created this discussion here:

https://github.com/OCA/account-fiscal-rule/discussions/300

Kind regards,

Jacques-Etienne Baudoux

by Jacques-Etienne Baudoux - 11:56 - 18 Jul 2022

Proposing myself as l10n-spain PSC

Hi all,

I would like to apply as PSC for https://github.com/OCA/l10n-spain

At Studio73 we are working with Odoo since OpenERP 6.0 and we have contributed to some of the l10n-spain core modules.

We are an experience team with the Spanish fiscal demands and we would like to help to our localization at the migration for next Odoo's release.

My github account is
https://github.com/fuentes73

Some contributions:
https://odoo-community.org/shop?order=total_download_count+desc&search=studio73

Best Regards,

Pablo Fuentes
Gerente - Ing. Informático
pablo@studio73.es

Consultoría Informática Studio 73 S.L.
C/ Camí vell de l'estació, 6 Bajo Izquierda
46870 - Ontinyent (Valencia)
www.studio73.es - 96 191 12 79

by Pablo Fuentes Rodríguez - 11:01 - 13 Jul 2022

11 replies 11 replies

Re: Proposing myself as l10n-spain PSC

Hi all.

I don't want to be polemic, I just would like to have a decision based in good information and following answer of Pablo, I think he can help us with some more info.

Pablo, I know you're the leader of a very skilled team.

To clarify this point to the rest of contributors, could you share with us github accounts of your developers and the sum of all their PRs in state closed?

I mean the metric proposed by Pedro with

https://github.com/OCA/l10n-spain/pulls?q=is%3Apr+author%3Afuentes73+is%3Aclosed

In a quick review I can share this, with all of you.

Thanks.

-----------------------------------------------------------

Josean Soroa

El jue, 14 jul 2022 a las 18:12, Pablo Fuentes (<notifications@odoo-community.org>) escribió:

Hello everyone,

Thank you all for your kind words. Just for the record.
Although you might think that I do not have enough experience in l10n-spain, technically I do, and functionally I am well advised by my colleagues who have enough experience (1 lawyer and 3 tax advisors).
So my proposal was on behalf of the Studio73 team because I am the one with the most availability.

About very few contributions it's not compleatly fair. I'm behind most of my colleagues contributions during the analysis and internal review and this is dificult to measure but it's ok.

Regardless, there is no problem by my side not to promote as a PSC.

Thanks for your consideration.
Best Regards,

Pablo Fuentes
Gerente - Ing. Informático
pablo@studio73.es
Consultoría Informática Studio 73 S.L.
C/ Camí vell de l'estació, 6 Bajo Izquierda
46870 - Ontinyent (Valencia)
www.studio73.es - 96 191 12 79

El jue, 14 jul 2022 a las 15:07, Enric Tobella Alomar (<notifications@odoo-community.org>) escribió:
IMO, It is too soon for Pablo being a PSC member. You can check how many PRS he has done on OCA and it is not so much:

https://github.com/pulls?q=is%3Apr+author%3Afuentes73+archived%3Afalse+user%3AOCA+sort%3Aupdated-desc

Most of them are from long time ago and only 6 in l10n-spain.

It is allways interesting to have PSCs, but I would prefer to see him more on action before.

Kind regards,

Enric Tobella Alomar

Av. J. V. Foix 63

08034 Barcelona

Tlf.    932 522 522 (Ext. 9611)

creublanca.es

From: Urtzi Pérez <notifications@odoo-community.org>
To: "Contributors" <contributors@odoo-community.org>
Date: Thu, 14 Jul 2022 11:56:57 -0000
Subject: Re: Proposing myself as l10n-spain PSC

Hi,

In my opinion Pablo is a +1 too.

I agree with every point Josean has explained, and as the responsible of the spanish localization and member of the board of Aeodoo, I'd like to reinforce Josean's words saying that the projects we are facing this year will result in a large amount of contributions in short periods of time, so we'd need some efficiency in the deepest technical reviews most contributors can't do (mostly because of lack of experience).

Pedro, I think the most important concept is to give the Spanish localization the push it needs. I'm sure that working with skilled people like Pablo could help you (and the other actual PSCs) to improve the repository's health.

Regards.

¿Nos dejas una reseña en Google My Business? Haz Clic Aquí

Urtzi Pérez

Departamento de desarrollo uperez@coninpe.es |  946 519 519

www.coninpe.es

946 519 519

Pol. Ind. Torrelarragoiti Parcela 8A- Pab. 10

48170  Zamudio

Aviso legal: Este mensaje electrónico está dirigido únicamente a la(s) dirección(es) indicadas anteriormente; el carácter confidencial, personal e intransferible del mismo está protegido legalmente. Cualquier revelación, uso o reenvío no autorizado, completo o en parte, está prohibido. Si ha recibido este mensaje por equivocación, notifíquelo inmediatamente a la persona que lo ha enviado y borre el mensaje original junto con sus ficheros anexos sin leerlo ni grabarlo, total o parcialmente

El jue, 14 jul 2022 a las 13:07, Pedro M. Baeza (Tecnativa) (<notifications@odoo-community.org>) escribió:

They can contribute the same reviewing and proposing pull requests. The only difference is the right to trigger the merge command. What can't be done is someone that hasn't contributed a lot yet to the localization to have the same merits that someone that has done a lot along the years.

This proposal can be reviewed in some time when the number of contributions will be significant.

Regards.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Tanto este mensaje como los documentos que, en su caso, lleve como anexos,
pueden contener información reservada y/o confidencial, destinada exclusivamente
para el uso del destinatario o la persona responsable de entregarlo al mismo,
estando su uso no autorizado prohibido legalmente.
Su contenido no constituye un compromiso para Creu Blanca (la empresa remitente)
salvo ratificación escrita por ambas partes. En caso de su recepción por error,
rogamos nos lo comunique por igual vía, se abstenga de realizar copias del mensaje
o documentos adjuntos, remitirlo o facilitarlo a un tercero, y proceda en su defecto,
a su eliminación.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by Josean Soroa - 02:26 - 15 Jul 2022

Re: Proposing myself as l10n-spain PSC

Hello everyone,

Thank you all for your kind words. Just for the record.
Although you might think that I do not have enough experience in l10n-spain, technically I do, and functionally I am well advised by my colleagues who have enough experience (1 lawyer and 3 tax advisors).
So my proposal was on behalf of the Studio73 team because I am the one with the most availability.

About very few contributions it's not compleatly fair. I'm behind most of my colleagues contributions during the analysis and internal review and this is dificult to measure but it's ok.

Regardless, there is no problem by my side not to promote as a PSC.

Thanks for your consideration.
Best Regards,

Pablo Fuentes
Gerente - Ing. Informático
pablo@studio73.es

Consultoría Informática Studio 73 S.L.
C/ Camí vell de l'estació, 6 Bajo Izquierda
46870 - Ontinyent (Valencia)
www.studio73.es - 96 191 12 79

El jue, 14 jul 2022 a las 15:07, Enric Tobella Alomar (<notifications@odoo-community.org>) escribió:

IMO, It is too soon for Pablo being a PSC member. You can check how many PRS he has done on OCA and it is not so much:

https://github.com/pulls?q=is%3Apr+author%3Afuentes73+archived%3Afalse+user%3AOCA+sort%3Aupdated-desc

Most of them are from long time ago and only 6 in l10n-spain.

It is allways interesting to have PSCs, but I would prefer to see him more on action before.

Kind regards,

Enric Tobella Alomar

Av. J. V. Foix 63

08034 Barcelona

Tlf.    932 522 522 (Ext. 9611)

creublanca.es

From: Urtzi Pérez <notifications@odoo-community.org>
To: "Contributors" <contributors@odoo-community.org>
Date: Thu, 14 Jul 2022 11:56:57 -0000
Subject: Re: Proposing myself as l10n-spain PSC

Hi,

In my opinion Pablo is a +1 too.

I agree with every point Josean has explained, and as the responsible of the spanish localization and member of the board of Aeodoo, I'd like to reinforce Josean's words saying that the projects we are facing this year will result in a large amount of contributions in short periods of time, so we'd need some efficiency in the deepest technical reviews most contributors can't do (mostly because of lack of experience).

Pedro, I think the most important concept is to give the Spanish localization the push it needs. I'm sure that working with skilled people like Pablo could help you (and the other actual PSCs) to improve the repository's health.

Regards.

¿Nos dejas una reseña en Google My Business? Haz Clic Aquí

Urtzi Pérez

Departamento de desarrollo uperez@coninpe.es |  946 519 519

www.coninpe.es

946 519 519

Pol. Ind. Torrelarragoiti Parcela 8A- Pab. 10

48170  Zamudio

Aviso legal: Este mensaje electrónico está dirigido únicamente a la(s) dirección(es) indicadas anteriormente; el carácter confidencial, personal e intransferible del mismo está protegido legalmente. Cualquier revelación, uso o reenvío no autorizado, completo o en parte, está prohibido. Si ha recibido este mensaje por equivocación, notifíquelo inmediatamente a la persona que lo ha enviado y borre el mensaje original junto con sus ficheros anexos sin leerlo ni grabarlo, total o parcialmente

El jue, 14 jul 2022 a las 13:07, Pedro M. Baeza (Tecnativa) (<notifications@odoo-community.org>) escribió:

They can contribute the same reviewing and proposing pull requests. The only difference is the right to trigger the merge command. What can't be done is someone that hasn't contributed a lot yet to the localization to have the same merits that someone that has done a lot along the years.

This proposal can be reviewed in some time when the number of contributions will be significant.

Regards.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Tanto este mensaje como los documentos que, en su caso, lleve como anexos,
pueden contener información reservada y/o confidencial, destinada exclusivamente
para el uso del destinatario o la persona responsable de entregarlo al mismo,
estando su uso no autorizado prohibido legalmente.
Su contenido no constituye un compromiso para Creu Blanca (la empresa remitente)
salvo ratificación escrita por ambas partes. En caso de su recepción por error,
rogamos nos lo comunique por igual vía, se abstenga de realizar copias del mensaje
o documentos adjuntos, remitirlo o facilitarlo a un tercero, y proceda en su defecto,
a su eliminación.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by Pablo Fuentes Rodríguez - 06:06 - 14 Jul 2022

Re: Proposing myself as l10n-spain PSC

Helo,

I'm agree with the Enric reply. For the moment nevative vote.

Greetings

El 14/7/22 a las 15:07, Enric Tobella Alomar escribió:

IMO, It is too soon for Pablo being a PSC member. You can check how many PRS he has done on OCA and it is not so much:

https://github.com/pulls?q=is%3Apr+author%3Afuentes73+archived%3Afalse+user%3AOCA+sort%3Aupdated-desc

Most of them are from long time ago and only 6 in l10n-spain.

It is allways interesting to have PSCs, but I would prefer to see him more on action before.

Kind regards,

Enric Tobella Alomar

Av. J. V. Foix 63

08034 Barcelona

Tlf.    932 522 522 (Ext. 9611)

creublanca.es

From: Urtzi Pérez <notifications@odoo-community.org>
To: "Contributors" <contributors@odoo-community.org>
Date: Thu, 14 Jul 2022 11:56:57 -0000
Subject: Re: Proposing myself as l10n-spain PSC

Hi,

In my opinion Pablo is a +1 too.

I agree with every point Josean has explained, and as the responsible of the spanish localization and member of the board of Aeodoo, I'd like to reinforce Josean's words saying that the projects we are facing this year will result in a large amount of contributions in short periods of time, so we'd need some efficiency in the deepest technical reviews most contributors can't do (mostly because of lack of experience).

Pedro, I think the most important concept is to give the Spanish localization the push it needs. I'm sure that working with skilled people like Pablo could help you (and the other actual PSCs) to improve the repository's health.

Regards.

¿Nos dejas una reseña en Google My Business? Haz Clic Aquí

Urtzi Pérez

Departamento de desarrollo uperez@coninpe.es |  946 519 519

www.coninpe.es

946 519 519

Pol. Ind. Torrelarragoiti Parcela 8A- Pab. 10

48170  Zamudio

Aviso legal: Este mensaje electrónico está dirigido únicamente a la(s) dirección(es) indicadas anteriormente; el carácter confidencial, personal e intransferible del mismo está protegido legalmente. Cualquier revelación, uso o reenvío no autorizado, completo o en parte, está prohibido. Si ha recibido este mensaje por equivocación, notifíquelo inmediatamente a la persona que lo ha enviado y borre el mensaje original junto con sus ficheros anexos sin leerlo ni grabarlo, total o parcialmente

El jue, 14 jul 2022 a las 13:07, Pedro M. Baeza (Tecnativa) (<notifications@odoo-community.org>) escribió:

They can contribute the same reviewing and proposing pull requests. The only difference is the right to trigger the merge command. What can't be done is someone that hasn't contributed a lot yet to the localization to have the same merits that someone that has done a lot along the years.

This proposal can be reviewed in some time when the number of contributions will be significant.

Regards.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Tanto este mensaje como los documentos que, en su caso, lleve como anexos,
pueden contener información reservada y/o confidencial, destinada exclusivamente
para el uso del destinatario o la persona responsable de entregarlo al mismo,
estando su uso no autorizado prohibido legalmente.
Su contenido no constituye un compromiso para Creu Blanca (la empresa remitente)
salvo ratificación escrita por ambas partes. En caso de su recepción por error,
rogamos nos lo comunique por igual vía, se abstenga de realizar copias del mensaje
o documentos adjuntos, remitirlo o facilitarlo a un tercero, y proceda en su defecto,
a su eliminación.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--
Ignacio Ibeas
Acysos S.L. (www.acysos.com)
Odoo Partner (https://www.odoo.com/es_ES/partners/acysos-s-l-80090)
Asociado Asociación Española de Odoo (https://www.aeodoo.org/members/acysos-s-l-24)
Odoo Community Association (https://odoo-community.org/members/acysos-s-l-ignacio-ibeas-760)
Github (http://www.github.com/acysos)
Odoo Apps (https://www.odoo.com/apps/modules/browse?author=Acysos S.L.)
C/ Miguel Astrain 18, 1º Oficina A
31006 Pamplona, Navarra.
ignacio@acysos.com
Tel. 948238905
---------------------- // -------------------
La información contenida en este mensaje de correo electrónico es
confidencial, para ser leída por la(s) persona(s) a quién se dirige. El
acceso a este mensaje por otras personas no está autorizado. Si Ud. no es la
persona a la que va dirigido, cualquier divulgación, copia o distribución de
la información queda prohibida y puede ser ilegal. Asimismo, cualquier acción
tomada o dejada de tomar basada en la información contenida en este mensaje
queda prohibida y puede ser ilegal.
The information in this e-mail is confidential and may be legally privileged.
It is intended solely for the addressee. Access to this e-mail by anyone is
unauthorised. If you are not the intended recipient, any disclousure,
copying, distribuition or any action taken or omited to be taken in reliance
on it, is prohibited and may be unlawful.

by Ignacio Ibeas - 06:06 - 14 Jul 2022

Re: Proposing myself as l10n-spain PSC

IMO, It is too soon for Pablo being a PSC member. You can check how many PRS he has done on OCA and it is not so much:

https://github.com/pulls?q=is%3Apr+author%3Afuentes73+archived%3Afalse+user%3AOCA+sort%3Aupdated-desc

Most of them are from long time ago and only 6 in l10n-spain.

It is allways interesting to have PSCs, but I would prefer to see him more on action before.

Kind regards,

Enric Tobella Alomar

Av. J. V. Foix 63

08034 Barcelona

Tlf. 932 522 522 (Ext. 9611)

creublanca.es

From: Urtzi Pérez <notifications@odoo-community.org>
To: "Contributors" <contributors@odoo-community.org>
Date: Thu, 14 Jul 2022 11:56:57 -0000
Subject: Re: Proposing myself as l10n-spain PSC

Hi,

In my opinion Pablo is a +1 too.

I agree with every point Josean has explained, and as the responsible of the spanish localization and member of the board of Aeodoo, I'd like to reinforce Josean's words saying that the projects we are facing this year will result in a large amount of contributions in short periods of time, so we'd need some efficiency in the deepest technical reviews most contributors can't do (mostly because of lack of experience).

Pedro, I think the most important concept is to give the Spanish localization the push it needs. I'm sure that working with skilled people like Pablo could help you (and the other actual PSCs) to improve the repository's health.

Regards.

¿Nos dejas una reseña en Google My Business? Haz Clic Aquí

Urtzi Pérez

Departamento de desarrollo uperez@coninpe.es | 946 519 519

www.coninpe.es

946 519 519

Pol. Ind. Torrelarragoiti Parcela 8A- Pab. 10

48170 Zamudio

Aviso legal: Este mensaje electrónico está dirigido únicamente a la(s) dirección(es) indicadas anteriormente; el carácter confidencial, personal e intransferible del mismo está protegido legalmente. Cualquier revelación, uso o reenvío no autorizado, completo o en parte, está prohibido. Si ha recibido este mensaje por equivocación, notifíquelo inmediatamente a la persona que lo ha enviado y borre el mensaje original junto con sus ficheros anexos sin leerlo ni grabarlo, total o parcialmente

El jue, 14 jul 2022 a las 13:07, Pedro M. Baeza (Tecnativa) (<notifications@odoo-community.org>) escribió:

They can contribute the same reviewing and proposing pull requests. The only difference is the right to trigger the merge command. What can't be done is someone that hasn't contributed a lot yet to the localization to have the same merits that someone that has done a lot along the years.

This proposal can be reviewed in some time when the number of contributions will be significant.

Regards.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Tanto este mensaje como los documentos que, en su caso, lleve como anexos,
pueden contener información reservada y/o confidencial, destinada exclusivamente
para el uso del destinatario o la persona responsable de entregarlo al mismo,
estando su uso no autorizado prohibido legalmente.
Su contenido no constituye un compromiso para Creu Blanca (la empresa remitente)
salvo ratificación escrita por ambas partes. En caso de su recepción por error,
rogamos nos lo comunique por igual vía, se abstenga de realizar copias del mensaje
o documentos adjuntos, remitirlo o facilitarlo a un tercero, y proceda en su defecto,
a su eliminación.

by Enric Tobella Alomar - 03:06 - 14 Jul 2022

1 attachments 1 attachments

Re: Proposing myself as l10n-spain PSC

Sorry, but only PSCs can approve new requests, so your opinion can be welcome, but you don't know and understand enough PSC rules and what meritocracy means.

Regards.

by Pedro M. Baeza - 02:06 - 14 Jul 2022

Proposing myself as l10n-spain PSC

Hi all,

I would like to apply as PSC for https://github.com/OCA/l10n-spain

Main reason is I am an experienced developer and consultant in Spain, we are working with Odoo from 5.0 version (13 years of my life), first at Pexego with a lot of contributions in the early years of the community and localization, and for the last 6 years at Comunitea.
In the early years of OCA I belonged to core-commmiters github's group, I would like apporting to evolve more quickly our localization for next Odoo's version and contribute in the future fiscal demands.

My github account is
https://github.com/omar7r

Some contributions:
https://odoo-community.org/shop?search=pexego&order=total_download_count+desc
https://odoo-community.org/shop?order=total_download_count+desc&search=comunitea

Thanks for considering my request and regards.

Omar Castiñeira

Comunitea Servicios Tecnológicos S.L.

by Omar Castiñeira Saavedra - 10:01 - 13 Jul 2022

11 replies 11 replies

Re: Proposing myself as l10n-spain PSC

Hello,

I also agree.

Greetings

El 13/7/22 a las 16:46, Enric Tobella Alomar escribió:

I added you as member of the PSC team. GitHub invite should follow in the next 24h.

Best regards

Enric Tobella Alomar

creublanca.es

From: Omar Castiñeira <notifications@odoo-community.org>
To: "Contributors" <contributors@odoo-community.org>
Date: Wed, 13 Jul 2022 12:12:16 -0000
Subject: Re: Proposing myself as l10n-spain PSC

Thanks Pedro, nowadays I'm not a member of core contributors, in the early years yes.

El mié, 13 jul 2022 a las 11:32, Pedro M. Baeza (Tecnativa) (<notifications@odoo-community.org>) escribió:

OK, Omar is an experienced contributor and also in the localization repository. He doesn't need this PSC title, as he already has merge rights as core contributor, but there's no problem in have him on board.

+1

Regards.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Tanto este mensaje como los documentos que, en su caso, lleve como anexos,
pueden contener información reservada y/o confidencial, destinada exclusivamente
para el uso del destinatario o la persona responsable de entregarlo al mismo,
estando su uso no autorizado prohibido legalmente.
Su contenido no constituye un compromiso para Creu Blanca (la empresa remitente)
salvo ratificación escrita por ambas partes. En caso de su recepción por error,
rogamos nos lo comunique por igual vía, se abstenga de realizar copias del mensaje
o documentos adjuntos, remitirlo o facilitarlo a un tercero, y proceda en su defecto,
a su eliminación.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--
Ignacio Ibeas
Acysos S.L. (www.acysos.com)
Odoo Partner (https://www.odoo.com/es_ES/partners/acysos-s-l-80090)
Asociado Asociación Española de Odoo (https://www.aeodoo.org/members/acysos-s-l-24)
Odoo Community Association (https://odoo-community.org/members/acysos-s-l-ignacio-ibeas-760)
Github (http://www.github.com/acysos)
Odoo Apps (https://www.odoo.com/apps/modules/browse?author=Acysos S.L.)
C/ Miguel Astrain 18, 1º Oficina A
31006 Pamplona, Navarra.
ignacio@acysos.com
Tel. 948238905
---------------------- // -------------------
La información contenida en este mensaje de correo electrónico es
confidencial, para ser leída por la(s) persona(s) a quién se dirige. El
acceso a este mensaje por otras personas no está autorizado. Si Ud. no es la
persona a la que va dirigido, cualquier divulgación, copia o distribución de
la información queda prohibida y puede ser ilegal. Asimismo, cualquier acción
tomada o dejada de tomar basada en la información contenida en este mensaje
queda prohibida y puede ser ilegal.
The information in this e-mail is confidential and may be legally privileged.
It is intended solely for the addressee. Access to this e-mail by anyone is
unauthorised. If you are not the intended recipient, any disclousure,
copying, distribuition or any action taken or omited to be taken in reliance
on it, is prohibited and may be unlawful.

by Ignacio Ibeas - 05:50 - 14 Jul 2022
Re: Proposing myself as l10n-spain PSC

Hello,

I also agree.

Greetings

El 13/7/22 a las 16:46, Enric Tobella Alomar escribió:

I added you as member of the PSC team. GitHub invite should follow in the next 24h.

Best regards

Enric Tobella Alomar

creublanca.es

From: Omar Castiñeira <notifications@odoo-community.org>
To: "Contributors" <contributors@odoo-community.org>
Date: Wed, 13 Jul 2022 12:12:16 -0000
Subject: Re: Proposing myself as l10n-spain PSC

Thanks Pedro, nowadays I'm not a member of core contributors, in the early years yes.

El mié, 13 jul 2022 a las 11:32, Pedro M. Baeza (Tecnativa) (<notifications@odoo-community.org>) escribió:

OK, Omar is an experienced contributor and also in the localization repository. He doesn't need this PSC title, as he already has merge rights as core contributor, but there's no problem in have him on board.

+1

Regards.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Tanto este mensaje como los documentos que, en su caso, lleve como anexos,
pueden contener información reservada y/o confidencial, destinada exclusivamente
para el uso del destinatario o la persona responsable de entregarlo al mismo,
estando su uso no autorizado prohibido legalmente.
Su contenido no constituye un compromiso para Creu Blanca (la empresa remitente)
salvo ratificación escrita por ambas partes. En caso de su recepción por error,
rogamos nos lo comunique por igual vía, se abstenga de realizar copias del mensaje
o documentos adjuntos, remitirlo o facilitarlo a un tercero, y proceda en su defecto,
a su eliminación.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--
Ignacio Ibeas
Acysos S.L. (www.acysos.com)
Odoo Partner (https://www.odoo.com/es_ES/partners/acysos-s-l-80090)
Asociado Asociación Española de Odoo (https://www.aeodoo.org/members/acysos-s-l-24)
Odoo Community Association (https://odoo-community.org/members/acysos-s-l-ignacio-ibeas-760)
Github (http://www.github.com/acysos)
Odoo Apps (https://www.odoo.com/apps/modules/browse?author=Acysos S.L.)
C/ Miguel Astrain 18, 1º Oficina A
31006 Pamplona, Navarra.
ignacio@acysos.com
Tel. 948238905
---------------------- // -------------------
La información contenida en este mensaje de correo electrónico es
confidencial, para ser leída por la(s) persona(s) a quién se dirige. El
acceso a este mensaje por otras personas no está autorizado. Si Ud. no es la
persona a la que va dirigido, cualquier divulgación, copia o distribución de
la información queda prohibida y puede ser ilegal. Asimismo, cualquier acción
tomada o dejada de tomar basada en la información contenida en este mensaje
queda prohibida y puede ser ilegal.
The information in this e-mail is confidential and may be legally privileged.
It is intended solely for the addressee. Access to this e-mail by anyone is
unauthorised. If you are not the intended recipient, any disclousure,
copying, distribuition or any action taken or omited to be taken in reliance
on it, is prohibited and may be unlawful.

by Ignacio Ibeas - 05:41 - 14 Jul 2022
Re: Proposing myself as l10n-spain PSC

Great Omar, thanks for your help.
And congratulations for your approval.
-----------------------------------------------------------
Josean Soroa
LANDOO SL - www.landoo.es
-----------------------------------------------------------

El mié, 13 jul 2022 a las 10:01, Omar Castiñeira (<notifications@odoo-community.org>) escribió:
Hi all,

I would like to apply as PSC for https://github.com/OCA/l10n-spain

Main reason is I am an experienced developer and consultant in Spain, we are working with Odoo from 5.0 version (13 years of my life), first at Pexego with a lot of contributions in the early years of the community and localization, and for the last 6 years at Comunitea.
In the early years of OCA I belonged to core-commmiters github's group, I would like apporting to evolve more quickly our localization for next Odoo's version and contribute in the future fiscal demands.

My github account is
https://github.com/omar7r

Some contributions:
https://odoo-community.org/shop?search=pexego&order=total_download_count+desc
https://odoo-community.org/shop?order=total_download_count+desc&search=comunitea

Thanks for considering my request and regards.

Omar Castiñeira
Comunitea Servicios Tecnológicos S.L.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by Josean Soroa - 12:56 - 14 Jul 2022
RE: Proposing myself as l10n-spain PSC

Great news!!!

Thanks Omar!

De: Enric Tobella Alomar <notifications@odoo-community.org>
Enviado el: miércoles, 13 de julio de 2022 16:47
Para: Contributors <contributors@odoo-community.org>
Asunto: Re: Proposing myself as l10n-spain PSC

I added you as member of the PSC team. GitHub invite should follow in the next 24h.

Best regards

Enric Tobella Alomar
creublanca.es

by Rafael Blasco (Moduon) - 11:50 - 14 Jul 2022
Re: Proposing myself as l10n-spain PSC

I added you as member of the PSC team. GitHub invite should follow in the next 24h.

Best regards

Enric Tobella Alomar

creublanca.es

From: Omar Castiñeira <notifications@odoo-community.org>
To: "Contributors" <contributors@odoo-community.org>
Date: Wed, 13 Jul 2022 12:12:16 -0000
Subject: Re: Proposing myself as l10n-spain PSC

Thanks Pedro, nowadays I'm not a member of core contributors, in the early years yes.

El mié, 13 jul 2022 a las 11:32, Pedro M. Baeza (Tecnativa) (<notifications@odoo-community.org>) escribió:

OK, Omar is an experienced contributor and also in the localization repository. He doesn't need this PSC title, as he already has merge rights as core contributor, but there's no problem in have him on board.

+1

Regards.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Tanto este mensaje como los documentos que, en su caso, lleve como anexos,
pueden contener información reservada y/o confidencial, destinada exclusivamente
para el uso del destinatario o la persona responsable de entregarlo al mismo,
estando su uso no autorizado prohibido legalmente.
Su contenido no constituye un compromiso para Creu Blanca (la empresa remitente)
salvo ratificación escrita por ambas partes. En caso de su recepción por error,
rogamos nos lo comunique por igual vía, se abstenga de realizar copias del mensaje
o documentos adjuntos, remitirlo o facilitarlo a un tercero, y proceda en su defecto,
a su eliminación.

by Enric Tobella Alomar - 04:46 - 13 Jul 2022

1 attachments 1 attachments

CB 70anys Gris _ CB+ Color H RGB.png

Proposing myself as l10n-spain PSC

Hi all,

I would like to apply as PSC for https://github.com/OCA/l10n-spain

Main reason is the big development we are doing from last year to cover Basque Country requirements (Fiscal Ticketbai and Batuz project).
This task is not fully finished and we need a big push in next weeks.
Also in next months we have a team working in localization for Canary Islands, with also specific fiscal rules.
And in near future we expect to have important changes in rest of spanish fiscal rules.

I have contributed in this repository by migrating different modules (mainly TicketBAI modules) for last two years and I have a developer profile.

I have also been teaching other contributors how to correctly migrate different Spanish Localization modules to V15 in an event that was organized by the community a few months ago.

My github account is https://github.com/ao-landoo

Thanks for considering my request and regards.

--

Aritz Olea

ao@landoo.es

LANDOO - Sistemas de Información con Odoo

www.landoo.es

Tel.: +34 943 568 663

Zubiberri bidea 31, pl. 2, ofic. 3

Parque Empresarial Zuatzu, Edif. Urumea

20018 Donostia, Gipuzkoa, Spain

PARTNER OFICIAL ODOO "GOLD"

(En junio-2021, #1 del ranking entre los 60 partners de España, ver en www.odoo.com/partners)

CERTIFICADO ODOO V15, V14, V13, V12 y V11

Entrevista en Odoo Experience 2019: https://www.youtube.com/watch?v=XMtCe8F7JUc

by Aritz Olea - 09:11 - 13 Jul 2022

20 replies 20 replies

Re: Proposing myself as l10n-spain PSC

Just another precision.
I agree now we have no delays with merges in Basque localization, but that's because:
- Pedro, you are helping a lot. Many thanks for your constant effort and compromise with community.
- development has nearly stoped after Logroño OCA days.
Next weeks things are going to change and we want to be prepared.

Thanks and regards
-----------------------------------------------------------
Josean Soroa

El vie., 15 jul. 2022 14:52, Pedro M. Baeza (Tecnativa) <notifications@odoo-community.org> escribió:
Just one precision: it's not going to speed up anything, as the speed right now is immediate.

El vie., 15 jul. 2022 14:41, Josean Soroa - Landoo <notifications@odoo-community.org> escribió:
Hi.

In this case I think we have a good solution using maintainers rights, so we are not going to follow with this discussion.
In the mentoring project for v15, Aritz has mentored some modules not included in Basque localization and in the future he will continue this way, so we will talk about that in some months.

For now, as mentioned by Pedro, establishing Aritz as maintainer will be enough to speed up the migrations to v14 and 15, we are planning for this month.
Just for better comprehension of all, some light over very important details:
- we were told by Pedro and Tobella (or thats what we understood) about the right of maintainers to merge their modules, but restricted to same branch. This is not a solution for us, because we need to merge migration of modules and this in different branch.
- from Sylvain answer yesterday, we realized that 3 months there has been a new change in OCA rules, to allow maintainers do the same but also in different branches.
That's perfect for us and I want to thank Sylvain for this key contribution.
And for the rest of maintainers, take note of this new rule. Will be very useful.

Regards.
-----------------------------------------------------------
Josean Soroa

El jue, 14 jul 2022 a las 18:32, Pablo Fuentes (<notifications@odoo-community.org>) escribió:
Hi,

I compleatly agree with Jairo's message and I don't agree with create a new repo just for the basque country just because of don't want to promote Aritz.
If we talk about merits and meritocracy, Aritz has some... he is:
- Top 7 contributor by commits https://github.com/OCA/l10n-spain/graphs/contributors
- Top 13 contributor by additions https://github.com/OCA/l10n-spain/graphs/contributors?type=a

Best Regards,

El jue, 14 jul 2022 a las 18:02, Soporte Acysos (<notifications@odoo-community.org>) escribió:

Hello,

I'm the oldest PSC, but I know that now I'm less active.

Negative vote.

I always tell the things directly, I see there is a political movement, no meritocracy. Too much PSC in two days.
Aritz have experience only Basque Country localization. He only contribute in this localization. I don't think that need to be PSC for the moment.
If there is a separated project for Basque Country Localization, i think that will be a good PSC. But have separated repository for this localization is not necessary now.

Greetings,
Ignacio

El 14/7/22 a las 15:27, Pedro M. Baeza (Tecnativa) escribió:

Yeah, Aritz, it's the solution for that modules: to become a maintainer. I already told you about that in some occasion and to remove the current inactive maintainer.

Regards.

El jue., 14 jul. 2022 15:16, Aritz Olea <notifications@odoo-community.org> escribió:

Hi all,

Pedro, even if I were PSC I would not merge PRs of modules I don't know enough. I think it's more efficient having more PSCs specialized and motivated in some modules than trying to have someone specialized in all of them.

Thanks Graeme and Sylvain for your feedback. Sylvain, I didn't know the information you sent about the merge right of the module maintainers. This can be really helpful for us. If I don't get Pedro's approval, this can be a good solution for the Basque modules.

Regards.

El jue, 14 jul 2022 a las 14:56, Sylvain LE GAL (<notifications@odoo-community.org>) escribió:

Hi Graeme,

some precision inline.

regards.

Sylvain LE GAL - Twitter

GRAP - Service informatique (Groupement Régional Alimentaire de Proximité)

Site Web | FramaSphere | Facebook
3 Grande rue des Feuillants, 69001 Lyon
Standard : (+33) 09.72.32.33.17

Service Informatique : (+33) 09.73.79.64.40

Astreinte Informatique : (+33) 06.81.85.61.43
Member of the OCA (Odoo Community Association)

Web Site | Twitter

Le jeu. 14 juil. 2022 à 14:36, Graeme Gellatly <notifications@odoo-community.org> a écrit :

Hi Josean,

You raise an interesting point and part of this is how different repos evolved. We are starting to see a kind of natural split between a PSC with I suppose a high level view of a repository's purpose, strategy, inclusions exclusions etc and maintainers with specific module knowledge as repositories get larger. However, there is a tension that maintainers cannot merge even the code they maintain, but PSC's can. For me, long term the solution is merge rights for maintainers for the modules they maintain.

FYI,

- a developer has merge right on github for a PR if declared maintainers in the manifest of the modified module(s) for the current branch. That feature has been enabled since 3 years. (Ref.)

- a developper has also merge right on github for a PR if declared maintainer in the manifest of the modified module(s) for any branch. (past or future). That feature has been enabled since 3 monthes. (Ref)

Indeed, this is how almost all other opensource works. I know people with much more knowledge than me are working on this. But in this case, it may make more sense for a separate repository anyway. In fact maybe it makes sense for a lot of repos.

But also there are very many workarounds to a short term merge problem, and in a code sprint it often makes more sense to work separately anyway just for CI time, although maybe this no longer applies. I don't know the Spanish localisation at all, but FWIW the idea that fiscal specific code is going to be merged inside of two days into what is a very long lived and presumably stable repo is the opposite of a good reason. In fact, I thought the policy was 5 days after 2 approved reviews to allow any objections unless some good reason to override. Maybe I'm wrong, those principles have changed over time.

On Thu, Jul 14, 2022 at 10:52 PM Josean Soroa - Landoo <notifications@odoo-community.org> wrote:

Hi all.
Excuse me for this long answer but the question is very important for us.

My vote is +1 for Aritz.

My reasons are very similar to the case of Pablo:
- I believe in our l10n-spain repo, we shoudn't restrict PSCs to those with deep knowledge of all 39 modules. Selected PSCs should be professionals with enough experience on OCA contribution rules and aware of its limitations. They have to review and merge only modules within their area of expertise.
- I know him as a serious and responsible professional. I'm sure he is not going to merge PRs outside his expertise.
- Aritz is one of the few developers who knows deeply Basque Country localization

In are more deep explanation, I'm involved in this question by 3 different rules.
- As President of Aeodoo I'm trying to boost spanish localization and I believe that one of the mistakes in spanish community is the very small number of PSCs
From last year Urtzi (from Coninpe) is the member of the board of Aeodoo leading with spanish localization and results are very hopeful. Just see "Mentoring project". Hi has a very good vision on this point and is asking for more PSCs.
- As member of "Basque Country localization team", I'm actively working to add specific Basque fiscal requirements (basically Ticketbai). Leader of this team is Victor (from Kernet) and this days is in holidays, so I speak in his name. We are planning to proceed with two code sprints on this july and we need enough PSCs to not stop the development of this window. In this team we are 10 companies with a compromise of at least 2 resources dedicated to this activities, each one (so 20 people). Objective is to have all our needed developments from v13 to v15 at the end of July. This is not possible if we have to wait to much for merge. Take note that we are speaking about 5 modules x 2 versions (14 and 15) = 10 PRs with their approvals and merges.
This is too much work in a windows of 2 days for only one or two PSCs and they need good knowledge about Basque fiscality. None of actual PSCs is involved directly in this developments.
- As contributor I see other questions. For example, in Italy they have 9 PSCs (as explained by Sergio Corato in this mailing list). All of them are fully skilled in their 54 modules? I'm sure they're not. But I'm sure each one of them only merges modules that they know enough.

I hope other members of the community will agree with this point of view and will send a +1 to this applicant.

Thanks.
-----------------------------------------------------------
Josean Soroa
LANDOO SL - www.landoo.es
-----------------------------------------------------------

El mié, 13 jul 2022 a las 11:32, Pedro M. Baeza (Tecnativa) (<notifications@odoo-community.org>) escribió:

Sorry, Aritz, your experience in the localization is totally limited to TicketBAI, so for me as PSC representative of l10n-spain is a -1.

Regards.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--

Aritz Olea

LANDOO - Sistemas de Información con Odoo

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--
Acysos S.L. (www.acysos.com)
Odoo Partner (https://www.odoo.com/es_ES/partners/acysos-s-l-80090)
Asociado Asociación Española de Odoo (https://www.aeodoo.org/members/acysos-s-l-24)
Odoo Community Association (https://odoo-community.org/members/acysos-s-l-ignacio-ibeas-760)
Github (http://www.github.com/acysos)
Odoo Apps (https://www.odoo.com/apps/modules/browse?author=Acysos S.L.)
C/ Miguel Astrain 18, 1º Oficina A
31006 Pamplona, Navarra.
soporte@acysos.com
Tel. 948238905
---------------------- // -------------------
La información contenida en este mensaje de correo electrónico es
confidencial, para ser leída por la(s) persona(s) a quién se dirige. El
acceso a este mensaje por otras personas no está autorizado. Si Ud. no es la
persona a la que va dirigido, cualquier divulgación, copia o distribución de
la información queda prohibida y puede ser ilegal. Asimismo, cualquier acción
tomada o dejada de tomar basada en la información contenida en este mensaje
queda prohibida y puede ser ilegal.
The information in this e-mail is confidential and may be legally privileged.
It is intended solely for the addressee. Access to this e-mail by anyone is
unauthorised. If you are not the intended recipient, any disclousure,
copying, distribuition or any action taken or omited to be taken in reliance
on it, is prohibited and may be unlawful.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by Josean Soroa - 04:01 - 15 Jul 2022
Re: Proposing myself as l10n-spain PSC

Just one precision: it's not going to speed up anything, as the speed right now is immediate.

El vie., 15 jul. 2022 14:41, Josean Soroa - Landoo <notifications@odoo-community.org> escribió:
Hi.

In this case I think we have a good solution using maintainers rights, so we are not going to follow with this discussion.
In the mentoring project for v15, Aritz has mentored some modules not included in Basque localization and in the future he will continue this way, so we will talk about that in some months.

For now, as mentioned by Pedro, establishing Aritz as maintainer will be enough to speed up the migrations to v14 and 15, we are planning for this month.
Just for better comprehension of all, some light over very important details:
- we were told by Pedro and Tobella (or thats what we understood) about the right of maintainers to merge their modules, but restricted to same branch. This is not a solution for us, because we need to merge migration of modules and this in different branch.
- from Sylvain answer yesterday, we realized that 3 months there has been a new change in OCA rules, to allow maintainers do the same but also in different branches.
That's perfect for us and I want to thank Sylvain for this key contribution.
And for the rest of maintainers, take note of this new rule. Will be very useful.

Regards.
-----------------------------------------------------------
Josean Soroa

El jue, 14 jul 2022 a las 18:32, Pablo Fuentes (<notifications@odoo-community.org>) escribió:
Hi,

I compleatly agree with Jairo's message and I don't agree with create a new repo just for the basque country just because of don't want to promote Aritz.
If we talk about merits and meritocracy, Aritz has some... he is:
- Top 7 contributor by commits https://github.com/OCA/l10n-spain/graphs/contributors
- Top 13 contributor by additions https://github.com/OCA/l10n-spain/graphs/contributors?type=a

Best Regards,

El jue, 14 jul 2022 a las 18:02, Soporte Acysos (<notifications@odoo-community.org>) escribió:

Hello,

I'm the oldest PSC, but I know that now I'm less active.

Negative vote.

I always tell the things directly, I see there is a political movement, no meritocracy. Too much PSC in two days.
Aritz have experience only Basque Country localization. He only contribute in this localization. I don't think that need to be PSC for the moment.
If there is a separated project for Basque Country Localization, i think that will be a good PSC. But have separated repository for this localization is not necessary now.

Greetings,
Ignacio

El 14/7/22 a las 15:27, Pedro M. Baeza (Tecnativa) escribió:

Yeah, Aritz, it's the solution for that modules: to become a maintainer. I already told you about that in some occasion and to remove the current inactive maintainer.

Regards.

El jue., 14 jul. 2022 15:16, Aritz Olea <notifications@odoo-community.org> escribió:

Hi all,

Pedro, even if I were PSC I would not merge PRs of modules I don't know enough. I think it's more efficient having more PSCs specialized and motivated in some modules than trying to have someone specialized in all of them.

Thanks Graeme and Sylvain for your feedback. Sylvain, I didn't know the information you sent about the merge right of the module maintainers. This can be really helpful for us. If I don't get Pedro's approval, this can be a good solution for the Basque modules.

Regards.

El jue, 14 jul 2022 a las 14:56, Sylvain LE GAL (<notifications@odoo-community.org>) escribió:

Hi Graeme,

some precision inline.

regards.

Sylvain LE GAL - Twitter

GRAP - Service informatique (Groupement Régional Alimentaire de Proximité)

Site Web | FramaSphere | Facebook
3 Grande rue des Feuillants, 69001 Lyon
Standard : (+33) 09.72.32.33.17

Service Informatique : (+33) 09.73.79.64.40

Astreinte Informatique : (+33) 06.81.85.61.43
Member of the OCA (Odoo Community Association)

Web Site | Twitter

Le jeu. 14 juil. 2022 à 14:36, Graeme Gellatly <notifications@odoo-community.org> a écrit :

Hi Josean,

You raise an interesting point and part of this is how different repos evolved. We are starting to see a kind of natural split between a PSC with I suppose a high level view of a repository's purpose, strategy, inclusions exclusions etc and maintainers with specific module knowledge as repositories get larger. However, there is a tension that maintainers cannot merge even the code they maintain, but PSC's can. For me, long term the solution is merge rights for maintainers for the modules they maintain.

FYI,

- a developer has merge right on github for a PR if declared maintainers in the manifest of the modified module(s) for the current branch. That feature has been enabled since 3 years. (Ref.)

- a developper has also merge right on github for a PR if declared maintainer in the manifest of the modified module(s) for any branch. (past or future). That feature has been enabled since 3 monthes. (Ref)

Indeed, this is how almost all other opensource works. I know people with much more knowledge than me are working on this. But in this case, it may make more sense for a separate repository anyway. In fact maybe it makes sense for a lot of repos.

But also there are very many workarounds to a short term merge problem, and in a code sprint it often makes more sense to work separately anyway just for CI time, although maybe this no longer applies. I don't know the Spanish localisation at all, but FWIW the idea that fiscal specific code is going to be merged inside of two days into what is a very long lived and presumably stable repo is the opposite of a good reason. In fact, I thought the policy was 5 days after 2 approved reviews to allow any objections unless some good reason to override. Maybe I'm wrong, those principles have changed over time.

On Thu, Jul 14, 2022 at 10:52 PM Josean Soroa - Landoo <notifications@odoo-community.org> wrote:

Hi all.
Excuse me for this long answer but the question is very important for us.

My vote is +1 for Aritz.

My reasons are very similar to the case of Pablo:
- I believe in our l10n-spain repo, we shoudn't restrict PSCs to those with deep knowledge of all 39 modules. Selected PSCs should be professionals with enough experience on OCA contribution rules and aware of its limitations. They have to review and merge only modules within their area of expertise.
- I know him as a serious and responsible professional. I'm sure he is not going to merge PRs outside his expertise.
- Aritz is one of the few developers who knows deeply Basque Country localization

In are more deep explanation, I'm involved in this question by 3 different rules.
- As President of Aeodoo I'm trying to boost spanish localization and I believe that one of the mistakes in spanish community is the very small number of PSCs
From last year Urtzi (from Coninpe) is the member of the board of Aeodoo leading with spanish localization and results are very hopeful. Just see "Mentoring project". Hi has a very good vision on this point and is asking for more PSCs.
- As member of "Basque Country localization team", I'm actively working to add specific Basque fiscal requirements (basically Ticketbai). Leader of this team is Victor (from Kernet) and this days is in holidays, so I speak in his name. We are planning to proceed with two code sprints on this july and we need enough PSCs to not stop the development of this window. In this team we are 10 companies with a compromise of at least 2 resources dedicated to this activities, each one (so 20 people). Objective is to have all our needed developments from v13 to v15 at the end of July. This is not possible if we have to wait to much for merge. Take note that we are speaking about 5 modules x 2 versions (14 and 15) = 10 PRs with their approvals and merges.
This is too much work in a windows of 2 days for only one or two PSCs and they need good knowledge about Basque fiscality. None of actual PSCs is involved directly in this developments.
- As contributor I see other questions. For example, in Italy they have 9 PSCs (as explained by Sergio Corato in this mailing list). All of them are fully skilled in their 54 modules? I'm sure they're not. But I'm sure each one of them only merges modules that they know enough.

I hope other members of the community will agree with this point of view and will send a +1 to this applicant.

Thanks.
-----------------------------------------------------------
Josean Soroa
LANDOO SL - www.landoo.es
-----------------------------------------------------------

El mié, 13 jul 2022 a las 11:32, Pedro M. Baeza (Tecnativa) (<notifications@odoo-community.org>) escribió:

Sorry, Aritz, your experience in the localization is totally limited to TicketBAI, so for me as PSC representative of l10n-spain is a -1.

Regards.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--

Aritz Olea

LANDOO - Sistemas de Información con Odoo

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--
Acysos S.L. (www.acysos.com)
Odoo Partner (https://www.odoo.com/es_ES/partners/acysos-s-l-80090)
Asociado Asociación Española de Odoo (https://www.aeodoo.org/members/acysos-s-l-24)
Odoo Community Association (https://odoo-community.org/members/acysos-s-l-ignacio-ibeas-760)
Github (http://www.github.com/acysos)
Odoo Apps (https://www.odoo.com/apps/modules/browse?author=Acysos S.L.)
C/ Miguel Astrain 18, 1º Oficina A
31006 Pamplona, Navarra.
soporte@acysos.com
Tel. 948238905
---------------------- // -------------------
La información contenida en este mensaje de correo electrónico es
confidencial, para ser leída por la(s) persona(s) a quién se dirige. El
acceso a este mensaje por otras personas no está autorizado. Si Ud. no es la
persona a la que va dirigido, cualquier divulgación, copia o distribución de
la información queda prohibida y puede ser ilegal. Asimismo, cualquier acción
tomada o dejada de tomar basada en la información contenida en este mensaje
queda prohibida y puede ser ilegal.
The information in this e-mail is confidential and may be legally privileged.
It is intended solely for the addressee. Access to this e-mail by anyone is
unauthorised. If you are not the intended recipient, any disclousure,
copying, distribuition or any action taken or omited to be taken in reliance
on it, is prohibited and may be unlawful.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by Pedro M. Baeza - 02:51 - 15 Jul 2022
Re: Proposing myself as l10n-spain PSC

Hi.

In this case I think we have a good solution using maintainers rights, so we are not going to follow with this discussion.
In the mentoring project for v15, Aritz has mentored some modules not included in Basque localization and in the future he will continue this way, so we will talk about that in some months.

For now, as mentioned by Pedro, establishing Aritz as maintainer will be enough to speed up the migrations to v14 and 15, we are planning for this month.
Just for better comprehension of all, some light over very important details:
- we were told by Pedro and Tobella (or thats what we understood) about the right of maintainers to merge their modules, but restricted to same branch. This is not a solution for us, because we need to merge migration of modules and this in different branch.
- from Sylvain answer yesterday, we realized that 3 months there has been a new change in OCA rules, to allow maintainers do the same but also in different branches.
That's perfect for us and I want to thank Sylvain for this key contribution.
And for the rest of maintainers, take note of this new rule. Will be very useful.

Regards.
-----------------------------------------------------------
Josean Soroa

El jue, 14 jul 2022 a las 18:32, Pablo Fuentes (<notifications@odoo-community.org>) escribió:
Hi,

I compleatly agree with Jairo's message and I don't agree with create a new repo just for the basque country just because of don't want to promote Aritz.
If we talk about merits and meritocracy, Aritz has some... he is:
- Top 7 contributor by commits https://github.com/OCA/l10n-spain/graphs/contributors
- Top 13 contributor by additions https://github.com/OCA/l10n-spain/graphs/contributors?type=a

Best Regards,

El jue, 14 jul 2022 a las 18:02, Soporte Acysos (<notifications@odoo-community.org>) escribió:

Hello,

I'm the oldest PSC, but I know that now I'm less active.

Negative vote.

I always tell the things directly, I see there is a political movement, no meritocracy. Too much PSC in two days.
Aritz have experience only Basque Country localization. He only contribute in this localization. I don't think that need to be PSC for the moment.
If there is a separated project for Basque Country Localization, i think that will be a good PSC. But have separated repository for this localization is not necessary now.

Greetings,
Ignacio

El 14/7/22 a las 15:27, Pedro M. Baeza (Tecnativa) escribió:

Yeah, Aritz, it's the solution for that modules: to become a maintainer. I already told you about that in some occasion and to remove the current inactive maintainer.

Regards.

El jue., 14 jul. 2022 15:16, Aritz Olea <notifications@odoo-community.org> escribió:

Hi all,

Pedro, even if I were PSC I would not merge PRs of modules I don't know enough. I think it's more efficient having more PSCs specialized and motivated in some modules than trying to have someone specialized in all of them.

Thanks Graeme and Sylvain for your feedback. Sylvain, I didn't know the information you sent about the merge right of the module maintainers. This can be really helpful for us. If I don't get Pedro's approval, this can be a good solution for the Basque modules.

Regards.

El jue, 14 jul 2022 a las 14:56, Sylvain LE GAL (<notifications@odoo-community.org>) escribió:

Hi Graeme,

some precision inline.

regards.

Sylvain LE GAL - Twitter

GRAP - Service informatique (Groupement Régional Alimentaire de Proximité)

Site Web | FramaSphere | Facebook
3 Grande rue des Feuillants, 69001 Lyon
Standard : (+33) 09.72.32.33.17

Service Informatique : (+33) 09.73.79.64.40

Astreinte Informatique : (+33) 06.81.85.61.43
Member of the OCA (Odoo Community Association)

Web Site | Twitter

Le jeu. 14 juil. 2022 à 14:36, Graeme Gellatly <notifications@odoo-community.org> a écrit :

Hi Josean,

You raise an interesting point and part of this is how different repos evolved. We are starting to see a kind of natural split between a PSC with I suppose a high level view of a repository's purpose, strategy, inclusions exclusions etc and maintainers with specific module knowledge as repositories get larger. However, there is a tension that maintainers cannot merge even the code they maintain, but PSC's can. For me, long term the solution is merge rights for maintainers for the modules they maintain.

FYI,

- a developer has merge right on github for a PR if declared maintainers in the manifest of the modified module(s) for the current branch. That feature has been enabled since 3 years. (Ref.)

- a developper has also merge right on github for a PR if declared maintainer in the manifest of the modified module(s) for any branch. (past or future). That feature has been enabled since 3 monthes. (Ref)

Indeed, this is how almost all other opensource works. I know people with much more knowledge than me are working on this. But in this case, it may make more sense for a separate repository anyway. In fact maybe it makes sense for a lot of repos.

But also there are very many workarounds to a short term merge problem, and in a code sprint it often makes more sense to work separately anyway just for CI time, although maybe this no longer applies. I don't know the Spanish localisation at all, but FWIW the idea that fiscal specific code is going to be merged inside of two days into what is a very long lived and presumably stable repo is the opposite of a good reason. In fact, I thought the policy was 5 days after 2 approved reviews to allow any objections unless some good reason to override. Maybe I'm wrong, those principles have changed over time.

On Thu, Jul 14, 2022 at 10:52 PM Josean Soroa - Landoo <notifications@odoo-community.org> wrote:

Hi all.
Excuse me for this long answer but the question is very important for us.

My vote is +1 for Aritz.

My reasons are very similar to the case of Pablo:
- I believe in our l10n-spain repo, we shoudn't restrict PSCs to those with deep knowledge of all 39 modules. Selected PSCs should be professionals with enough experience on OCA contribution rules and aware of its limitations. They have to review and merge only modules within their area of expertise.
- I know him as a serious and responsible professional. I'm sure he is not going to merge PRs outside his expertise.
- Aritz is one of the few developers who knows deeply Basque Country localization

In are more deep explanation, I'm involved in this question by 3 different rules.
- As President of Aeodoo I'm trying to boost spanish localization and I believe that one of the mistakes in spanish community is the very small number of PSCs
From last year Urtzi (from Coninpe) is the member of the board of Aeodoo leading with spanish localization and results are very hopeful. Just see "Mentoring project". Hi has a very good vision on this point and is asking for more PSCs.
- As member of "Basque Country localization team", I'm actively working to add specific Basque fiscal requirements (basically Ticketbai). Leader of this team is Victor (from Kernet) and this days is in holidays, so I speak in his name. We are planning to proceed with two code sprints on this july and we need enough PSCs to not stop the development of this window. In this team we are 10 companies with a compromise of at least 2 resources dedicated to this activities, each one (so 20 people). Objective is to have all our needed developments from v13 to v15 at the end of July. This is not possible if we have to wait to much for merge. Take note that we are speaking about 5 modules x 2 versions (14 and 15) = 10 PRs with their approvals and merges.
This is too much work in a windows of 2 days for only one or two PSCs and they need good knowledge about Basque fiscality. None of actual PSCs is involved directly in this developments.
- As contributor I see other questions. For example, in Italy they have 9 PSCs (as explained by Sergio Corato in this mailing list). All of them are fully skilled in their 54 modules? I'm sure they're not. But I'm sure each one of them only merges modules that they know enough.

I hope other members of the community will agree with this point of view and will send a +1 to this applicant.

Thanks.
-----------------------------------------------------------
Josean Soroa
LANDOO SL - www.landoo.es
-----------------------------------------------------------

El mié, 13 jul 2022 a las 11:32, Pedro M. Baeza (Tecnativa) (<notifications@odoo-community.org>) escribió:

Sorry, Aritz, your experience in the localization is totally limited to TicketBAI, so for me as PSC representative of l10n-spain is a -1.

Regards.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--

Aritz Olea

LANDOO - Sistemas de Información con Odoo

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--
Acysos S.L. (www.acysos.com)
Odoo Partner (https://www.odoo.com/es_ES/partners/acysos-s-l-80090)
Asociado Asociación Española de Odoo (https://www.aeodoo.org/members/acysos-s-l-24)
Odoo Community Association (https://odoo-community.org/members/acysos-s-l-ignacio-ibeas-760)
Github (http://www.github.com/acysos)
Odoo Apps (https://www.odoo.com/apps/modules/browse?author=Acysos S.L.)
C/ Miguel Astrain 18, 1º Oficina A
31006 Pamplona, Navarra.
soporte@acysos.com
Tel. 948238905
---------------------- // -------------------
La información contenida en este mensaje de correo electrónico es
confidencial, para ser leída por la(s) persona(s) a quién se dirige. El
acceso a este mensaje por otras personas no está autorizado. Si Ud. no es la
persona a la que va dirigido, cualquier divulgación, copia o distribución de
la información queda prohibida y puede ser ilegal. Asimismo, cualquier acción
tomada o dejada de tomar basada en la información contenida en este mensaje
queda prohibida y puede ser ilegal.
The information in this e-mail is confidential and may be legally privileged.
It is intended solely for the addressee. Access to this e-mail by anyone is
unauthorised. If you are not the intended recipient, any disclousure,
copying, distribuition or any action taken or omited to be taken in reliance
on it, is prohibited and may be unlawful.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by Josean Soroa - 02:41 - 15 Jul 2022
Re: Proposing myself as l10n-spain PSC

Hi,

I compleatly agree with Jairo's message and I don't agree with create a new repo just for the basque country just because of don't want to promote Aritz.
If we talk about merits and meritocracy, Aritz has some... he is:
- Top 7 contributor by commits https://github.com/OCA/l10n-spain/graphs/contributors
- Top 13 contributor by additions https://github.com/OCA/l10n-spain/graphs/contributors?type=a

Best Regards,

El jue, 14 jul 2022 a las 18:02, Soporte Acysos (<notifications@odoo-community.org>) escribió:

Hello,

I'm the oldest PSC, but I know that now I'm less active.

Negative vote.

I always tell the things directly, I see there is a political movement, no meritocracy. Too much PSC in two days.
Aritz have experience only Basque Country localization. He only contribute in this localization. I don't think that need to be PSC for the moment.
If there is a separated project for Basque Country Localization, i think that will be a good PSC. But have separated repository for this localization is not necessary now.

Greetings,
Ignacio

El 14/7/22 a las 15:27, Pedro M. Baeza (Tecnativa) escribió:

Yeah, Aritz, it's the solution for that modules: to become a maintainer. I already told you about that in some occasion and to remove the current inactive maintainer.

Regards.

El jue., 14 jul. 2022 15:16, Aritz Olea <notifications@odoo-community.org> escribió:

Hi all,

Pedro, even if I were PSC I would not merge PRs of modules I don't know enough. I think it's more efficient having more PSCs specialized and motivated in some modules than trying to have someone specialized in all of them.

Thanks Graeme and Sylvain for your feedback. Sylvain, I didn't know the information you sent about the merge right of the module maintainers. This can be really helpful for us. If I don't get Pedro's approval, this can be a good solution for the Basque modules.

Regards.

El jue, 14 jul 2022 a las 14:56, Sylvain LE GAL (<notifications@odoo-community.org>) escribió:

Hi Graeme,

some precision inline.

regards.

Sylvain LE GAL - Twitter

GRAP - Service informatique (Groupement Régional Alimentaire de Proximité)

Site Web | FramaSphere | Facebook
3 Grande rue des Feuillants, 69001 Lyon
Standard : (+33) 09.72.32.33.17

Service Informatique : (+33) 09.73.79.64.40

Astreinte Informatique : (+33) 06.81.85.61.43
Member of the OCA (Odoo Community Association)

Web Site | Twitter

Le jeu. 14 juil. 2022 à 14:36, Graeme Gellatly <notifications@odoo-community.org> a écrit :

Hi Josean,

You raise an interesting point and part of this is how different repos evolved. We are starting to see a kind of natural split between a PSC with I suppose a high level view of a repository's purpose, strategy, inclusions exclusions etc and maintainers with specific module knowledge as repositories get larger. However, there is a tension that maintainers cannot merge even the code they maintain, but PSC's can. For me, long term the solution is merge rights for maintainers for the modules they maintain.

FYI,

- a developer has merge right on github for a PR if declared maintainers in the manifest of the modified module(s) for the current branch. That feature has been enabled since 3 years. (Ref.)

- a developper has also merge right on github for a PR if declared maintainer in the manifest of the modified module(s) for any branch. (past or future). That feature has been enabled since 3 monthes. (Ref)

Indeed, this is how almost all other opensource works. I know people with much more knowledge than me are working on this. But in this case, it may make more sense for a separate repository anyway. In fact maybe it makes sense for a lot of repos.

But also there are very many workarounds to a short term merge problem, and in a code sprint it often makes more sense to work separately anyway just for CI time, although maybe this no longer applies. I don't know the Spanish localisation at all, but FWIW the idea that fiscal specific code is going to be merged inside of two days into what is a very long lived and presumably stable repo is the opposite of a good reason. In fact, I thought the policy was 5 days after 2 approved reviews to allow any objections unless some good reason to override. Maybe I'm wrong, those principles have changed over time.

On Thu, Jul 14, 2022 at 10:52 PM Josean Soroa - Landoo <notifications@odoo-community.org> wrote:

Hi all.
Excuse me for this long answer but the question is very important for us.

My vote is +1 for Aritz.

My reasons are very similar to the case of Pablo:
- I believe in our l10n-spain repo, we shoudn't restrict PSCs to those with deep knowledge of all 39 modules. Selected PSCs should be professionals with enough experience on OCA contribution rules and aware of its limitations. They have to review and merge only modules within their area of expertise.
- I know him as a serious and responsible professional. I'm sure he is not going to merge PRs outside his expertise.
- Aritz is one of the few developers who knows deeply Basque Country localization

In are more deep explanation, I'm involved in this question by 3 different rules.
- As President of Aeodoo I'm trying to boost spanish localization and I believe that one of the mistakes in spanish community is the very small number of PSCs
From last year Urtzi (from Coninpe) is the member of the board of Aeodoo leading with spanish localization and results are very hopeful. Just see "Mentoring project". Hi has a very good vision on this point and is asking for more PSCs.
- As member of "Basque Country localization team", I'm actively working to add specific Basque fiscal requirements (basically Ticketbai). Leader of this team is Victor (from Kernet) and this days is in holidays, so I speak in his name. We are planning to proceed with two code sprints on this july and we need enough PSCs to not stop the development of this window. In this team we are 10 companies with a compromise of at least 2 resources dedicated to this activities, each one (so 20 people). Objective is to have all our needed developments from v13 to v15 at the end of July. This is not possible if we have to wait to much for merge. Take note that we are speaking about 5 modules x 2 versions (14 and 15) = 10 PRs with their approvals and merges.
This is too much work in a windows of 2 days for only one or two PSCs and they need good knowledge about Basque fiscality. None of actual PSCs is involved directly in this developments.
- As contributor I see other questions. For example, in Italy they have 9 PSCs (as explained by Sergio Corato in this mailing list). All of them are fully skilled in their 54 modules? I'm sure they're not. But I'm sure each one of them only merges modules that they know enough.

I hope other members of the community will agree with this point of view and will send a +1 to this applicant.

Thanks.
-----------------------------------------------------------
Josean Soroa
LANDOO SL - www.landoo.es
-----------------------------------------------------------

El mié, 13 jul 2022 a las 11:32, Pedro M. Baeza (Tecnativa) (<notifications@odoo-community.org>) escribió:

Sorry, Aritz, your experience in the localization is totally limited to TicketBAI, so for me as PSC representative of l10n-spain is a -1.

Regards.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--

Aritz Olea

LANDOO - Sistemas de Información con Odoo

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--
Acysos S.L. (www.acysos.com)
Odoo Partner (https://www.odoo.com/es_ES/partners/acysos-s-l-80090)
Asociado Asociación Española de Odoo (https://www.aeodoo.org/members/acysos-s-l-24)
Odoo Community Association (https://odoo-community.org/members/acysos-s-l-ignacio-ibeas-760)
Github (http://www.github.com/acysos)
Odoo Apps (https://www.odoo.com/apps/modules/browse?author=Acysos S.L.)
C/ Miguel Astrain 18, 1º Oficina A
31006 Pamplona, Navarra.
soporte@acysos.com
Tel. 948238905
---------------------- // -------------------
La información contenida en este mensaje de correo electrónico es
confidencial, para ser leída por la(s) persona(s) a quién se dirige. El
acceso a este mensaje por otras personas no está autorizado. Si Ud. no es la
persona a la que va dirigido, cualquier divulgación, copia o distribución de
la información queda prohibida y puede ser ilegal. Asimismo, cualquier acción
tomada o dejada de tomar basada en la información contenida en este mensaje
queda prohibida y puede ser ilegal.
The information in this e-mail is confidential and may be legally privileged.
It is intended solely for the addressee. Access to this e-mail by anyone is
unauthorised. If you are not the intended recipient, any disclousure,
copying, distribuition or any action taken or omited to be taken in reliance
on it, is prohibited and may be unlawful.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by Pablo Fuentes Rodríguez - 06:30 - 14 Jul 2022
Re: Proposing myself as l10n-spain PSC

Hello,

I'm the oldest PSC, but I know that now I'm less active.

Negative vote.

I always tell the things directly, I see there is a political movement, no meritocracy. Too much PSC in two days.
Aritz have experience only Basque Country localization. He only contribute in this localization. I don't think that need to be PSC for the moment.
If there is a separated project for Basque Country Localization, i think that will be a good PSC. But have separated repository for this localization is not necessary now.

Greetings,

Ignacio

El 14/7/22 a las 15:27, Pedro M. Baeza (Tecnativa) escribió:

Yeah, Aritz, it's the solution for that modules: to become a maintainer. I already told you about that in some occasion and to remove the current inactive maintainer.

Regards.

El jue., 14 jul. 2022 15:16, Aritz Olea <notifications@odoo-community.org> escribió:

Hi all,

Pedro, even if I were PSC I would not merge PRs of modules I don't know enough. I think it's more efficient having more PSCs specialized and motivated in some modules than trying to have someone specialized in all of them.

Thanks Graeme and Sylvain for your feedback. Sylvain, I didn't know the information you sent about the merge right of the module maintainers. This can be really helpful for us. If I don't get Pedro's approval, this can be a good solution for the Basque modules.

Regards.

El jue, 14 jul 2022 a las 14:56, Sylvain LE GAL (<notifications@odoo-community.org>) escribió:

Hi Graeme,

some precision inline.

regards.

Sylvain LE GAL - Twitter

GRAP - Service informatique (Groupement Régional Alimentaire de Proximité)

Site Web | FramaSphere | Facebook
3 Grande rue des Feuillants, 69001 Lyon
Standard : (+33) 09.72.32.33.17

Service Informatique : (+33) 09.73.79.64.40

Astreinte Informatique : (+33) 06.81.85.61.43
Member of the OCA (Odoo Community Association)

Web Site | Twitter

Le jeu. 14 juil. 2022 à 14:36, Graeme Gellatly <notifications@odoo-community.org> a écrit :

Hi Josean,

You raise an interesting point and part of this is how different repos evolved. We are starting to see a kind of natural split between a PSC with I suppose a high level view of a repository's purpose, strategy, inclusions exclusions etc and maintainers with specific module knowledge as repositories get larger. However, there is a tension that maintainers cannot merge even the code they maintain, but PSC's can. For me, long term the solution is merge rights for maintainers for the modules they maintain.

FYI,

- a developer has merge right on github for a PR if declared maintainers in the manifest of the modified module(s) for the current branch. That feature has been enabled since 3 years. (Ref.)

- a developper has also merge right on github for a PR if declared maintainer in the manifest of the modified module(s) for any branch. (past or future). That feature has been enabled since 3 monthes. (Ref)

Indeed, this is how almost all other opensource works. I know people with much more knowledge than me are working on this. But in this case, it may make more sense for a separate repository anyway. In fact maybe it makes sense for a lot of repos.

But also there are very many workarounds to a short term merge problem, and in a code sprint it often makes more sense to work separately anyway just for CI time, although maybe this no longer applies. I don't know the Spanish localisation at all, but FWIW the idea that fiscal specific code is going to be merged inside of two days into what is a very long lived and presumably stable repo is the opposite of a good reason. In fact, I thought the policy was 5 days after 2 approved reviews to allow any objections unless some good reason to override. Maybe I'm wrong, those principles have changed over time.

On Thu, Jul 14, 2022 at 10:52 PM Josean Soroa - Landoo <notifications@odoo-community.org> wrote:

Hi all.
Excuse me for this long answer but the question is very important for us.

My vote is +1 for Aritz.

My reasons are very similar to the case of Pablo:
- I believe in our l10n-spain repo, we shoudn't restrict PSCs to those with deep knowledge of all 39 modules. Selected PSCs should be professionals with enough experience on OCA contribution rules and aware of its limitations. They have to review and merge only modules within their area of expertise.
- I know him as a serious and responsible professional. I'm sure he is not going to merge PRs outside his expertise.
- Aritz is one of the few developers who knows deeply Basque Country localization

In are more deep explanation, I'm involved in this question by 3 different rules.
- As President of Aeodoo I'm trying to boost spanish localization and I believe that one of the mistakes in spanish community is the very small number of PSCs
From last year Urtzi (from Coninpe) is the member of the board of Aeodoo leading with spanish localization and results are very hopeful. Just see "Mentoring project". Hi has a very good vision on this point and is asking for more PSCs.
- As member of "Basque Country localization team", I'm actively working to add specific Basque fiscal requirements (basically Ticketbai). Leader of this team is Victor (from Kernet) and this days is in holidays, so I speak in his name. We are planning to proceed with two code sprints on this july and we need enough PSCs to not stop the development of this window. In this team we are 10 companies with a compromise of at least 2 resources dedicated to this activities, each one (so 20 people). Objective is to have all our needed developments from v13 to v15 at the end of July. This is not possible if we have to wait to much for merge. Take note that we are speaking about 5 modules x 2 versions (14 and 15) = 10 PRs with their approvals and merges.
This is too much work in a windows of 2 days for only one or two PSCs and they need good knowledge about Basque fiscality. None of actual PSCs is involved directly in this developments.
- As contributor I see other questions. For example, in Italy they have 9 PSCs (as explained by Sergio Corato in this mailing list). All of them are fully skilled in their 54 modules? I'm sure they're not. But I'm sure each one of them only merges modules that they know enough.

I hope other members of the community will agree with this point of view and will send a +1 to this applicant.

Thanks.
-----------------------------------------------------------
Josean Soroa
LANDOO SL - www.landoo.es
-----------------------------------------------------------

El mié, 13 jul 2022 a las 11:32, Pedro M. Baeza (Tecnativa) (<notifications@odoo-community.org>) escribió:

Sorry, Aritz, your experience in the localization is totally limited to TicketBAI, so for me as PSC representative of l10n-spain is a -1.

Regards.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--

Aritz Olea

LANDOO - Sistemas de Información con Odoo

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--
Ignacio Ibeas
Acysos S.L. (www.acysos.com)
Odoo Partner (https://www.odoo.com/es_ES/partners/acysos-s-l-80090)
Asociado Asociación Española de Odoo (https://www.aeodoo.org/members/acysos-s-l-24)
Odoo Community Association (https://odoo-community.org/members/acysos-s-l-ignacio-ibeas-760)
Github (http://www.github.com/acysos)
Odoo Apps (https://www.odoo.com/apps/modules/browse?author=Acysos S.L.)
C/ Miguel Astrain 18, 1º Oficina A
31006 Pamplona, Navarra.
ignacio@acysos.com
Tel. 948238905
---------------------- // -------------------
La información contenida en este mensaje de correo electrónico es
confidencial, para ser leída por la(s) persona(s) a quién se dirige. El
acceso a este mensaje por otras personas no está autorizado. Si Ud. no es la
persona a la que va dirigido, cualquier divulgación, copia o distribución de
la información queda prohibida y puede ser ilegal. Asimismo, cualquier acción
tomada o dejada de tomar basada en la información contenida en este mensaje
queda prohibida y puede ser ilegal.
The information in this e-mail is confidential and may be legally privileged.
It is intended solely for the addressee. Access to this e-mail by anyone is
unauthorised. If you are not the intended recipient, any disclousure,
copying, distribuition or any action taken or omited to be taken in reliance
on it, is prohibited and may be unlawful.

by Ignacio Ibeas - 06:10 - 14 Jul 2022

Proposing myself as l10n-spain PSC

Hi all,

I would like to apply as PSC for https://github.com/OCA/l10n-spain

Main reason is the big development we are doing from last year to cover
Basque Country requirements (Fiscal Ticketbai and Batuz project).
This task is not fully finished and we need a big push in next weeks.
Also in next months we have a team working in localization for Canary
Islands, with also specific fiscal rules.
And in near future we expect to have important changes in rest of
spanish fiscal rules.

I have contributed in this repository for last years and I have a
developer and functional profile.


My github account is https://github.com/cubells

Thanks for considering my request and regards.

Vicent Cubells
Trey, kilobytes de soluciones



-- 
Atentament, cubells.
--

by Vicent Cubells Peña - 09:01 - 13 Jul 2022

12 replies 12 replies

Re: Proposing myself as l10n-spain PSC
Hello,

I also agree.

Greetings

El 13/7/22 a las 16:46, Enric Tobella Alomar escribió:

I added you as member of the PSC team. GitHub invite should follow in the next 24h.

Best regards

Enric Tobella Alomar

Av. J. V. Foix 63

08034 Barcelona

Tlf. 932 522 522 (Ext. 9611)

creublanca.es

From: "cubells" <notifications@odoo-community.org>
To: "Contributors" <contributors@odoo-community.org>
Date: Wed, 13 Jul 2022 07:02:10 -0000
Subject: Proposing myself as l10n-spain PSC

Hi all, I would like to apply as PSC for https://github.com/OCA/l10n-spain Main reason is the big development we are doing from last year to cover Basque Country requirements (Fiscal Ticketbai and Batuz project). This task is not fully finished and we need a big push in next weeks. Also in next months we have a team working in localization for Canary Islands, with also specific fiscal rules. And in near future we expect to have important changes in rest of spanish fiscal rules. I have contributed in this repository for last years and I have a developer and functional profile. My github account is https://github.com/cubells Thanks for considering my request and regards. Vicent Cubells Trey, kilobytes de soluciones -- Atentament, cubells. --

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Tanto este mensaje como los documentos que, en su caso, lleve como anexos,
pueden contener información reservada y/o confidencial, destinada exclusivamente
para el uso del destinatario o la persona responsable de entregarlo al mismo,
estando su uso no autorizado prohibido legalmente.
Su contenido no constituye un compromiso para Creu Blanca (la empresa remitente)
salvo ratificación escrita por ambas partes. En caso de su recepción por error,
rogamos nos lo comunique por igual vía, se abstenga de realizar copias del mensaje
o documentos adjuntos, remitirlo o facilitarlo a un tercero, y proceda en su defecto,
a su eliminación.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--
Ignacio Ibeas
Acysos S.L. (www.acysos.com)
Odoo Partner (https://www.odoo.com/es_ES/partners/acysos-s-l-80090)
Asociado Asociación Española de Odoo (https://www.aeodoo.org/members/acysos-s-l-24)
Odoo Community Association (https://odoo-community.org/members/acysos-s-l-ignacio-ibeas-760)
Github (http://www.github.com/acysos)
Odoo Apps (https://www.odoo.com/apps/modules/browse?author=Acysos S.L.)
C/ Miguel Astrain 18, 1º Oficina A
31006 Pamplona, Navarra.
ignacio@acysos.com
Tel. 948238905
---------------------- // -------------------
La información contenida en este mensaje de correo electrónico es
confidencial, para ser leída por la(s) persona(s) a quién se dirige. El
acceso a este mensaje por otras personas no está autorizado. Si Ud. no es la
persona a la que va dirigido, cualquier divulgación, copia o distribución de
la información queda prohibida y puede ser ilegal. Asimismo, cualquier acción
tomada o dejada de tomar basada en la información contenida en este mensaje
queda prohibida y puede ser ilegal.
The information in this e-mail is confidential and may be legally privileged.
It is intended solely for the addressee. Access to this e-mail by anyone is
unauthorised. If you are not the intended recipient, any disclousure,
copying, distribuition or any action taken or omited to be taken in reliance
on it, is prohibited and may be unlawful.
by Ignacio Ibeas - 05:50 - 14 Jul 2022
Re: Proposing myself as l10n-spain PSC
Hello,

Yes, I'm agree. He is great contributor.

Greetings

El 13/7/22 a las 16:46, Enric Tobella Alomar escribió:

I added you as member of the PSC team. GitHub invite should follow in the next 24h.

Best regards

Enric Tobella Alomar

Av. J. V. Foix 63

08034 Barcelona

Tlf. 932 522 522 (Ext. 9611)

creublanca.es

From: "cubells" <notifications@odoo-community.org>
To: "Contributors" <contributors@odoo-community.org>
Date: Wed, 13 Jul 2022 07:02:10 -0000
Subject: Proposing myself as l10n-spain PSC

Hi all, I would like to apply as PSC for https://github.com/OCA/l10n-spain Main reason is the big development we are doing from last year to cover Basque Country requirements (Fiscal Ticketbai and Batuz project). This task is not fully finished and we need a big push in next weeks. Also in next months we have a team working in localization for Canary Islands, with also specific fiscal rules. And in near future we expect to have important changes in rest of spanish fiscal rules. I have contributed in this repository for last years and I have a developer and functional profile. My github account is https://github.com/cubells Thanks for considering my request and regards. Vicent Cubells Trey, kilobytes de soluciones -- Atentament, cubells. --

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Tanto este mensaje como los documentos que, en su caso, lleve como anexos,
pueden contener información reservada y/o confidencial, destinada exclusivamente
para el uso del destinatario o la persona responsable de entregarlo al mismo,
estando su uso no autorizado prohibido legalmente.
Su contenido no constituye un compromiso para Creu Blanca (la empresa remitente)
salvo ratificación escrita por ambas partes. En caso de su recepción por error,
rogamos nos lo comunique por igual vía, se abstenga de realizar copias del mensaje
o documentos adjuntos, remitirlo o facilitarlo a un tercero, y proceda en su defecto,
a su eliminación.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--
Ignacio Ibeas
Acysos S.L. (www.acysos.com)
Odoo Partner (https://www.odoo.com/es_ES/partners/acysos-s-l-80090)
Asociado Asociación Española de Odoo (https://www.aeodoo.org/members/acysos-s-l-24)
Odoo Community Association (https://odoo-community.org/members/acysos-s-l-ignacio-ibeas-760)
Github (http://www.github.com/acysos)
Odoo Apps (https://www.odoo.com/apps/modules/browse?author=Acysos S.L.)
C/ Miguel Astrain 18, 1º Oficina A
31006 Pamplona, Navarra.
ignacio@acysos.com
Tel. 948238905
---------------------- // -------------------
La información contenida en este mensaje de correo electrónico es
confidencial, para ser leída por la(s) persona(s) a quién se dirige. El
acceso a este mensaje por otras personas no está autorizado. Si Ud. no es la
persona a la que va dirigido, cualquier divulgación, copia o distribución de
la información queda prohibida y puede ser ilegal. Asimismo, cualquier acción
tomada o dejada de tomar basada en la información contenida en este mensaje
queda prohibida y puede ser ilegal.
The information in this e-mail is confidential and may be legally privileged.
It is intended solely for the addressee. Access to this e-mail by anyone is
unauthorised. If you are not the intended recipient, any disclousure,
copying, distribuition or any action taken or omited to be taken in reliance
on it, is prohibited and may be unlawful.
by Ignacio Ibeas - 05:36 - 14 Jul 2022

Re: Proposing myself as l10n-spain PSC

Great Vicent, thanks for your help.

And congratulations for your approval.

-----------------------------------------------------------

Josean Soroa

LANDOO SL - www.landoo.es

-----------------------------------------------------------

El mié, 13 jul 2022 a las 9:02, cubells (<notifications@odoo-community.org>) escribió:

Hi all,

I would like to apply as PSC for https://github.com/OCA/l10n-spain

Main reason is the big development we are doing from last year to cover
Basque Country requirements (Fiscal Ticketbai and Batuz project).
This task is not fully finished and we need a big push in next weeks.
Also in next months we have a team working in localization for Canary
Islands, with also specific fiscal rules.
And in near future we expect to have important changes in rest of
spanish fiscal rules.

I have contributed in this repository for last years and I have a
developer and functional profile.


My github account is https://github.com/cubells

Thanks for considering my request and regards.

Vicent Cubells
Trey, kilobytes de soluciones




-- 
Atentament, cubells.
--

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by Josean Soroa - 12:51 - 14 Jul 2022

RE: Proposing myself as l10n-spain PSC
Great news!!! 😊

Thanks Vicent!

De: Enric Tobella Alomar <notifications@odoo-community.org>
Enviado el: miércoles, 13 de julio de 2022 16:47
Para: Contributors <contributors@odoo-community.org>
Asunto: Re: Proposing myself as l10n-spain PSC

I added you as member of the PSC team. GitHub invite should follow in the next 24h.

Best regards

Enric Tobella Alomar
Av. J. V. Foix 63
08034 Barcelona
Tlf. 932 522 522 (Ext. 9611)
creublanca.es

From: "cubells" <notifications@odoo-community.org>
To: "Contributors" <contributors@odoo-community.org>
Date: Wed, 13 Jul 2022 07:02:10 -0000
Subject: Proposing myself as l10n-spain PSC

Hi all,

I would like to apply as PSC for https://github.com/OCA/l10n-spain

Main reason is the big development we are doing from last year to cover
Basque Country requirements (Fiscal Ticketbai and Batuz project).
This task is not fully finished and we need a big push in next weeks.
Also in next months we have a team working in localization for Canary
Islands, with also specific fiscal rules.
And in near future we expect to have important changes in rest of
spanish fiscal rules.

I have contributed in this repository for last years and I have a
developer and functional profile.

My github account is https://github.com/cubells

Thanks for considering my request and regards.

Vicent Cubells
Trey, kilobytes de soluciones

--
Atentament, cubells.
--
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Tanto este mensaje como los documentos que, en su caso, lleve como anexos,
pueden contener información reservada y/o confidencial, destinada exclusivamente
para el uso del destinatario o la persona responsable de entregarlo al mismo,
estando su uso no autorizado prohibido legalmente.
Su contenido no constituye un compromiso para Creu Blanca (la empresa remitente)
salvo ratificación escrita por ambas partes. En caso de su recepción por error,
rogamos nos lo comunique por igual vía, se abstenga de realizar copias del mensaje
o documentos adjuntos, remitirlo o facilitarlo a un tercero, y proceda en su defecto,
a su eliminación.
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Rafael Blasco (Moduon) - 11:50 - 14 Jul 2022
Re: Proposing myself as l10n-spain PSC
I added you as member of the PSC team. GitHub invite should follow in the next 24h.

Best regards

Enric Tobella Alomar

Av. J. V. Foix 63

08034 Barcelona

Tlf. 932 522 522 (Ext. 9611)

creublanca.es

From: "cubells" <notifications@odoo-community.org>
To: "Contributors" <contributors@odoo-community.org>
Date: Wed, 13 Jul 2022 07:02:10 -0000
Subject: Proposing myself as l10n-spain PSC

Hi all, I would like to apply as PSC for https://github.com/OCA/l10n-spain Main reason is the big development we are doing from last year to cover Basque Country requirements (Fiscal Ticketbai and Batuz project). This task is not fully finished and we need a big push in next weeks. Also in next months we have a team working in localization for Canary Islands, with also specific fiscal rules. And in near future we expect to have important changes in rest of spanish fiscal rules. I have contributed in this repository for last years and I have a developer and functional profile. My github account is https://github.com/cubells Thanks for considering my request and regards. Vicent Cubells Trey, kilobytes de soluciones -- Atentament, cubells. --

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Tanto este mensaje como los documentos que, en su caso, lleve como anexos,
pueden contener información reservada y/o confidencial, destinada exclusivamente
para el uso del destinatario o la persona responsable de entregarlo al mismo,
estando su uso no autorizado prohibido legalmente.
Su contenido no constituye un compromiso para Creu Blanca (la empresa remitente)
salvo ratificación escrita por ambas partes. En caso de su recepción por error,
rogamos nos lo comunique por igual vía, se abstenga de realizar copias del mensaje
o documentos adjuntos, remitirlo o facilitarlo a un tercero, y proceda en su defecto,
a su eliminación.
by Enric Tobella Alomar - 04:46 - 13 Jul 2022

1 attachments 1 attachments

CB 70anys Gris _ CB+ Color H RGB.png

prior price before promotion

Hi all,

Does anyone have worked on the subject of a "base price" or "prior price" ?

There is a EU Directive 2019/2161 about for it:

> 2. The prior price means the lowest price applied by the trader during a period of time not shorter than 30 days prior to the application of the price reduction.

https://eur-lex.europa.eu/legal-content/EN/ALL/?uri=CELEX:32019L2161#d1e776-7-1

Regards,

--

Raphaël Reverdy

Mobile +33 6 38 02 03 93

Fixe +33 4 82 53 84 60

by Raphaël Reverdy - 11:15 - 11 Jul 2022

1 replies 1 replies

Re: prior price before promotion

Hi Raphael,

at least i haven't heard anything in that direction. But the folks 
working in grocery retail should know.

Best Frederik

Am 11.07.22 um 11:16 schrieb Raphaël Reverdy:

> Hi all,

> Does anyone have worked on the subject of a "base price" or "prior price" ?

> There is a EU Directive 2019/2161 about for it:

>> 2.   The prior price

> means the lowest price applied by the trader during a period of time not

> shorter than 30 days prior to the application of the price reduction.

> https://eur-lex.europa.eu/legal-content/EN/ALL/?uri=CELEX:32019L2161#d1e776-7-1 [1]

> Regards,

>

> --

> Raphaël Reverdy

> Mobile +33 6 38 02 03 93

> Fixe +33 4 82 53 84 60

> _______________________________________________

> Mailing-List: https://odoo-community.org/groups/contributors-15 [2]

> Post to: mailto:contributors@odoo-community.org

> Unsubscribe: https://odoo-community.org/groups?unsubscribe [3]

>

>

>

> [1] https://eur-lex.europa.eu/legal-content/EN/ALL/?uri=CELEX:32019L2161#d1e776-7-1

> [2] https://odoo-community.org/groups/contributors-15

> [3] https://odoo-community.org/groups?unsubscribe

>

-- 
Dr.-Ing. Frederik Kramer
Geschäftsführer

initOS GmbH
Innungsstraße 7
21244 Buchholz i.d.N.

Phone:  +49 4181 13503-12
Fax:    +49 4181 13503-10
Mobil:  +49 179 3901819

Email: frederik.kramer@initos.com
Web:   www.initos.com

Geschäftsführung:
Dr.-Ing. Frederik Kramer & Dipl.-Ing. (FH) Torsten Francke

Sitz der Gesellschaft: Buchholz i.d.N.
Amtsgericht Tostedt, HRB 205226
Steuer-Nr: 15/200/53247
USt-IdNr.: DE815580155

by Frederik Kramer. - 11:46 - 11 Jul 2022

Tax and account mapping depending of the product/category

Hi all I have created a discussion on github here (maybe easier to discuss and to keep an history)

https://github.com/OCA/account-fiscal-rule/discussions/298

I copy/paste the description of the discussion

Issue

When selling in Europe (or only in France but with some special dom-tom case), you need to apply local tax when reaching a certain amount. And sometime you need to map the tax (and also the account) depending of the product.

For example you sell products A and B with the tax 20% in France
But you need to sell it with a tax 13% for product A and 16% for product B in some fiscal position.

Right now it's impossible to do it

Solution

I would like to introduce a new module account_fiscal_product_rule

That will have the following data models


class AccountFiscalPositionProductRule():

    name = fields.Char()
    fiscal_position_id = fields.Many2one("account.fiscal.position")
    product_tmpl_ids = fields.Many2many("product.template")
    category_ids = fields.Many2many("product.category")
    account_income_id = fields.Many2one("account.account")
    account_expense_id = fields.Many2one("account.account")
    seller_tax_ids = fields.Many2Many("account.tax")
    supplier_tax_ids = fields.Many2Many("account.tax")


class ProductCategory():

    fiscal_position_product_rule_ids = fields.Many2many("account.fiscal.position.product.rule")


class ProductTemplate():

    fiscal_position_product_rule_ids = fields.Many2many("account.fiscal.position.product.rule")

Then we can inherit the mapping logic (tax and account) to apply first this "specific rule" and if not rule match apply native rules

Describe alternatives you've considered

I had thinking about adding product_ids and category_ids on "account.fiscal.position.account" and "account.fiscal.position.tax". But the UI not really good for end user (too much configuration), and code will be not so easy to inherit.

Thanks for your feedback (please put it in github)

by Sébastien Beau - 09:45 - 11 Jul 2022

6 replies 6 replies

RE: Tax and account mapping depending of the product/category

Hi,

Can this not been tackled with fiscal position ? In Belgium we have 4 TVA regimes when building product are installed : 21 % ( normal ), TVA compensated ( for companies ), 6 % ( private customers with houses older than 10 years ) and 12 % ( social housing ). So we create 4 fiscal positions and choose the right one on sales order. You could use a same approach. I guess the TVA rates are at least for groups of products. Because when you have 200.000 products ( and that’s not that much ) it become unmaintainable when you have to apply a different TVA to every product…

With kind regards,

Van Hirtum Johan

Van: Sebastien Beau [mailto:notifications@odoo-community.org]
Verzonden: maandag 11 juli 2022 23:02
Aan: Contributors
Onderwerp: Re: Tax and account mapping depending of the product/category

Hi Thorsten

We already think about it, but the issue is that we do not have only one case, so at the end I fear that we end with something like
20% (standard rate france / special foreign tax 16% / other location foreign tax 18%)
With a big list of taxe that match all the possible combinations

Thanks for your feedback

Le lun. 11 juil. 2022 à 11:02, Thorsten Vocks <notifications@odoo-community.org> a écrit :
Hi,

as ugly workaround:

Wouldn't it be possible to duplicate the standard tax as you mentioned "20% (standard rate france)"
to "20% (standard rate france / special foreign tax 16%)" and ...

a.) assign this duplicated standard tax to the product (product "B" in your example)
b.) add this tax in the fiscal position on the tax mapping tab (20% -> 16% ) after the regular tax mapping of the fiscal position (20% -> 13%).

Best regards

Thorsten Vocks

openBIG.org
Dipl. Kaufmann (FH)
Porscheweg 4-6
49661 Cloppenburg

Phone: +49 4471 8409000
Fax: +49 4471 84090009
Mail: thorsten.vocks@openbig.org
Web: http://www.openbig.org

Am Mo., 11. Juli 2022 um 10:42 Uhr schrieb Sebastien Beau <notifications@odoo-community.org>:
Thanks Pedro for your feedback, but it's not the same issue.

This great module helps to easily configure the tax mapping (it generates all the fiscal position and tax mapping and save us a lot of time).

Here the case is more complexe sometime depending on the product you can not map a normal tax to a normal tax but sometime for legal reasons the tax in the dest country is a Reduce one or a Super Reduced Tax.

We need to handle this case

Le lun. 11 juil. 2022 à 09:56, Pedro M. Baeza (Tecnativa) <notifications@odoo-community.org> a écrit :
Isn't this OSS? https://github.com/OCA/account-fiscal-rule/tree/14.0/l10n_eu_oss
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by johan - 02:20 - 12 Jul 2022
Re: Tax and account mapping depending of the product/category

Hi Thorsten

We already think about it, but the issue is that we do not have only one case, so at the end I fear that we end with something like
20% (standard rate france / special foreign tax 16% / other location foreign tax 18%)
With a big list of taxe that match all the possible combinations

Thanks for your feedback

Le lun. 11 juil. 2022 à 11:02, Thorsten Vocks <notifications@odoo-community.org> a écrit :
Hi,

as ugly workaround:

Wouldn't it be possible to duplicate the standard tax as you mentioned "20% (standard rate france)"
to "20% (standard rate france / special foreign tax 16%)" and ...

a.) assign this duplicated standard tax to the product (product "B" in your example)
b.) add this tax in the fiscal position on the tax mapping tab (20% -> 16% ) after the regular tax mapping of the fiscal position (20% -> 13%).

Best regards

Thorsten Vocks

openBIG.org
Dipl. Kaufmann (FH)
Porscheweg 4-6
49661 Cloppenburg

Phone: +49 4471 8409000
Fax: +49 4471 84090009
Mail: thorsten.vocks@openbig.org
Web: http://www.openbig.org

Am Mo., 11. Juli 2022 um 10:42 Uhr schrieb Sebastien Beau <notifications@odoo-community.org>:
Thanks Pedro for your feedback, but it's not the same issue.

This great module helps to easily configure the tax mapping (it generates all the fiscal position and tax mapping and save us a lot of time).

Here the case is more complexe sometime depending on the product you can not map a normal tax to a normal tax but sometime for legal reasons the tax in the dest country is a Reduce one or a Super Reduced Tax.

We need to handle this case

Le lun. 11 juil. 2022 à 09:56, Pedro M. Baeza (Tecnativa) <notifications@odoo-community.org> a écrit :
Isn't this OSS? https://github.com/OCA/account-fiscal-rule/tree/14.0/l10n_eu_oss

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by Sébastien Beau - 11:01 - 11 Jul 2022
Re: Tax and account mapping depending of the product/category

Hi,

as ugly workaround:

Wouldn't it be possible to duplicate the standard tax as you mentioned "20% (standard rate france)"
to "20% (standard rate france / special foreign tax 16%)" and ...

a.) assign this duplicated standard tax to the product (product "B" in your example)
b.) add this tax in the fiscal position on the tax mapping tab (20% -> 16% ) after the regular tax mapping of the fiscal position (20% -> 13%).

Best regards

Thorsten Vocks

openBIG.org
Dipl. Kaufmann (FH)
Porscheweg 4-6
49661 Cloppenburg

Phone: +49 4471 8409000
Fax: +49 4471 84090009
Mail: thorsten.vocks@openbig.org
Web: http://www.openbig.org

Am Mo., 11. Juli 2022 um 10:42 Uhr schrieb Sebastien Beau <notifications@odoo-community.org>:
Thanks Pedro for your feedback, but it's not the same issue.

This great module helps to easily configure the tax mapping (it generates all the fiscal position and tax mapping and save us a lot of time).

Here the case is more complexe sometime depending on the product you can not map a normal tax to a normal tax but sometime for legal reasons the tax in the dest country is a Reduce one or a Super Reduced Tax.

We need to handle this case

Le lun. 11 juil. 2022 à 09:56, Pedro M. Baeza (Tecnativa) <notifications@odoo-community.org> a écrit :
Isn't this OSS? https://github.com/OCA/account-fiscal-rule/tree/14.0/l10n_eu_oss

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by Thorsten Vocks - 11:01 - 11 Jul 2022
Re: Tax and account mapping depending of the product/category

Thanks Pedro for your feedback, but it's not the same issue.

This great module helps to easily configure the tax mapping (it generates all the fiscal position and tax mapping and save us a lot of time).

Here the case is more complexe sometime depending on the product you can not map a normal tax to a normal tax but sometime for legal reasons the tax in the dest country is a Reduce one or a Super Reduced Tax.

We need to handle this case

Le lun. 11 juil. 2022 à 09:56, Pedro M. Baeza (Tecnativa) <notifications@odoo-community.org> a écrit :
Isn't this OSS? https://github.com/OCA/account-fiscal-rule/tree/14.0/l10n_eu_oss

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by Sébastien Beau - 10:40 - 11 Jul 2022

Re: Tax and account mapping depending of the product/category

Not quite Pedro, OSS afaik is mapping based on the country of the actual 
delivery (plus some edge cases).

Best Frederik

Am 11.07.22 um 09:56 schrieb Pedro M. Baeza (Tecnativa):

> Isn't this OSS? https://github.com/OCA/account-fiscal-rule/tree/14.0/l10n_eu_oss [1]

> _______________________________________________

> Mailing-List: https://odoo-community.org/groups/contributors-15 [2]

> Post to: mailto:contributors@odoo-community.org

> Unsubscribe: https://odoo-community.org/groups?unsubscribe [3]

>

>

>

> [1] https://github.com/OCA/account-fiscal-rule/tree/14.0/l10n_eu_oss

> [2] https://odoo-community.org/groups/contributors-15

> [3] https://odoo-community.org/groups?unsubscribe

>

-- 
Dr.-Ing. Frederik Kramer
Geschäftsführer

initOS GmbH
Innungsstraße 7
21244 Buchholz i.d.N.

Phone:  +49 4181 13503-12
Fax:    +49 4181 13503-10
Mobil:  +49 179 3901819

Email: frederik.kramer@initos.com
Web:   www.initos.com

Geschäftsführung:
Dr.-Ing. Frederik Kramer & Dipl.-Ing. (FH) Torsten Francke

Sitz der Gesellschaft: Buchholz i.d.N.
Amtsgericht Tostedt, HRB 205226
Steuer-Nr: 15/200/53247
USt-IdNr.: DE815580155

by Frederik Kramer. - 10:40 - 11 Jul 2022

Review tags

Hi,

regarding the mass mailing happening here: https://github.com/OCA/timesheet/pull/473 I don't know if there's some way to avoid that from happening (but being not very github savvy I don't even know what's the purpose of the oca-contributors team).

On the other hand, I've seen many devs requesting reviews but not knowing who to ask; could it be an idea to create a team to be used for requesting reviews? Signup would be voluntary, of course, and those requests could be easily filtered in the inbox. What do you think?

Thanks,

--

Francesco Foresti

Sicurpharma Srl

by Francesco Foresti - 03:36 - 8 Jul 2022

OpenUpgrade Survey - closes Wednesday 6th July - you still have time to have your say..

Hello OCA Contributors,

I hope you are all doing well.

Just a quick reminder that our OpenUpgrade survey closes after Wednesday 6th July. Make sure you have your say.

To find out more details in case you missed it, please check out the blog.

Also, the planning is underway for OCA Days, please register now if you haven't so we know what sort of numbers to plan for.

We are taking talk proposals - if you have a presentation, tutorial, workshop, discussion topic to lead, module update etc, we would love to hear from you - just fill in this form.

As always, thanks for your input - this helps the community stay connected and dynamic.

Take care,

Rebecca

--

Rebecca Gellatly

General Secretary

Odoo Community Association

by Rebecca Gellatly - 02:06 - 6 Jul 2022

1 replies 1 replies

test mail

Somebody gets this message?

by Jairo Llopis - 05:30 - 1 Jul 2022

20 replies 20 replies

Re: test mail

+1

On Sat, Jul 2, 2022 at 9:17 PM Antonio M. Vigliotti (gmail) <notifications@odoo-community.org> wrote:

Yes

Antonio M. Vigliotti

Mobile (+39) 342.8740910

Il 01/07/22 18:22, Francesco Apruzzese ha scritto:

Il giorno ven 1 lug 2022 alle ore 18:17 Marco Beri <notifications@odoo-community.org> ha scritto:

PLEASE STOP TO ANSWER "YES"!

Ok Marco!

He got It.

Thank you.

On Fri, 1 Jul 2022, 18:11 Hannaske, Reiner (Intero Technologies), <notifications@odoo-community.org> wrote:

Yes

Reiner Hannaske
Account Manager

Tel.: +49 3831 44557-41
Mobil: +49 170 9216129
E-Mail: r.hannaske@intero-technolgies.de
Website: www.intero-technologies.de

Intero Technologies GmbH

Heinrich-Heine-Ring 76

18435 Stralsund

Weitere Standorte der Intero Technologies GmbH

Bessemerstraße 82

12103 Berlin

Heidenkampsweg 58

20097 Hamburg

Kleiststraße 23

65187 Wiesbaden

Geschäftsführer: Frank Löffler, Lars Lifson USt-Id: DE 251251697, AG Stralsund HRB 7076

Alle Informationen zum Datenschutz gem. Art. 13 finden Sie hier. Auf Wunsch senden wir Ihnen diese Informationen gerne auch per PDF oder in gedruckter Form zu.

Von: "Jairo Llopis" <notifications@odoo-community.org>
An: "Contributors" <contributors@odoo-community.org>
Gesendet: Freitag, 1. Juli 2022 17:30:30
Betreff: test mail

Somebody gets this message?

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--

Francesco Apruzzese

Profilo professionale: http://it.linkedin.com/in/francescoapruzzese

Il contenuto di questo messaggio elettronico è riservato e tutelato dal segreto professionale ed è rivolto esclusivamente al/ai destinatario/i identificato/i. Pertanto è proibito leggerlo, copiarlo, divulgarlo o utilizzarlo da parte di chiunque salvo il/i destinatario/i. Se non siete il destinatario, vi invitiamo a cancellare il messaggio ed eventuali allegati dandocene immediatamente comunicazione scritta a mezzo posta elettronica.
This e-mail and any attachments are confidential and may contain information intended for the addressee(s) only. Reading, copying, disclosure or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail.

Non stampare questa email se non strettamente necessario. Aiuta te ed aiuta l'ambiente.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by Simone Rubino - 09:16 - 4 Jul 2022

Re: test mail

Yes

Antonio M. Vigliotti

Mobile (+39) 342.8740910

Il 01/07/22 18:22, Francesco Apruzzese ha scritto:

Il giorno ven 1 lug 2022 alle ore 18:17 Marco Beri <notifications@odoo-community.org> ha scritto:

PLEASE STOP TO ANSWER "YES"!

Ok Marco!

He got It.

Thank you.

On Fri, 1 Jul 2022, 18:11 Hannaske, Reiner (Intero Technologies), <notifications@odoo-community.org> wrote:

Yes

Reiner Hannaske
Account Manager

Tel.: +49 3831 44557-41
Mobil: +49 170 9216129
E-Mail: r.hannaske@intero-technolgies.de
Website: www.intero-technologies.de

Intero Technologies GmbH

Heinrich-Heine-Ring 76

18435 Stralsund

Weitere Standorte der Intero Technologies GmbH

Bessemerstraße 82

12103 Berlin

Heidenkampsweg 58

20097 Hamburg

Kleiststraße 23

65187 Wiesbaden

Geschäftsführer: Frank Löffler, Lars Lifson USt-Id: DE 251251697, AG Stralsund HRB 7076

Alle Informationen zum Datenschutz gem. Art. 13 finden Sie hier. Auf Wunsch senden wir Ihnen diese Informationen gerne auch per PDF oder in gedruckter Form zu.

Von: "Jairo Llopis" <notifications@odoo-community.org>
An: "Contributors" <contributors@odoo-community.org>
Gesendet: Freitag, 1. Juli 2022 17:30:30
Betreff: test mail

Somebody gets this message?

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--

Francesco Apruzzese

Profilo professionale: http://it.linkedin.com/in/francescoapruzzese

Il contenuto di questo messaggio elettronico è riservato e tutelato dal segreto professionale ed è rivolto esclusivamente al/ai destinatario/i identificato/i. Pertanto è proibito leggerlo, copiarlo, divulgarlo o utilizzarlo da parte di chiunque salvo il/i destinatario/i. Se non siete il destinatario, vi invitiamo a cancellare il messaggio ed eventuali allegati dandocene immediatamente comunicazione scritta a mezzo posta elettronica.
This e-mail and any attachments are confidential and may contain information intended for the addressee(s) only. Reading, copying, disclosure or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail.

Non stampare questa email se non strettamente necessario. Aiuta te ed aiuta l'ambiente.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by Antonio M. Vigliotti - 09:15 - 2 Jul 2022

3 attachments 3 attachments

Re: test mail

Il giorno ven 1 lug 2022 alle ore 18:17 Marco Beri <notifications@odoo-community.org> ha scritto:

PLEASE STOP TO ANSWER "YES"!

Ok Marco!

He got It.

Thank you.

On Fri, 1 Jul 2022, 18:11 Hannaske, Reiner (Intero Technologies), <notifications@odoo-community.org> wrote:
Yes

Reiner Hannaske
Account Manager
Tel.: +49 3831 44557-41
Mobil: +49 170 9216129
E-Mail: r.hannaske@intero-technolgies.de
Website: www.intero-technologies.de

Intero Technologies GmbH
Heinrich-Heine-Ring 76
18435 Stralsund

Weitere Standorte der Intero Technologies GmbH
Bessemerstraße 82
12103 Berlin
Heidenkampsweg 58
20097 Hamburg
Kleiststraße 23
65187 Wiesbaden

Geschäftsführer: Frank Löffler, Lars Lifson USt-Id: DE 251251697, AG Stralsund HRB 7076

Alle Informationen zum Datenschutz gem. Art. 13 finden Sie hier. Auf Wunsch senden wir Ihnen diese Informationen gerne auch per PDF oder in gedruckter Form zu.

Von: "Jairo Llopis" <notifications@odoo-community.org>
An: "Contributors" <contributors@odoo-community.org>
Gesendet: Freitag, 1. Juli 2022 17:30:30
Betreff: test mail

Somebody gets this message?

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--

Francesco Apruzzese

Profilo professionale: http://it.linkedin.com/in/francescoapruzzese

Il contenuto di questo messaggio elettronico è riservato e tutelato dal segreto professionale ed è rivolto esclusivamente al/ai destinatario/i identificato/i. Pertanto è proibito leggerlo, copiarlo, divulgarlo o utilizzarlo da parte di chiunque salvo il/i destinatario/i. Se non siete il destinatario, vi invitiamo a cancellare il messaggio ed eventuali allegati dandocene immediatamente comunicazione scritta a mezzo posta elettronica.
This e-mail and any attachments are confidential and may contain information intended for the addressee(s) only. Reading, copying, disclosure or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail.

Non stampare questa email se non strettamente necessario. Aiuta te ed aiuta l'ambiente.

by Francesco Apruzzese - 06:20 - 1 Jul 2022

Re: test mail

PLEASE STOP TO ANSWER "YES"!

He got It.

Thank you.

On Fri, 1 Jul 2022, 18:11 Hannaske, Reiner (Intero Technologies), <notifications@odoo-community.org> wrote:

Yes

Reiner Hannaske
Account Manager
Tel.: +49 3831 44557-41
Mobil: +49 170 9216129
E-Mail: r.hannaske@intero-technolgies.de
Website: www.intero-technologies.de

Intero Technologies GmbH
Heinrich-Heine-Ring 76
18435 Stralsund

Weitere Standorte der Intero Technologies GmbH
Bessemerstraße 82
12103 Berlin
Heidenkampsweg 58
20097 Hamburg
Kleiststraße 23
65187 Wiesbaden

Geschäftsführer: Frank Löffler, Lars Lifson USt-Id: DE 251251697, AG Stralsund HRB 7076

Alle Informationen zum Datenschutz gem. Art. 13 finden Sie hier. Auf Wunsch senden wir Ihnen diese Informationen gerne auch per PDF oder in gedruckter Form zu.

Von: "Jairo Llopis" <notifications@odoo-community.org>
An: "Contributors" <contributors@odoo-community.org>
Gesendet: Freitag, 1. Juli 2022 17:30:30
Betreff: test mail

Somebody gets this message?

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by Marco Beri - 06:15 - 1 Jul 2022

Re: test mail

Yes

Reiner Hannaske
Account Manager

Tel.: +49 3831 44557-41
Mobil: +49 170 9216129
E-Mail: r.hannaske@intero-technolgies.de

Website: www.intero-technologies.de

Intero Technologies GmbH

Heinrich-Heine-Ring 76

18435 Stralsund

Weitere Standorte der Intero Technologies GmbH

Bessemerstraße 82

12103 Berlin

Heidenkampsweg 58

20097 Hamburg

Kleiststraße 23

65187 Wiesbaden

Geschäftsführer: Frank Löffler, Lars Lifson USt-Id: DE 251251697, AG Stralsund HRB 7076

Alle Informationen zum Datenschutz gem. Art. 13 finden Sie hier. Auf Wunsch senden wir Ihnen diese Informationen gerne auch per PDF oder in gedruckter Form zu.

Von: "Jairo Llopis" <notifications@odoo-community.org>
An: "Contributors" <contributors@odoo-community.org>
Gesendet: Freitag, 1. Juli 2022 17:30:30
Betreff: test mail

Somebody gets this message?

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by R. Hannaske - 06:11 - 1 Jul 2022

Tip: Always call `clean_action` when returning an `ir.actions.act_window`

Hi,

Simple tip after losing my afternoon on this:

If you add a python `action_open_view_xxx` code that returns an `ir.actions.act_window` dict, you should always use the built-in `clean_action` that will convert any `tree` to `list`, otherwise the list view will be missing from the web client.

Note that this fix is always done internally by the webclient.

from odoo.addons.web.controllers.main import clean_action

class ProjectProject(models.Model):
    _inherit = 'project.project'

    def action_open_all_tasks(self, view_domain=False, view_type=False):
        act = clean_action(self.env.ref("project.action_view_task").read()[0])
        return act

--
Yann PAPOUIN, Ingénieur R&D | DEC

by Yann Papouin - 04:55 - 30 Jun 2022

New repository oca/odoo-pre-commit-hooks and pylint-odoo deep refactoring

Currently, we are using pylint-odoo project as pre-commit hooks for other kind of files

Now, we are using pre-commit for new projects.

So we can remove all the checks unrelated with python from pylint-odoo

e.g. eslint (javascript lints), XML checks, PO (translations) checks and so on

Then they could be replaced in the pre-commit configuration file with the id of the related check

e.g. eslint see https://github.com/pre-commit/mirrors-eslint

There are other custom checks in pylint-odoo as unnecessary-utf8-coding-comment

But it is duplicated with the following hook id fix-encoding-pragma from:

- https://github.com/pre-commit/pre-commit-hooks/blob/main/pre_commit_hooks/fix_encoding_pragma.py

It even has the option to auto-fix it

Similar case for pylint-odoo check incoherent-interpreter-exec-perm:

- https://github.com/pre-commit/pre-commit-hooks/blob/main/pre_commit_hooks/check_executables_have_shebangs.py

Similar case for pylint-odoo check wrong-tabs-instead-of-spaces

- https://github.com/Lucas-C/pre-commit-hooks/blob/master/pre_commit_hooks/remove_tabs.py

They are duplicated from pylint-odoo and they are better since they have the option to auto-fix if you want.

But there are other kinds of custom checks in pylint-odoo unrelated with python files that could be good to create a new pre-commit-hook custom for Odoo modules

In order to check XMLs, PO, CSS, CSV, and so on in the context of Odoo modules.

Currently, pylint-odoo is overloaded trying to do checks for non-python code since the core is not supporting check non-python files

And pylint-odoo doesn't have the auto-fix option

e.g. for XML files:

- dangerous-filter-wo-user

- duplicate-xml-record-id

- deprecated-openerp-xml-node
- create-user-wo-reset-password
- duplicate-xml-fields
- redundant-modulename-xml
- deprecated-data-xml-node

e.g. for CSV files:

- duplicate-id-csv

e.g. for PO files (Maybe, If we look for if exists hooks related to PO files they could be already developed from another hook project, so use it instead):

- duplicate-po-message-definition

- po-msgstr-variables

So, IMHO in OCA we need to create a new project to push all these custom pre-commit hooks and add documentation of the useful projects replacing pylint-odoo checks.

The name proposal is oca/odoo-pre-commit-hooks similar to main hooks repository:

- https://github.com/pre-commit/pre-commit-hooks/tree/main/pre_commit_hooks

And we can (or not) enable the option to auto fix (we can even push checks without auto fix)

Check the following discussion about creating custom repository to detect and autofix:

- https://github.com/OCA/pylint-odoo/issues/375

Check the following discussion about deprecating duplicated checks if pre-commit supports:

- https://github.com/OCA/pylint-odoo/issues/267

Check the following plan to create a freeze branch in pylint-odoo with the current behavior in pro to create a new version with new focus and clean code, delete old unused checks, deprecate py2 and so on:

- https://github.com/OCA/pylint-odoo/issues/381

If you agree, Could you help us to create the repository in OCA, please?

--

Moisés López Calderón

Mobile: (+521) 477-752-22-30

Twitter: @moylop260

hangout: moylop260@vauxoo.com
http://www.vauxoo.com - Odoo Gold Partner

Twitter: @vauxoo

by Moisés López Calderón - 10:11 - 27 Jun 2022

8 replies 8 replies

Re: New repository oca/odoo-pre-commit-hooks and pylint-odoo deep refactoring

Hi Moises,

I just created the repo: https://github.com/OCA/odoo-pre-commit-hooks/

Best regards,

-sbi

On Mon, Jun 27, 2022 at 10:12 PM Moises Lopez <moylop260@vauxoo.com> wrote:
Currently, we are using pylint-odoo project as pre-commit hooks for other kind of files

Now, we are using pre-commit for new projects.

So we can remove all the checks unrelated with python from pylint-odoo
e.g. eslint (javascript lints), XML checks, PO (translations) checks and so on

Then they could be replaced in the pre-commit configuration file with the id of the related check

e.g. eslint see https://github.com/pre-commit/mirrors-eslint

There are other custom checks in pylint-odoo as unnecessary-utf8-coding-comment
But it is duplicated with the following hook id fix-encoding-pragma from:
- https://github.com/pre-commit/pre-commit-hooks/blob/main/pre_commit_hooks/fix_encoding_pragma.py

It even has the option to auto-fix it

Similar case for pylint-odoo check incoherent-interpreter-exec-perm:
- https://github.com/pre-commit/pre-commit-hooks/blob/main/pre_commit_hooks/check_executables_have_shebangs.py

Similar case for pylint-odoo check wrong-tabs-instead-of-spaces
- https://github.com/Lucas-C/pre-commit-hooks/blob/master/pre_commit_hooks/remove_tabs.py

They are duplicated from pylint-odoo and they are better since they have the option to auto-fix if you want.

But there are other kinds of custom checks in pylint-odoo unrelated with python files that could be good to create a new pre-commit-hook custom for Odoo modules

In order to check XMLs, PO, CSS, CSV, and so on in the context of Odoo modules.

Currently, pylint-odoo is overloaded trying to do checks for non-python code since the core is not supporting check non-python files
And pylint-odoo doesn't have the auto-fix option

e.g. for XML files:
- dangerous-filter-wo-user
- duplicate-xml-record-id
- deprecated-openerp-xml-node
- create-user-wo-reset-password
- duplicate-xml-fields
- redundant-modulename-xml
- deprecated-data-xml-node

e.g. for CSV files:
- duplicate-id-csv

e.g. for PO files (Maybe, If we look for if exists hooks related to PO files they could be already developed from another hook project, so use it instead):
- duplicate-po-message-definition
- po-msgstr-variables

So, IMHO in OCA we need to create a new project to push all these custom pre-commit hooks and add documentation of the useful projects replacing pylint-odoo checks.

The name proposal is oca/odoo-pre-commit-hooks similar to main hooks repository:
- https://github.com/pre-commit/pre-commit-hooks/tree/main/pre_commit_hooks

And we can (or not) enable the option to auto fix (we can even push checks without auto fix)

Check the following discussion about creating custom repository to detect and autofix:
- https://github.com/OCA/pylint-odoo/issues/375

Check the following discussion about deprecating duplicated checks if pre-commit supports:
- https://github.com/OCA/pylint-odoo/issues/267

Check the following plan to create a freeze branch in pylint-odoo with the current behavior in pro to create a new version with new focus and clean code, delete old unused checks, deprecate py2 and so on:
- https://github.com/OCA/pylint-odoo/issues/381

If you agree, Could you help us to create the repository in OCA, please?

--
Moisés López Calderón
Mobile: (+521) 477-752-22-30
Twitter: @moylop260
hangout: moylop260@vauxoo.com
http://www.vauxoo.com - Odoo Gold Partner
Twitter: @vauxoo

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by Stéphane Bidoul - 11:15 - 29 Jun 2022
Re: New repository oca/odoo-pre-commit-hooks and pylint-odoo deep refactoring

Hi Moises,

Sounds great to make pylint-odoo simpler!

I take the opportunity to mention the semgrep (https://semgrep.dev) project that I recently discovered and may be a simple solution to implement some checks.

I'll create the new repo soon.

> Question: how does this coordinate with the OCA repo template? Pre commit hooks are currently maintained there, right?

Once the new checkers/fixers are ready in the new repo(s), they will need to be referenced in the .pre-commit-config.yaml template in the addons repo template.

Best regards,

-sbi

On Tue, Jun 28, 2022 at 9:52 AM Daniel Reis <dreis@opensourceintegrators.com> wrote:
Thank you for taking care of this Moises.

Question: how does this coordinate with the OCA repo template? Pre commit hooks are currently maintained there, right?

--dr

No dia 28/06/2022, às 07:46, Mignon, Laurent <laurent.mignon@acsone.eu> escreveu:

Good Idea!

Regards.

On Tue, Jun 28, 2022 at 8:17 AM Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> wrote:
Yes, I agree.

Regards.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by Stéphane Bidoul - 12:41 - 28 Jun 2022
Re: New repository oca/odoo-pre-commit-hooks and pylint-odoo deep refactoring
I have done a big progress in this subject recently, and it's open sourced. Get it here: https://gitlab.com/moduon/devsecops/precommix

It's based on Nix, so you will never get another random failure. It's a definitive solution for problems such as:

https://github.com/OCA/oca-addons-repo-template/issues/133

https://github.com/OCA/oca-addons-repo-template/pull/143
Your pre-commit configurations will keep working forever.

Just go ahead and wire precommix with oca-addons-repo-template.

Apart from that, I agree on removing the non-python stuff from pylint-odoo.
by Jairo Llopis - 11:16 - 28 Jun 2022
Re: New repository oca/odoo-pre-commit-hooks and pylint-odoo deep refactoring

Great ! +1

On Mon, Jun 27, 2022 at 10:12 PM Moises Lopez <moylop260@vauxoo.com> wrote:
Currently, we are using pylint-odoo project as pre-commit hooks for other kind of files

Now, we are using pre-commit for new projects.

So we can remove all the checks unrelated with python from pylint-odoo
e.g. eslint (javascript lints), XML checks, PO (translations) checks and so on

Then they could be replaced in the pre-commit configuration file with the id of the related check

e.g. eslint see https://github.com/pre-commit/mirrors-eslint

There are other custom checks in pylint-odoo as unnecessary-utf8-coding-comment
But it is duplicated with the following hook id fix-encoding-pragma from:
- https://github.com/pre-commit/pre-commit-hooks/blob/main/pre_commit_hooks/fix_encoding_pragma.py

It even has the option to auto-fix it

Similar case for pylint-odoo check incoherent-interpreter-exec-perm:
- https://github.com/pre-commit/pre-commit-hooks/blob/main/pre_commit_hooks/check_executables_have_shebangs.py

Similar case for pylint-odoo check wrong-tabs-instead-of-spaces
- https://github.com/Lucas-C/pre-commit-hooks/blob/master/pre_commit_hooks/remove_tabs.py

They are duplicated from pylint-odoo and they are better since they have the option to auto-fix if you want.

But there are other kinds of custom checks in pylint-odoo unrelated with python files that could be good to create a new pre-commit-hook custom for Odoo modules

In order to check XMLs, PO, CSS, CSV, and so on in the context of Odoo modules.

Currently, pylint-odoo is overloaded trying to do checks for non-python code since the core is not supporting check non-python files
And pylint-odoo doesn't have the auto-fix option

e.g. for XML files:
- dangerous-filter-wo-user
- duplicate-xml-record-id
- deprecated-openerp-xml-node
- create-user-wo-reset-password
- duplicate-xml-fields
- redundant-modulename-xml
- deprecated-data-xml-node

e.g. for CSV files:
- duplicate-id-csv

e.g. for PO files (Maybe, If we look for if exists hooks related to PO files they could be already developed from another hook project, so use it instead):
- duplicate-po-message-definition
- po-msgstr-variables

So, IMHO in OCA we need to create a new project to push all these custom pre-commit hooks and add documentation of the useful projects replacing pylint-odoo checks.

The name proposal is oca/odoo-pre-commit-hooks similar to main hooks repository:
- https://github.com/pre-commit/pre-commit-hooks/tree/main/pre_commit_hooks

And we can (or not) enable the option to auto fix (we can even push checks without auto fix)

Check the following discussion about creating custom repository to detect and autofix:
- https://github.com/OCA/pylint-odoo/issues/375

Check the following discussion about deprecating duplicated checks if pre-commit supports:
- https://github.com/OCA/pylint-odoo/issues/267

Check the following plan to create a freeze branch in pylint-odoo with the current behavior in pro to create a new version with new focus and clean code, delete old unused checks, deprecate py2 and so on:
- https://github.com/OCA/pylint-odoo/issues/381

If you agree, Could you help us to create the repository in OCA, please?

--
Moisés López Calderón
Mobile: (+521) 477-752-22-30
Twitter: @moylop260
hangout: moylop260@vauxoo.com
http://www.vauxoo.com - Odoo Gold Partner
Twitter: @vauxoo

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--

Denis Roussel
Software Engineer
T : +32 2 888 31 49
M : +32 472 22 00 57

Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium
Zone industrielle 22 | L-8287 Kehlen | Luxembourg

by Denis Roussel. - 10:51 - 28 Jun 2022
Re: New repository oca/odoo-pre-commit-hooks and pylint-odoo deep refactoring

Thank you for taking care of this Moises.

Question: how does this coordinate with the OCA repo template? Pre commit hooks are currently maintained there, right?

--dr

No dia 28/06/2022, às 07:46, Mignon, Laurent <laurent.mignon@acsone.eu> escreveu:

Good Idea!

Regards.

On Tue, Jun 28, 2022 at 8:17 AM Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> wrote:
Yes, I agree.

Regards.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by Daniel Reis - 09:51 - 28 Jun 2022

Re: l10n-estonia status and proposing myself as PSC

What next steps do I need to take?

by "Alexey Pelykh" <alexey.pelykh@corphub.eu> - 09:25 - 23 Jun 2022

	www.coninpe.es 946 519 519	Pol. Ind. Torrelarragoiti Parcela 8A- Pab. 10 48170 Zamudio
Aviso legal: Este mensaje electrónico está dirigido únicamente a la(s) dirección(es) indicadas anteriormente; el carácter confidencial, personal e intransferible del mismo está protegido legalmente. Cualquier revelación, uso o reenvío no autorizado, completo o en parte, está prohibido. Si ha recibido este mensaje por equivocación, notifíquelo inmediatamente a la persona que lo ha enviado y borre el mensaje original junto con sus ficheros anexos sin leerlo ni grabarlo, total o parcialmente

Fund the OCA

The team

Archives

Contributors