Skip to Content
  2. Mailing Lists
  3. Contributors

Archives

  • New repo proposal: edi-framework
    Hi all,

    As mentioned during my talk at OCA days, I'd like to move the EDI framework to its own repo.
    Main reasons:

    1. OCA/edi is getting crowded
    2. clearly separate generic EDI modules from the framework itself

    Thoughts?
    Bests,
    S

    --
    Simone Orsi

    Full stack Python web developer, Odoo specialist, Odoo Community Board Member, in love with open source.
    by Simone Orsi. - 06:45 - 2 Mar 2023

    7 replies 7 replies

  • Proposal: add a forum
    Hello! I want to propose something I hope will help everybody communicate better :)

    Many of you might have notice that since long ago Github includes a discussions feature that can be enabled per repo.

    Since not-so-long ago, there's a possibility to enable discussions for a whole organization. The implementation is rather simple: just select one repo from the org that becomes the "main forum repo".

    Communicating through mailing lists looks very old-fashioned these days. 🧓 Every decent community has a decent forum, be it discourse or github discussions or whatever.

    IMHO the best solution would be:
    1. Create a new repo. We can call it "community" or "oca-forum" or "oca-discuss"... you name it
    2. PSC for this repo would be community moderators. Maybe a new PSC group?
    3. Set it as main discussion repo, organization-wide.
    4. Gradually deprecate the mailing list.
    Benefits of this approach:
    1. Look more modern.
    2. We can edit answers.
    3. We can put polls.
    4. We don't need to send mails with +1.
    5. We can link to comments.
    6. Community discussion more close to where the community actually works.
    7. Less things to maintain in odoo-community.org
    That doesn't mean we can't enable discussions for specific repos, to become more focused, just like it's done in OpenUpgrade. But at least we have a general place to talk asynchronously about general stuff, just like we have the Matrix/Discord community for synchronous communication.

    WDYT?
    by Jairo Llopis - 10:15 - 1 Mar 2023

    10 replies 10 replies

  • pre-commit will fail from today unless you update the templates
    Hi community!

    I just wanted to announce that I just released https://github.com/OCA/oca-addons-repo-template/releases/tag/v1.14.2

    If When you see pre-commit going nuts from today, please update the repo to the latest version of the template to fix it.

    Have a nice day!
    by Jairo Llopis - 10:06 - 1 Mar 2023

    3 replies 3 replies

  • Proposing myself as PSC for community-maintainers
    Hello everybody! I hope you're doing well.

    I'd like to become PSC in community-maintainers repos.

    This is my github profile, for those that don't know me: https://github.com/yajo

    I'm very active in packaging, solving pre-commit issues, and I maintain the copier template and copier itself. I have years of experience and community engagement.

    Thanks!
    by Jairo Llopis - 09:15 - 1 Mar 2023

    13 replies 13 replies

  • Payroll 15.0 PR review request

    Hello contributors

    My name is Ivan Candelas from Guadalajara Mexico. 
    I have almost 20 years of experience in ERP implementations, mainly in manufacturing, payroll and HR modules, I have been working with odoo for a few years as an implementer and freelance programmer.

    I look forward to actively contributing to the OCA modules. 
    Also I'd like to request a PR review https://github.com/OCA/payroll/pull/119 of the payroll module for the 15.0 branch

    Iván Candelas
    by Ivan Candelas - 05:15 - 27 Feb 2023
  • Module to bulk select products to Transfer
    Hello,

    I wonder if someone worked on a similar need:

    We are doing stock internal transfers, and would like to be able to select all the contents of the source location to the picking lines.
    A use case is where the Source Location is a Truck, and you want to unload (transfer) the content of the truck to another location.
    My target version is v16.


    Thank you
    Daniel
    by Daniel Reis - 10:50 - 23 Feb 2023

    2 replies 2 replies

  • Odoo calendar <-> outlook calendar sync 
    Hello,
We have a customer using native odoo synchronization between outlook calendar
and odoo calendar.

But since 2 month, the following warning has be added to the odoo documentation
<https://www.odoo.com/documentation/15.0/applications/general/calendars/outlook/outlook_calendar.html?highlight=outlook>
      Warning

      Odoo highly recommends testing the Outlook calendar synchronization
      on a test database and a test email address (that is not used for
      any other purpose) before attempting to sync the desired Outlook
      Calendar with the user’s production database.
      If the user has any past, present, or future events on their Odoo
      calendar before syncing their Outlook calendar, Outlook will treat
      the events pulled from Odoo’s calendar during the sync as new
      events, causing an email notification to be sent from Outlook to all
      the event attendees.
      To avoid unwanted emails being sent to all past, present, and future
      event attendees, the user must add the events from the Odoo calendar
      to the Outlook calendar before the first ever sync, delete the
      events from Odoo, and then start the sync.
      Even after synchronizing the Odoo Calendar with the Outlook
      calendar, Outlook will still send a notification to all event
      participants every time an event is edited (created, deleted,
      unarchived, or event date/time changed), with no exceptions. This is
      a limitation that cannot be fixed from Odoo’s side.
      After one user syncs their Outlook calendar to the Odoo database,
      unwanted email notifications are unavoidable because the first
      synchronized user’s events will be in the Odoo Calendar. If the Odoo
      database is shared amongst multiple users, and another user wants to
      sync their Outlook calendar with Odoo Calendar, Outlook will again
      pull the existing Odoo Calendar events during the sync and treat
      them as new events, causing Outlook to send email invitations to all
      event attendees.

      In summary, once a user synchronizes their Outlook calendar with the
      Odoo calendar:
          Creating an event in Odoo causes Outlook to send an invitation
          to all event attendees.
          Deleting an event in Odoo causes Outlook to send a cancellation
          to all event attendees.
          Unarchiving an event in Odoo causes Outlook to send an
          invitation to all event attendees.
          Archiving an event in Odoo causes Outlook to send a cancellation
          to all event attendees.
          Adding a contact to an event causes Outlook to send an
          invitation to all event attendees.
          Removing a contact from an event causes Outlook to send a
          cancellation to all event attendees.

And indeed, the synchronization has became unusable because of all the
invitations sent to all event attendees in outlook.

Odoo doesn't seem to address the problem, do you know any module that would work
properly to sync the calendars?

Regards
Simon


--
    by simon - 02:31 - 22 Feb 2023

    1 replies 1 replies

    • Re: Odoo calendar <-> outlook calendar sync 
      I think this issue was fixed last week in 
https://github.com/odoo/odoo/commit/86862f2527341247b75df155de16b09d44a7eee6

Alexandre

On 22/02/2023 14:32, Simon Pessemesse wrote:

> Hello,

> We have a customer using native odoo synchronization between outlook calendar

> and odoo calendar.

> 

> But since 2 month, the following warning has be added to the odoo documentation

> <https://www.odoo.com/documentation/15.0/applications/general/calendars/outlook/outlook_calendar.html?highlight=outlook>

>        Warning

> 

>        Odoo highly recommends testing the Outlook calendar synchronization

>        on a test database and a test email address (that is not used for

>        any other purpose) before attempting to sync the desired Outlook

>        Calendar with the user’s production database.

>        If the user has any past, present, or future events on their Odoo

>        calendar before syncing their Outlook calendar, Outlook will treat

>        the events pulled from Odoo’s calendar during the sync as new

>        events, causing an email notification to be sent from Outlook to all

>        the event attendees.

>        To avoid unwanted emails being sent to all past, present, and future

>        event attendees, the user must add the events from the Odoo calendar

>        to the Outlook calendar before the first ever sync, delete the

>        events from Odoo, and then start the sync.

>        Even after synchronizing the Odoo Calendar with the Outlook

>        calendar, Outlook will still send a notification to all event

>        participants every time an event is edited (created, deleted,

>        unarchived, or event date/time changed), with no exceptions. This is

>        a limitation that cannot be fixed from Odoo’s side.

>        After one user syncs their Outlook calendar to the Odoo database,

>        unwanted email notifications are unavoidable because the first

>        synchronized user’s events will be in the Odoo Calendar. If the Odoo

>        database is shared amongst multiple users, and another user wants to

>        sync their Outlook calendar with Odoo Calendar, Outlook will again

>        pull the existing Odoo Calendar events during the sync and treat

>        them as new events, causing Outlook to send email invitations to all

>        event attendees.

> 

>        In summary, once a user synchronizes their Outlook calendar with the

>        Odoo calendar:

>            Creating an event in Odoo causes Outlook to send an invitation

>            to all event attendees.

>            Deleting an event in Odoo causes Outlook to send a cancellation

>            to all event attendees.

>            Unarchiving an event in Odoo causes Outlook to send an

>            invitation to all event attendees.

>            Archiving an event in Odoo causes Outlook to send a cancellation

>            to all event attendees.

>            Adding a contact to an event causes Outlook to send an

>            invitation to all event attendees.

>            Removing a contact from an event causes Outlook to send a

>            cancellation to all event attendees.

> 

> And indeed, the synchronization has became unusable because of all the

> invitations sent to all event attendees in outlook.

> 

> Odoo doesn't seem to address the problem, do you know any module that would work

> properly to sync the calendars?

> 

> Regards

> Simon

> 

> -- 

> 

> _______________________________________________

> Mailing-List: https://odoo-community.org/groups/contributors-15 

> <https://odoo-community.org/groups/contributors-15>

> Post to: mailto:contributors@odoo-community.org

> Unsubscribe: https://odoo-community.org/groups?unsubscribe 

> <https://odoo-community.org/groups?unsubscribe>

> 


-- 
Alexandre Fayolle
Senior Software Engineer
Tel : +33 4 58 48 20 30

Camptocamp France SAS
18 rue du Lac Saint André
73 370 Le Bourget-du-Lac
France

http://www.camptocamp.com
      by Alexandre Fayolle - 02:40 - 22 Feb 2023
  • write access to repositories for oca-git-bot

    hello,

    maybe this is documented somewhere but i could not find the information.

    for the /ocabot rebase command to work, oca-git-bot needs write access to the repository that contains the branch. without it, it fails like this:

    The rebase process failed, because command git push --force coopiteasy tmp-pr-40:12.0-cooperator_website_add_validation_hook failed with output: 

    remote: Permission to coopiteasy/cooperative.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/coopiteasy/cooperative/': The requested URL returned error: 403

    how is this supposed to be handled? should oca-git-bot be part of our github organization? i invited it, thinking that maybe it auto-accepts invites, but nothing changed.

    what should i do?

    cheers,

    hugues
    coop it easy

    by hugues - 11:51 - 22 Feb 2023

    3 replies 3 replies

    • Re: write access to repositories for oca-git-bot
      I'm afraid it's not anything about checking that field or not, but GitHub avoids the push to organization branches. We don't know the reason, but there's nothing in our hands that we can do about that.

      But the good news is that the `/ocabot merge ...` command performs a rebase on the merge branch.

      Regards.
      by Pedro M. Baeza - 08:20 - 23 Feb 2023
    • Re: write access to repositories for oca-git-bot
      Yes the access is denied because the option o allow or not maintainers to push to PRs branch. 

      Anyways, the allow maintainers to push to the branch option is enabled by default and a lot of people leave it enabled, so the rebase command continue being useful for those cases. 

      Maybe a solution for this is to create a new command on the push level, like: 

      /ocabot merge patch —rebase 

      So the bot can rebase the PR when creating the merge branch so it don’t need access to PR repository. What do you think? 

      El El mié, 22 de feb. de 2023 a la(s) 08:06, Stéphane Bidoul <notifications@odoo-community.org> escribió:
      Hi Hugues,

      Last time I checked it was not possible for organizations to allow maintainers to push to their PRs. It was only possible for individual contributors.

      So this effectively limits the usefulness of the /ocabot rebase command.

      Best regards,

      -sbi


      On Wed, Feb 22, 2023 at 11:57 AM hugues de keyzer <notifications@odoo-community.org> wrote:

      hello,

      maybe this is documented somewhere but i could not find the information.

      for the /ocabot rebase command to work, oca-git-bot needs write access to the repository that contains the branch. without it, it fails like this:

      The rebase process failed, because command git push --force coopiteasy tmp-pr-40:12.0-cooperator_website_add_validation_hook failed with output: 

      remote: Permission to coopiteasy/cooperative.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/coopiteasy/cooperative/': The requested URL returned error: 403

      how is this supposed to be handled? should oca-git-bot be part of our github organization? i invited it, thinking that maybe it auto-accepts invites, but nothing changed.

      what should i do?

      cheers,

      hugues
      coop it easy

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by Nicolas Rodriguez Sande - 01:36 - 23 Feb 2023
    • Re: write access to repositories for oca-git-bot
      Hi Hugues,

      Last time I checked it was not possible for organizations to allow maintainers to push to their PRs. It was only possible for individual contributors.

      So this effectively limits the usefulness of the /ocabot rebase command.

      Best regards,

      -sbi


      On Wed, Feb 22, 2023 at 11:57 AM hugues de keyzer <notifications@odoo-community.org> wrote:

      hello,

      maybe this is documented somewhere but i could not find the information.

      for the /ocabot rebase command to work, oca-git-bot needs write access to the repository that contains the branch. without it, it fails like this:

      The rebase process failed, because command git push --force coopiteasy tmp-pr-40:12.0-cooperator_website_add_validation_hook failed with output: 

      remote: Permission to coopiteasy/cooperative.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/coopiteasy/cooperative/': The requested URL returned error: 403

      how is this supposed to be handled? should oca-git-bot be part of our github organization? i invited it, thinking that maybe it auto-accepts invites, but nothing changed.

      what should i do?

      cheers,

      hugues
      coop it easy

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by Stéphane Bidoul - 12:06 - 22 Feb 2023
  • As Odoo family, please donate for the disasters in Türkiye
    Dear Fabien, 

    Turkey has recently been struck by a devastating earthquake with a magnitude of 7.8. The impact has been widespread and many communities have been severely affected. In this difficult time, we are reaching out to ask for your support. Any donation, no matter how small, will help us provide much-needed aid to those affected by the earthquake. Your generosity will help provide shelter, food, and medical supplies to those in need. If you would like to make a donation, at the buttom we shared IBAN information for contribution. Your contribution will make a real difference in the lives of those affected by this disaster. 

    Thank you for your kindness and support.



    İsmail ESKİ
    Software Developer

    Projet Yazılım ve Danışmanlık A.Ş. 
    Tel: +90 850 520 00 18
    www.projetgrup.com

    by "İsmail Eski" <ismaile@projetgrup.com> - 06:06 - 10 Feb 2023

    2 replies 2 replies

  • OCA Contract Repository

    Hello, I’m writing to know your opinion about the contract repository. I started to use the modules in the repository and noted that the module versions of contract module differ a lot between odoo versions. 


    I have to do some implementations regarding that modules so I’m going to start making PRs to that repo and try to improve the modules starting in version 14.0 and then port it to the others. 

    I want to have your opinions on things you can tell me about what is missing in the modules and so I can organize my roadmap. Also, I don’t know if there are currently active PSC of the module, if not or you want me to join the team I will be interested, because I need to improve the modules and if that can help the development of the repo, count with me. 

    From what I saw, I see the following issues to solve, please if you know another issues or want to make an opinion of changes you would like to see in the module please comment me here: 

    - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.

    - I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering. 

    - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters. 

    - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module. 

    - Contract views are awful and need to be improved to favor user usability and comprehension of the module mechanics and uses. This is one of the first changes i want to introduce. 

    - Contract reports and portal views need to be improved. Currently the contract report is not so much developed. Also could be a good idea to allow to see agreements from portal contracts. 

    - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality. 

    If you have more opinions and things you want to see in a roadmap, please tell me here and i can maybe add it to my next PRs. Also if you have opinions of how the module should work will be great for when we refactor it. 

    Regards and i want for your thoughts. 
    by Nicolas Rodriguez Sande - 05:55 - 10 Feb 2023

    6 replies 6 replies

    • Re: OCA Contract Repository
      Hi,

      We have nearly completed an extensive contract project integrating contract/project/accounting/sale/purchase/schedules/field service. All in it is about 30k lines replacing 100k lines of prior custom code for a janitorial organisation.

      Random assortment of Notes.
      Supplier Contracts - used in order to communicate back to back service agreements for certain services on customer contracts. Suspensions, modifications etc. But in truth, we did that because we could.
      Contract Name - maybe an onchange, but some concerns with computing. The case here is that the name is an internal reference/common name used widely in online and offline conversation.
      Contract States - added, computed based on modifications.
      Margins - added in style of sale_margin module.
      Sale Commissions Management.
      Point in time revenue - can view contract (or list of contracts) value based on state at given date in future or past (contract has auto pricing so value can differ, also modifications)

      Portal Views - we completely rewrote in the style of sale order and added signatures.
      Modifications - Underrated, undeveloped feature IMO. We added extensively to record approvals, signatures and manage line and contract state. Different types of modifications trigger different actions/activities/communications.

      Contract Lines - distinction between regular recurring items (e.g. Window Cleaning) and As Required items (toilet paper, fridge clean out).

      Grouping and defaults is kind of provided if you use contract templates.

      I personally don't see the link between an agreement and contract. I never worked out why they are in the same repo. A contract IS an agreement, and while I accept that an agreement is not always a contract, in practice, in business it is.

      When evaluating this project, we tried first with agreement, but didn't do as needed. With contract states, a draft state is not yet sent, pending is awaiting signature, open, suspended, rejected, terminated all self explanatory. Really all else we did was add terms text to contracts and it largely covered the agreement parts off that were needed.

      Bits we need to tidy up, contract has a kind of all or nothing approach to line based vs contract based billing. In practice we find it is the lines that drive what is billed, start dates, stop dates and contracts that drive when it is billed. Also, there is no nice proration in the invoicing function. But it seems very accessible so we should have that written next week.

      There is a lot of work we can extract and share, and lots of things I haven't added here.

      On Sat, Feb 25, 2023 at 11:56 AM Nicolas Rodriguez Sande <notifications@odoo-community.org> wrote:
      I don't know any cases of "supplier"contracts either... The logic for me states that a supplier contract is managed by the supplier. I don't see benefit in making recurring supplier invoices since supplier invoices are loaded in the system in other workflows. At least from what I saw, I never saw "supplier contracts" in any system.

      On Fri, Feb 24, 2023 at 2:02 PM Raphaël Reverdy <notifications@odoo-community.org> wrote:
      Hi,

      Does anyone have a real use case with a supplier contract ?

      I have the feeling supporting this use case adds a lot of complexity on the contract module.


      Good idea to refactor / split this contract module.

      Regards,





      Le jeu. 23 févr. 2023 à 01:53, Nicolas Rodriguez Sande <notifications@odoo-community.org> a écrit :
      Hello! Thanks for your response Denis. I Just go back from vacation so I think next week I will start working on contract module.

      > In fact, the state is managed on line level, see https://github.com/OCA/contract/blob/14.0/contract/models/contract_line.py#L94

      Okay so, if state is managed in line level, will it make sense to make a computed contract level state that is based on line state? Because I think that for the user, they will expect contract to have a state, even some lines have different states we can make some logic to compute a state based on all lines states. Something like: 

      States: “active”, “canceled”, “closed” can be computed based on lines. “Active” can be the contract state when at least one line is active, “Canceled” when all lines are canceled and “closed” when all lines closed. If we have mixed situations like some lines canceled and some active, we can still show active. 

      This will allow the user to easily filter contracts without having to enter each contract to see lines. Or maybe we have to make a contract lines view. 

      Next week I will be with this project and open some PRs to see what people think, also make the view improvements that will make sure life easier. 

      And yes, base_conteact was just an idea but the point is to have more smaller and maintainable modules that plug-in functionalities, that’s always the easiest way to have a user-specific implementation without having a lot of functionalities that won’t be user by all users. Will try to open the issue next week to discuss this and also review the link between agreements and contracts PR. 

      Please if another people have more ideas/problems/suggestions to contract module, feel free to reply this thread. 

      Regards and good week for all of you! 



      El El mié, 15 de feb. de 2023 a la(s) 06:17, Roussel, Denis <notifications@odoo-community.org> escribió:
      > - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.


      >  I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering. 

      Indeed, this can be improved.

      > - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters. 

      Maybe adding a 'contract.category' model could be great (in another module ?). But, for the time being, this can be done through contract tags. See: https://github.com/OCA/contract/blob/14.0/contract/models/contract.py#L110

      > - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module. 

      This is still tested in a draft PR: https://github.com/OCA/contract/pull/649 You can review it and make suggestions.

      > - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality. 

      This module has indeed a big history, refactored on 12.0 version I think. Since, some improvements have been done (refactoring on recurrency computations by Pedro see: https://github.com/OCA/contract/pull/533/commits/cd086ddbb4a9b85ccfcac288e53fb93e716d9446)

      Indeed, I think it has now a very complex implementation that makes user understanding (and debugging) difficult.

      We could make an issue on the github repository to help gathering ideas and focus discussion there than on this mailing list. But I agree that we could split some logic in separate modules (with meaningful names - if we could avoid base_contract).

      I hope this answered your questions.


      Regards,


      On Fri, Feb 10, 2023 at 5:57 PM Nicolas Rodriguez Sande <notifications@odoo-community.org> wrote:

      Hello, I’m writing to know your opinion about the contract repository. I started to use the modules in the repository and noted that the module versions of contract module differ a lot between odoo versions. 


      I have to do some implementations regarding that modules so I’m going to start making PRs to that repo and try to improve the modules starting in version 14.0 and then port it to the others. 

      I want to have your opinions on things you can tell me about what is missing in the modules and so I can organize my roadmap. Also, I don’t know if there are currently active PSC of the module, if not or you want me to join the team I will be interested, because I need to improve the modules and if that can help the development of the repo, count with me. 

      From what I saw, I see the following issues to solve, please if you know another issues or want to make an opinion of changes you would like to see in the module please comment me here: 

      - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.

      - I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering. 

      - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters. 

      - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module. 

      - Contract views are awful and need to be improved to favor user usability and comprehension of the module mechanics and uses. This is one of the first changes i want to introduce. 

      - Contract reports and portal views need to be improved. Currently the contract report is not so much developed. Also could be a good idea to allow to see agreements from portal contracts. 

      - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality. 

      If you have more opinions and things you want to see in a roadmap, please tell me here and i can maybe add it to my next PRs. Also if you have opinions of how the module should work will be great for when we refactor it. 

      Regards and i want for your thoughts. 

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe



      --

      Denis Roussel
      Software Engineer
      T    : +32 2 888 31 49
      M : +32 472 22 00 57


      Zone industrielle 22 | L-8287 Kehlen | Luxembourg

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe



      --
      Raphaël Reverdy
      Mobile +33 6 38 02 03 93
      Fixe +33 4 82 53 84 60

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by Graeme Gellatly - 08:11 - 25 Feb 2023
    • Re: OCA Contract Repository
      I don't know any cases of "supplier"contracts either... The logic for me states that a supplier contract is managed by the supplier. I don't see benefit in making recurring supplier invoices since supplier invoices are loaded in the system in other workflows. At least from what I saw, I never saw "supplier contracts" in any system.

      On Fri, Feb 24, 2023 at 2:02 PM Raphaël Reverdy <notifications@odoo-community.org> wrote:
      Hi,

      Does anyone have a real use case with a supplier contract ?

      I have the feeling supporting this use case adds a lot of complexity on the contract module.


      Good idea to refactor / split this contract module.

      Regards,





      Le jeu. 23 févr. 2023 à 01:53, Nicolas Rodriguez Sande <notifications@odoo-community.org> a écrit :
      Hello! Thanks for your response Denis. I Just go back from vacation so I think next week I will start working on contract module.

      > In fact, the state is managed on line level, see https://github.com/OCA/contract/blob/14.0/contract/models/contract_line.py#L94

      Okay so, if state is managed in line level, will it make sense to make a computed contract level state that is based on line state? Because I think that for the user, they will expect contract to have a state, even some lines have different states we can make some logic to compute a state based on all lines states. Something like: 

      States: “active”, “canceled”, “closed” can be computed based on lines. “Active” can be the contract state when at least one line is active, “Canceled” when all lines are canceled and “closed” when all lines closed. If we have mixed situations like some lines canceled and some active, we can still show active. 

      This will allow the user to easily filter contracts without having to enter each contract to see lines. Or maybe we have to make a contract lines view. 

      Next week I will be with this project and open some PRs to see what people think, also make the view improvements that will make sure life easier. 

      And yes, base_conteact was just an idea but the point is to have more smaller and maintainable modules that plug-in functionalities, that’s always the easiest way to have a user-specific implementation without having a lot of functionalities that won’t be user by all users. Will try to open the issue next week to discuss this and also review the link between agreements and contracts PR. 

      Please if another people have more ideas/problems/suggestions to contract module, feel free to reply this thread. 

      Regards and good week for all of you! 



      El El mié, 15 de feb. de 2023 a la(s) 06:17, Roussel, Denis <notifications@odoo-community.org> escribió:
      > - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.


      >  I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering. 

      Indeed, this can be improved.

      > - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters. 

      Maybe adding a 'contract.category' model could be great (in another module ?). But, for the time being, this can be done through contract tags. See: https://github.com/OCA/contract/blob/14.0/contract/models/contract.py#L110

      > - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module. 

      This is still tested in a draft PR: https://github.com/OCA/contract/pull/649 You can review it and make suggestions.

      > - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality. 

      This module has indeed a big history, refactored on 12.0 version I think. Since, some improvements have been done (refactoring on recurrency computations by Pedro see: https://github.com/OCA/contract/pull/533/commits/cd086ddbb4a9b85ccfcac288e53fb93e716d9446)

      Indeed, I think it has now a very complex implementation that makes user understanding (and debugging) difficult.

      We could make an issue on the github repository to help gathering ideas and focus discussion there than on this mailing list. But I agree that we could split some logic in separate modules (with meaningful names - if we could avoid base_contract).

      I hope this answered your questions.


      Regards,


      On Fri, Feb 10, 2023 at 5:57 PM Nicolas Rodriguez Sande <notifications@odoo-community.org> wrote:

      Hello, I’m writing to know your opinion about the contract repository. I started to use the modules in the repository and noted that the module versions of contract module differ a lot between odoo versions. 


      I have to do some implementations regarding that modules so I’m going to start making PRs to that repo and try to improve the modules starting in version 14.0 and then port it to the others. 

      I want to have your opinions on things you can tell me about what is missing in the modules and so I can organize my roadmap. Also, I don’t know if there are currently active PSC of the module, if not or you want me to join the team I will be interested, because I need to improve the modules and if that can help the development of the repo, count with me. 

      From what I saw, I see the following issues to solve, please if you know another issues or want to make an opinion of changes you would like to see in the module please comment me here: 

      - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.

      - I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering. 

      - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters. 

      - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module. 

      - Contract views are awful and need to be improved to favor user usability and comprehension of the module mechanics and uses. This is one of the first changes i want to introduce. 

      - Contract reports and portal views need to be improved. Currently the contract report is not so much developed. Also could be a good idea to allow to see agreements from portal contracts. 

      - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality. 

      If you have more opinions and things you want to see in a roadmap, please tell me here and i can maybe add it to my next PRs. Also if you have opinions of how the module should work will be great for when we refactor it. 

      Regards and i want for your thoughts. 

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe



      --

      Denis Roussel
      Software Engineer
      T    : +32 2 888 31 49
      M : +32 472 22 00 57


      Zone industrielle 22 | L-8287 Kehlen | Luxembourg

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe



      --
      Raphaël Reverdy
      Mobile +33 6 38 02 03 93
      Fixe +33 4 82 53 84 60

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by Nicolas Rodriguez Sande - 11:56 - 24 Feb 2023
    • Re: OCA Contract Repository
      Hello Raphael, this is also used for Suppliers.

      You can use it for Suppliers  contracts that Bill you monthly, and help you know the expected expenses.

      But splitting complexity into a separate module sounds good ro me.

      A sexta, 24/02/2023, 17:02, Raphaël Reverdy <notifications@odoo-community.org> escreveu:
      Hi,

      Does anyone have a real use case with a supplier contract ?

      I have the feeling supporting this use case adds a lot of complexity on the contract module.


      Good idea to refactor / split this contract module.

      Regards,





      Le jeu. 23 févr. 2023 à 01:53, Nicolas Rodriguez Sande <notifications@odoo-community.org> a écrit :
      Hello! Thanks for your response Denis. I Just go back from vacation so I think next week I will start working on contract module.

      > In fact, the state is managed on line level, see https://github.com/OCA/contract/blob/14.0/contract/models/contract_line.py#L94

      Okay so, if state is managed in line level, will it make sense to make a computed contract level state that is based on line state? Because I think that for the user, they will expect contract to have a state, even some lines have different states we can make some logic to compute a state based on all lines states. Something like: 

      States: “active”, “canceled”, “closed” can be computed based on lines. “Active” can be the contract state when at least one line is active, “Canceled” when all lines are canceled and “closed” when all lines closed. If we have mixed situations like some lines canceled and some active, we can still show active. 

      This will allow the user to easily filter contracts without having to enter each contract to see lines. Or maybe we have to make a contract lines view. 

      Next week I will be with this project and open some PRs to see what people think, also make the view improvements that will make sure life easier. 

      And yes, base_conteact was just an idea but the point is to have more smaller and maintainable modules that plug-in functionalities, that’s always the easiest way to have a user-specific implementation without having a lot of functionalities that won’t be user by all users. Will try to open the issue next week to discuss this and also review the link between agreements and contracts PR. 

      Please if another people have more ideas/problems/suggestions to contract module, feel free to reply this thread. 

      Regards and good week for all of you! 



      El El mié, 15 de feb. de 2023 a la(s) 06:17, Roussel, Denis <notifications@odoo-community.org> escribió:
      > - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.


      >  I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering. 

      Indeed, this can be improved.

      > - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters. 

      Maybe adding a 'contract.category' model could be great (in another module ?). But, for the time being, this can be done through contract tags. See: https://github.com/OCA/contract/blob/14.0/contract/models/contract.py#L110

      > - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module. 

      This is still tested in a draft PR: https://github.com/OCA/contract/pull/649 You can review it and make suggestions.

      > - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality. 

      This module has indeed a big history, refactored on 12.0 version I think. Since, some improvements have been done (refactoring on recurrency computations by Pedro see: https://github.com/OCA/contract/pull/533/commits/cd086ddbb4a9b85ccfcac288e53fb93e716d9446)

      Indeed, I think it has now a very complex implementation that makes user understanding (and debugging) difficult.

      We could make an issue on the github repository to help gathering ideas and focus discussion there than on this mailing list. But I agree that we could split some logic in separate modules (with meaningful names - if we could avoid base_contract).

      I hope this answered your questions.


      Regards,


      On Fri, Feb 10, 2023 at 5:57 PM Nicolas Rodriguez Sande <notifications@odoo-community.org> wrote:

      Hello, I’m writing to know your opinion about the contract repository. I started to use the modules in the repository and noted that the module versions of contract module differ a lot between odoo versions. 


      I have to do some implementations regarding that modules so I’m going to start making PRs to that repo and try to improve the modules starting in version 14.0 and then port it to the others. 

      I want to have your opinions on things you can tell me about what is missing in the modules and so I can organize my roadmap. Also, I don’t know if there are currently active PSC of the module, if not or you want me to join the team I will be interested, because I need to improve the modules and if that can help the development of the repo, count with me. 

      From what I saw, I see the following issues to solve, please if you know another issues or want to make an opinion of changes you would like to see in the module please comment me here: 

      - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.

      - I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering. 

      - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters. 

      - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module. 

      - Contract views are awful and need to be improved to favor user usability and comprehension of the module mechanics and uses. This is one of the first changes i want to introduce. 

      - Contract reports and portal views need to be improved. Currently the contract report is not so much developed. Also could be a good idea to allow to see agreements from portal contracts. 

      - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality. 

      If you have more opinions and things you want to see in a roadmap, please tell me here and i can maybe add it to my next PRs. Also if you have opinions of how the module should work will be great for when we refactor it. 

      Regards and i want for your thoughts. 

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe



      --

      Denis Roussel
      Software Engineer
      T    : +32 2 888 31 49
      M : +32 472 22 00 57


      Zone industrielle 22 | L-8287 Kehlen | Luxembourg

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe



      --
      Raphaël Reverdy
      Mobile +33 6 38 02 03 93
      Fixe +33 4 82 53 84 60

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by Daniel Reis - 09:35 - 24 Feb 2023
    • Re: OCA Contract Repository
      Hi,

      Does anyone have a real use case with a supplier contract ?

      I have the feeling supporting this use case adds a lot of complexity on the contract module.


      Good idea to refactor / split this contract module.

      Regards,





      Le jeu. 23 févr. 2023 à 01:53, Nicolas Rodriguez Sande <notifications@odoo-community.org> a écrit :
      Hello! Thanks for your response Denis. I Just go back from vacation so I think next week I will start working on contract module.

      > In fact, the state is managed on line level, see https://github.com/OCA/contract/blob/14.0/contract/models/contract_line.py#L94

      Okay so, if state is managed in line level, will it make sense to make a computed contract level state that is based on line state? Because I think that for the user, they will expect contract to have a state, even some lines have different states we can make some logic to compute a state based on all lines states. Something like: 

      States: “active”, “canceled”, “closed” can be computed based on lines. “Active” can be the contract state when at least one line is active, “Canceled” when all lines are canceled and “closed” when all lines closed. If we have mixed situations like some lines canceled and some active, we can still show active. 

      This will allow the user to easily filter contracts without having to enter each contract to see lines. Or maybe we have to make a contract lines view. 

      Next week I will be with this project and open some PRs to see what people think, also make the view improvements that will make sure life easier. 

      And yes, base_conteact was just an idea but the point is to have more smaller and maintainable modules that plug-in functionalities, that’s always the easiest way to have a user-specific implementation without having a lot of functionalities that won’t be user by all users. Will try to open the issue next week to discuss this and also review the link between agreements and contracts PR. 

      Please if another people have more ideas/problems/suggestions to contract module, feel free to reply this thread. 

      Regards and good week for all of you! 



      El El mié, 15 de feb. de 2023 a la(s) 06:17, Roussel, Denis <notifications@odoo-community.org> escribió:
      > - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.


      >  I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering. 

      Indeed, this can be improved.

      > - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters. 

      Maybe adding a 'contract.category' model could be great (in another module ?). But, for the time being, this can be done through contract tags. See: https://github.com/OCA/contract/blob/14.0/contract/models/contract.py#L110

      > - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module. 

      This is still tested in a draft PR: https://github.com/OCA/contract/pull/649 You can review it and make suggestions.

      > - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality. 

      This module has indeed a big history, refactored on 12.0 version I think. Since, some improvements have been done (refactoring on recurrency computations by Pedro see: https://github.com/OCA/contract/pull/533/commits/cd086ddbb4a9b85ccfcac288e53fb93e716d9446)

      Indeed, I think it has now a very complex implementation that makes user understanding (and debugging) difficult.

      We could make an issue on the github repository to help gathering ideas and focus discussion there than on this mailing list. But I agree that we could split some logic in separate modules (with meaningful names - if we could avoid base_contract).

      I hope this answered your questions.


      Regards,


      On Fri, Feb 10, 2023 at 5:57 PM Nicolas Rodriguez Sande <notifications@odoo-community.org> wrote:

      Hello, I’m writing to know your opinion about the contract repository. I started to use the modules in the repository and noted that the module versions of contract module differ a lot between odoo versions. 


      I have to do some implementations regarding that modules so I’m going to start making PRs to that repo and try to improve the modules starting in version 14.0 and then port it to the others. 

      I want to have your opinions on things you can tell me about what is missing in the modules and so I can organize my roadmap. Also, I don’t know if there are currently active PSC of the module, if not or you want me to join the team I will be interested, because I need to improve the modules and if that can help the development of the repo, count with me. 

      From what I saw, I see the following issues to solve, please if you know another issues or want to make an opinion of changes you would like to see in the module please comment me here: 

      - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.

      - I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering. 

      - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters. 

      - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module. 

      - Contract views are awful and need to be improved to favor user usability and comprehension of the module mechanics and uses. This is one of the first changes i want to introduce. 

      - Contract reports and portal views need to be improved. Currently the contract report is not so much developed. Also could be a good idea to allow to see agreements from portal contracts. 

      - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality. 

      If you have more opinions and things you want to see in a roadmap, please tell me here and i can maybe add it to my next PRs. Also if you have opinions of how the module should work will be great for when we refactor it. 

      Regards and i want for your thoughts. 

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe



      --

      Denis Roussel
      Software Engineer
      T    : +32 2 888 31 49
      M : +32 472 22 00 57


      Zone industrielle 22 | L-8287 Kehlen | Luxembourg

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe



      --
      Raphaël Reverdy
      Mobile +33 6 38 02 03 93
      Fixe +33 4 82 53 84 60
      by Raphaël Reverdy - 06:01 - 24 Feb 2023
    • Re: OCA Contract Repository
      Hello! Thanks for your response Denis. I Just go back from vacation so I think next week I will start working on contract module.

      > In fact, the state is managed on line level, see https://github.com/OCA/contract/blob/14.0/contract/models/contract_line.py#L94

      Okay so, if state is managed in line level, will it make sense to make a computed contract level state that is based on line state? Because I think that for the user, they will expect contract to have a state, even some lines have different states we can make some logic to compute a state based on all lines states. Something like: 

      States: “active”, “canceled”, “closed” can be computed based on lines. “Active” can be the contract state when at least one line is active, “Canceled” when all lines are canceled and “closed” when all lines closed. If we have mixed situations like some lines canceled and some active, we can still show active. 

      This will allow the user to easily filter contracts without having to enter each contract to see lines. Or maybe we have to make a contract lines view. 

      Next week I will be with this project and open some PRs to see what people think, also make the view improvements that will make sure life easier. 

      And yes, base_conteact was just an idea but the point is to have more smaller and maintainable modules that plug-in functionalities, that’s always the easiest way to have a user-specific implementation without having a lot of functionalities that won’t be user by all users. Will try to open the issue next week to discuss this and also review the link between agreements and contracts PR. 

      Please if another people have more ideas/problems/suggestions to contract module, feel free to reply this thread. 

      Regards and good week for all of you! 



      El El mié, 15 de feb. de 2023 a la(s) 06:17, Roussel, Denis <notifications@odoo-community.org> escribió:
      > - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.


      >  I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering. 

      Indeed, this can be improved.

      > - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters. 

      Maybe adding a 'contract.category' model could be great (in another module ?). But, for the time being, this can be done through contract tags. See: https://github.com/OCA/contract/blob/14.0/contract/models/contract.py#L110

      > - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module. 

      This is still tested in a draft PR: https://github.com/OCA/contract/pull/649 You can review it and make suggestions.

      > - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality. 

      This module has indeed a big history, refactored on 12.0 version I think. Since, some improvements have been done (refactoring on recurrency computations by Pedro see: https://github.com/OCA/contract/pull/533/commits/cd086ddbb4a9b85ccfcac288e53fb93e716d9446)

      Indeed, I think it has now a very complex implementation that makes user understanding (and debugging) difficult.

      We could make an issue on the github repository to help gathering ideas and focus discussion there than on this mailing list. But I agree that we could split some logic in separate modules (with meaningful names - if we could avoid base_contract).

      I hope this answered your questions.


      Regards,


      On Fri, Feb 10, 2023 at 5:57 PM Nicolas Rodriguez Sande <notifications@odoo-community.org> wrote:

      Hello, I’m writing to know your opinion about the contract repository. I started to use the modules in the repository and noted that the module versions of contract module differ a lot between odoo versions. 


      I have to do some implementations regarding that modules so I’m going to start making PRs to that repo and try to improve the modules starting in version 14.0 and then port it to the others. 

      I want to have your opinions on things you can tell me about what is missing in the modules and so I can organize my roadmap. Also, I don’t know if there are currently active PSC of the module, if not or you want me to join the team I will be interested, because I need to improve the modules and if that can help the development of the repo, count with me. 

      From what I saw, I see the following issues to solve, please if you know another issues or want to make an opinion of changes you would like to see in the module please comment me here: 

      - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.

      - I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering. 

      - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters. 

      - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module. 

      - Contract views are awful and need to be improved to favor user usability and comprehension of the module mechanics and uses. This is one of the first changes i want to introduce. 

      - Contract reports and portal views need to be improved. Currently the contract report is not so much developed. Also could be a good idea to allow to see agreements from portal contracts. 

      - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality. 

      If you have more opinions and things you want to see in a roadmap, please tell me here and i can maybe add it to my next PRs. Also if you have opinions of how the module should work will be great for when we refactor it. 

      Regards and i want for your thoughts. 

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe



      --

      Denis Roussel
      Software Engineer
      T    : +32 2 888 31 49
      M : +32 472 22 00 57


      Zone industrielle 22 | L-8287 Kehlen | Luxembourg

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by Nicolas Rodriguez Sande - 01:51 - 23 Feb 2023

  • Pricelist sale price on form
    Hello, 

    I would like to be able to show sales price in pricelist items form.

    Very similar task to this module (only available for odoo13 at the moment) https://odoo-community.org/shop/product-list-pricelist-price-6617#attr=12054, but this one does the job in the product template tree-view. 

    We would need the same one in the product pricelist item form. 
    I need it for odoo14 but I can consider modules for other version is there is one available but not available for 14 (could try to perform a migration in some cases).

    Thank you in advance. Regards,

    Francesco Ballerini

     


    by Francesco Ballerini - 10:20 - 8 Feb 2023

    11 replies 11 replies

  • module to publish on social networks
    Hi there,

    Do you know any OpenSource module effort on social areas that allows to schedule post on facebook/linkedin/... linked somehow with marketing campaigns?

    I would be pleased to help. If needs I could migrate such a module to version 14.0.

    Regards,
    --
    Pierre Verkest
    06 81 12 25 20
    Github: petrus-v - Twitter: petrusv84 - Linkedin: pierre-verkest
    by Pierre Verkest - 09:36 - 8 Feb 2023

    3 replies 3 replies

  • Website - download content
    Hi

    Have a prospect that wants website users to be able to download content in the form of PDF or PPT files, possibly grouped into categories or themes. Which module would be a good fit for that?

    Also is there like a module for a photo album/slideshow? They have quite a few historical photos they want to display.


    Torvald Baade Bringsvor
    Bringsvor Consulting AS - Developer, consultant, allrounder

    Tel (+47) 4548 2848
    by Torvald Bringsvor - 02:06 - 2 Feb 2023

    5 replies 5 replies

    • Re: Website - download content
      Thanks guys. Some interesting suggestions to follow up on.


      Torvald Baade Bringsvor
      Bringsvor Consulting AS - Developer, consultant, allrounder

      Tel (+47) 4548 2848


      On Thu, Feb 2, 2023 at 8:36 PM Pedro M. Baeza <notifications@odoo-community.org> wrote:
      On OCA/dms you can upload files and organize by folders, and then share what you want, or give access to portal users with a convenient portal view:

      Selección_043.png

      I think images are not seen, so I sent a link to  the shared image: https://postimg.cc/BX6GGH99


      Regards.

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by Torvald Bringsvor - 10:16 - 3 Feb 2023
    • Re: Website - download content
      On OCA/dms you can upload files and organize by folders, and then share what you want, or give access to portal users with a convenient portal view:

      Selección_043.png

      I think images are not seen, so I sent a link to  the shared image: https://postimg.cc/BX6GGH99


      Regards.
      by Pedro M. Baeza - 08:36 - 2 Feb 2023

      1 attachments 1 attachments

      Selección_043.png
    • Re: Website - download content

      Hi,

      Here at Coop IT Easy, we have developped a module named document_hosting that seams to do what you are looking for.

      https://github.com/coopiteasy/addons/tree/12.0/document_hosting

      It let you upload documents (any type) with the backend interface. You can group them by categories. You can set if the document is public or not.

      On the website there is an url which display the public documents for unconnected users and also the "private" document for connected users.

      It is used on production for BEES coop, Brussels, Belgium : https://gestion.bees-coop.be/documents

      This module needs documentation (readme is empty) and if you find it interesting, it would be nice to put it somewhere on an OCA repository (don't know which one is the best).
      Also, small screen design of the web page can be improved but it's fuctionnal.

      This module may also need to be migrated on newer odoo version (12.0 for the moment).

      The slide show option that you requested may be done by simply creating a new page with a new design by extending this module. Images can by uploaded like other documents via the admin interface.

      Best regards,

      Le 2 février 2023 14:07:40 GMT+01:00, Torvald Baade Bringsvor <notifications@odoo-community.org> a écrit :
      Hi

      Have a prospect that wants website users to be able to download content in the form of PDF or PPT files, possibly grouped into categories or themes. Which module would be a good fit for that?

      Also is there like a module for a photo album/slideshow? They have quite a few historical photos they want to display.


      Torvald Baade Bringsvor
      Bringsvor Consulting AS - Developer, consultant, allrounder

      Tel (+47) 4548 2848

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      --
      Rémy Taymans
      Coop IT Easy
      https://coopiteasy.be
      by Rémy Taymans - 08:26 - 2 Feb 2023
    • Re: Website - download content
      hello! 
      I would use E-Learning

      Daniel C.


      El jue, 2 feb 2023 a las 9:27, adyson10 (<notifications@odoo-community.org>) escribió:
      This is possible on enterprise is the documents module is installed


      Andy

      On 2 Feb 2023 13:07, Torvald Baade Bringsvor <notifications@odoo-community.org> wrote:
      Hi

      Have a prospect that wants website users to be able to download content in the form of PDF or PPT files, possibly grouped into categories or themes. Which module would be a good fit for that?

      Also is there like a module for a photo album/slideshow? They have quite a few historical photos they want to display.


      Torvald Baade Bringsvor
      Bringsvor Consulting AS - Developer, consultant, allrounder

      Tel (+47) 4548 2848

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe


      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by DANIEL CARRION - 05:06 - 2 Feb 2023
    • Re: Website - download content
      This is possible on enterprise is the documents module is installed


      Andy

      On 2 Feb 2023 13:07, Torvald Baade Bringsvor <notifications@odoo-community.org> wrote:
      Hi

      Have a prospect that wants website users to be able to download content in the form of PDF or PPT files, possibly grouped into categories or themes. Which module would be a good fit for that?

      Also is there like a module for a photo album/slideshow? They have quite a few historical photos they want to display.


      Torvald Baade Bringsvor
      Bringsvor Consulting AS - Developer, consultant, allrounder

      Tel (+47) 4548 2848

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe


      by Andy Dyson - 03:25 - 2 Feb 2023
  • Odoo -- Community v Enterprise Questions 
    Greetings,

       I'm new to the Odoo community.   I ran across Odoo while
looking for a Point of Sale for my girlfriend's business (brick and
mortar), but alas, we have been using GoHighLevel which has a lot of
overlap with Odoo.   As a result, I was looking at the offerings from
Odoo with respect to the community edition and the enterprise
editions.   But from what I can tell, enterprise subscriptions must
pay per user and Odoo.sh must host the deployment.

      I wear a number of hats at a number of different companies, such
as the requirement for my girlfriend's business below, a not for
profit corporation, which could benefit greatly from efforts in Odoo,
as well as my full time job, which could use Odoo as a cloud services
provider for internal accounting and forecasting purposes.

      All in all, I've been in the Internet industry for a long time
and have my own cabinet in a well connected data center with plenty of
compute and storage capabilities, so naturally, I would like to self
host.   I spent a few hours trying to find Odoo resources, which is
how I found my way here.  I also looked through the App directory, but
I was having a hard time reconciling the App directory with the
offerings included within the enterprise license.    Does anybody have
a pointer to a URL, or documents, which go into any level of detail on
how to create the enterprise experience in a self-hosted environment?
  As a side note, I would like to whitelabel the URL for my
girlfriend's business.   Further, I would want to nest multiple client
instances within a deployment (for her clients' environments) and then
be able to white label a specific clients environment, but that's a
longer term vision.

     Any help that could be provided to point me in the right
direction would be greatly appreciated.    I see a lot of personal use
cases for Odoo, but am struggling to see where the current lines have
been drawn between enterprise and community.

Thank you in advance,
Charles
    by cgucker - 06:31 - 29 Jan 2023

    15 replies 15 replies

    • Re: Odoo -- Community v Enterprise Questions
      On Sun, Feb 12, 2023 at 6:12 PM Dev <notifications@odoo-community.org> wrote:

      The reason for it being complicated is to do with database setup. I haven't found any way to have a docker install creates no database, so you can open the page and create/restore a database as described in the docs for a new installation. 


      Ah, that makes sense. For local containers, we don't restore a database, so no problem. In production, I never wanted /web/database/manage to show up for even a second, so I have Terraform get the database into shape prior to running Odoo for the first time.
       
      by Adam Heinz - 02:20 - 13 Feb 2023
    • Re: Odoo -- Community v Enterprise Questions
      On 13/02/2023 00:12, Dev wrote:
      Overall, I love the experience of dealing with containerized apps, compared to the old school style of installing them directly. However, there were two apps that stood out as being as struggle to install. One was Outline wiki (a great app once installed, however). The other was Odoo, both community and enterprise, but especially enterprise.
      Hello Lewy,

      Don't hesitate to contact us using the Odoo support if you have issues to use our docker image.

      Martin
      by Martin Trigaux - 10:05 - 13 Feb 2023
    • Re: Odoo -- Community v Enterprise Questions
      hi,

      on dockerhub, odoo provides a docker-compose file that install everything, and is very quick to deploy, including a postgres database.


      Regards,
      Dominique 


      On Mon, 13 Feb 2023 at 07:12, Dev <notifications@odoo-community.org> wrote:

      > I'm a little surprised by this statement. I prototyped Enterprise a few times between v12 and v15

      I learned docker last year over a period of about six months, so I'm not an expert - however I do have a fair degree of experience with Linux sysadmin spanning a decade or more, so I'm not a novice either. For work related reasons I ended up testing something like twenty different dockerized apps over this period, and Odoo was one of the later ones, so I was getting familiar by that time.

      Overall, I love the experience of dealing with containerized apps, compared to the old school style of installing them directly. However, there were two apps that stood out as being as struggle to install. One was Outline wiki (a great app once installed, however). The other was Odoo, both community and enterprise, but especially enterprise.

      The reason for it being complicated is to do with database setup. I haven't found any way to have a docker install creates no database, so you can open the page and create/restore a database as described in the docs for a new installation.

      Instead, what I get with every initial container, both writing my own compose scripts and following templates that I can find online, is loads of server errors (I forget exactly what errors now, but it was something to do with "database incorrectly initialized"). The only way around this that I have found is to add a command: 

      # Don't leave this line in for production!!
      # command: --db_host=${DB_HOST} --database ${DB_NAME} --db_user ${POSTGRES_USER} --db_password ${POSTGRES_PASSWORD} -i base


      Then on the first install I uncomment that, it creates a blank database and that allows me to access web/database/manage where I can finally restore the real database. Then I have to remember to uncomment the line and re-up the container (otherwise it will overwrite the database every time).

      As for enterprise, the only description in the docs for how to install is this:

      > Tip: For the Enterprise edition, you must add the path to the enterprise addons to the addons-path argument. Note that it must come before the other paths in addons-path for addons to be loaded correctly.

      https://www.odoo.com/documentation/16.0/administration/install/install.html

      When you download the enterprise files, you'll see that they have a folder structure similar to the entire Odoo install, including an addons folder. So, as per the tip, I added that enterprise/addons folder to the addons-path.

      This is incorrect. Instead, you need to add the *entire* enterprise folder structure as an addons folder, which means there's an addons folder with another addons folder inside it.

      I think it's fair to call this confusing and poorly documented, although it's far from the worst thing I've encountered in my dev career, or even in the Odoo docs.

      - Lewy

      P.S: If anyone can share a docker-compose template for community edition that does allow me to immediately access web/database/manage, I would appreciate it :)

      On 08-Feb-23 21:32, Adam Heinz wrote:
      On Tue, Feb 7, 2023 at 9:57 PM Dev <notifications@odoo-community.org> wrote:

      In terms of usage, installing the Enterprise version from source using Docker is complicated and poorly documented.


      I'm a little surprised by this statement. I prototyped Enterprise a few times between v12 and v15 and seem to recall it being no more than adding an /mnt/enterprise-addons volume on top of the standard odoo:12-15 docker container. We do the exact same type of mounting for our own custom development and also for OCA modules. We ultimately decided not to go with it due to cost and legal arbitration being in Europe, but I still press my face up against the glass and stare longingly at the Spreadsheets module. ;-)

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by dominique.k - 02:16 - 13 Feb 2023
    • Re: Odoo -- Community v Enterprise Questions

      > I'm a little surprised by this statement. I prototyped Enterprise a few times between v12 and v15

      I learned docker last year over a period of about six months, so I'm not an expert - however I do have a fair degree of experience with Linux sysadmin spanning a decade or more, so I'm not a novice either. For work related reasons I ended up testing something like twenty different dockerized apps over this period, and Odoo was one of the later ones, so I was getting familiar by that time.

      Overall, I love the experience of dealing with containerized apps, compared to the old school style of installing them directly. However, there were two apps that stood out as being as struggle to install. One was Outline wiki (a great app once installed, however). The other was Odoo, both community and enterprise, but especially enterprise.

      The reason for it being complicated is to do with database setup. I haven't found any way to have a docker install creates no database, so you can open the page and create/restore a database as described in the docs for a new installation.

      Instead, what I get with every initial container, both writing my own compose scripts and following templates that I can find online, is loads of server errors (I forget exactly what errors now, but it was something to do with "database incorrectly initialized"). The only way around this that I have found is to add a command: 

      # Don't leave this line in for production!!
      # command: --db_host=${DB_HOST} --database ${DB_NAME} --db_user ${POSTGRES_USER} --db_password ${POSTGRES_PASSWORD} -i base


      Then on the first install I uncomment that, it creates a blank database and that allows me to access web/database/manage where I can finally restore the real database. Then I have to remember to uncomment the line and re-up the container (otherwise it will overwrite the database every time).

      As for enterprise, the only description in the docs for how to install is this:

      > Tip: For the Enterprise edition, you must add the path to the enterprise addons to the addons-path argument. Note that it must come before the other paths in addons-path for addons to be loaded correctly.

      https://www.odoo.com/documentation/16.0/administration/install/install.html

      When you download the enterprise files, you'll see that they have a folder structure similar to the entire Odoo install, including an addons folder. So, as per the tip, I added that enterprise/addons folder to the addons-path.

      This is incorrect. Instead, you need to add the *entire* enterprise folder structure as an addons folder, which means there's an addons folder with another addons folder inside it.

      I think it's fair to call this confusing and poorly documented, although it's far from the worst thing I've encountered in my dev career, or even in the Odoo docs.

      - Lewy

      P.S: If anyone can share a docker-compose template for community edition that does allow me to immediately access web/database/manage, I would appreciate it :)

      On 08-Feb-23 21:32, Adam Heinz wrote:
      On Tue, Feb 7, 2023 at 9:57 PM Dev <notifications@odoo-community.org> wrote:

      In terms of usage, installing the Enterprise version from source using Docker is complicated and poorly documented.


      I'm a little surprised by this statement. I prototyped Enterprise a few times between v12 and v15 and seem to recall it being no more than adding an /mnt/enterprise-addons volume on top of the standard odoo:12-15 docker container. We do the exact same type of mounting for our own custom development and also for OCA modules. We ultimately decided not to go with it due to cost and legal arbitration being in Europe, but I still press my face up against the glass and stare longingly at the Spreadsheets module. ;-)

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by dev - 12:10 - 13 Feb 2023
    • Re: Odoo -- Community v Enterprise Questions
      On Tue, Feb 7, 2023 at 9:57 PM Dev <notifications@odoo-community.org> wrote:

      In terms of usage, installing the Enterprise version from source using Docker is complicated and poorly documented.


      I'm a little surprised by this statement. I prototyped Enterprise a few times between v12 and v15 and seem to recall it being no more than adding an /mnt/enterprise-addons volume on top of the standard odoo:12-15 docker container. We do the exact same type of mounting for our own custom development and also for OCA modules. We ultimately decided not to go with it due to cost and legal arbitration being in Europe, but I still press my face up against the glass and stare longingly at the Spreadsheets module. ;-)
      by Adam Heinz - 03:31 - 8 Feb 2023

  • Pricelist based on max purchase cost

    Hello OCA contributors, I am looking at pricelist in Odoo14. Firstly I have checked in the brand repository https://github.com/OCA/brand/tree/14.0 and found an awsome PR that integrates brand with product pricelist. Thanks for the awsome work you make for Odoo. About the brand I’d like to know if there is something that allows to filter products by brand in website as well.

     

    But mostly I’d like to ask for a feature that I did not find in Odoo14. Basically we need a pricelist that apply a % discount  based on the maximum purchase price.

     

    The closest thing I manage to reach is to apply a pricelist based on formula that applies % discount based on product cost but we need much more than this. I did not found any repository for pricelists, so I’d like to ask if there is something module or way to achieve this feature, or what do you advice to achieve it.

     

    Thank you very much,

     

    Francesco Ballerini

     

     

     

    Inviato da Posta per Windows

     


    Privo di virus.www.avast.com
    by Francesco Ballerini - 08:17 - 28 Jan 2023

    1 replies 1 replies

    • Fwd: Pricelist based on max purchase cost

      Good morning OCA Contributors, 

      I was doing some analysis on models 'product.pricelist', 'product.pricelist.item', 'product.supplierinfo' (never checked those models before) and product.product and I'd like to add some technical info to my previous message. 

      This message doesn't really add many functional infos to the previous message, it's more a technical example to explain from code point of view what I would like to achieve, hoping it helps either to give better indications to find what I'm looking for or, in the worst case, I hope I can have some feedback for developing a 'decent looking' solution.

      Before joining the 'funny part' I would like to correct myself since I realized that "standard_price" field is not related to seller_ids.
      That doesn't change much in the general sense since I probably need a loop/search on "price" field of model "product.supplierinfo" to retrieve the higher seller price and use it in the pricelist formula (TLTR) but it wasn't very accurate.

      That said, if I only speak from my perspective/needs, so in a 'vertical' way of thinking, I probably need something that, before calling the _compute_price method in model 'product.pricelist.item' will check the seller_ids (or a stored value for the max seller id price) and takes max seller id price value instead of "standard_price" (or "list_price"), so the formula:

      "price = (price - (price * (self.price_discount / 100))) or 0.0"  -- where price is taken as " standard_price" in product.product model

      will become 

      "price = (price - (max_seller_price* (self.price_discount / 100))) or 0.0"

      Side note: This will also require an additional key in field "base" to setup a different workflow for pricelist based on formula → seller prices

      If calculated 'on the fly' it can is almost surely bad in terms of performance so I think it's better to store the maximum seller price somewhere in the product record, I'm not sure about the right moment to calculate and store the value though, maybe when a new purchase is performed, but still have to think about this detail.
      This way, the max seller price can be passed in the function  _compute_price and there should not be performance issues on the sale order.

      To achieve this a new field should be added to product.template model, so I can store the value and pass to the formula if the conditions are met.

      Is this feature somehow achievable, or maybe there is even a better way to achieve it? If not or partially achieved, I could also consider some more extensible variants if the community is interested to this feature:

      Variant 1

      1) Add 3 field to product.template model: "seller_cost_max", "seller_cost_min", "seller_cost_average" and compute the values (still not sure when)

      2) add a Selection field to model 'product.pricelist.item' to choose if you want to apply 

      - apply standard_price
      - apply seller_cost_max
      - apply seller_cost_min
      - apply seller_cost_average

      To the formula 
      "price = (price - (chosen_value* (self.price_discount / 100))) or 0.0"

      Variant 2 (save some DB columns)

      1) Store only 1 value between max/min/average cost in a new field, "seller_price_computed", you can decide which calculation method to use thanks to a select field in res.config.settings.

      2) Add a flag to 'product.pricelist.item' to choose if you want to apply the 'standard_price' or "seller_price_computed" to the formula.

      I added this last part in case you like the idea and this feature is not or partially implemented, please for now just consider it as an idea on the table. I'm also pretty confident that that this feature, or part of it is already implemented in odoo14, so I'll wait for your feedback!

      Cheers,
      Francesco Ballerini



      ---------- Forwarded message ---------
      Da: Francesco Ballerini <francescobl.lavoro@gmail.com>
      Date: sab 28 gen 2023 alle ore 20:09
      Subject: Pricelist based on max purchase cost
      To: contributors@odoo-community.org <contributors@odoo-community.org>


      Hello OCA contributors, I am looking at pricelist in Odoo14. Firstly I have checked in the brand repository https://github.com/OCA/brand/tree/14.0 and found an awsome PR that integrates brand with product pricelist. Thanks for the awsome work you make for Odoo. About the brand I’d like to know if there is something that allows to filter products by brand in website as well.

       

      But mostly I’d like to ask for a feature that I did not find in Odoo14. Basically we need a pricelist that apply a % discount  based on the maximum purchase price.

       

      The closest thing I manage to reach is to apply a pricelist based on formula that applies % discount based on product cost but we need much more than this. I did not found any repository for pricelists, so I’d like to ask if there is something module or way to achieve this feature, or what do you advice to achieve it.

       

      Thank you very much,

       

      Francesco Ballerini

       

       

       

      Inviato da Posta per Windows

       


      Privo di virus.www.avast.com
      by Francesco Ballerini - 07:31 - 29 Jan 2023
  • Start with contributing, Git-rookie

    Dear OCA contributers,

    i just started getting into supporting oca modules. Or rather thats my goal. Up to now… just in theory of course. I already read a lot of theory and want to hop to the next step.

    Before stepping into practice i just wanted to make sure, that i can not do something wrong. As long as i push my commits to my git repo (forked from oca) there is nothing i can interfer with right?

    Also the pull request won´t take effect on oca repos, as long as is it checked and permitted by appropriate members right? I did understand it this way. But want to avoid any conflicts upfront.

    Probably  it will take some practical experience to adapt to the oca conventions in the required way. Looking forward to it!

     

    A short feedback on this would be great.

     

    Cheers Nils

     

    -- 
    https://nico-solutions.de/web/image/7246-1f069f8c/LOGO_BLUE_SIGNATURE.png?access_token=2624fe9d-a400-48f1-a466-954e1a9a9dbc

    NICO SOLUTIONS - ENGINEERING & IT 

    Kontakt (Contact): 
    Mail: info@nico-solutions.de 
    Web: https://nico-solutions.de

    by Nils Coenen - 02:31 - 28 Jan 2023

    1 attachments 1 attachments

    image001.png

    3 replies 3 replies

    • Re: Start with contributing, Git-rookie

      Thanks for the hint with runboat. Old blog info was sticking to my memory…

       

      -- 

      NICO SOLUTIONS - ENGINEERING & IT 

      Von: Tom Blauwendraat <notifications@odoo-community.org>
      Antworten an: "Odoo Community Association (OCA) Contributors" <contributors@odoo-community.org>
      Datum: Samstag, 28. Januar 2023 um 15:42
      An: Contributors <contributors@odoo-community.org>
      Betreff: Re: Start with contributing, Git-rookie

       

      Hi Nils! There is nothing you can break when opening a Pull Request to OCA, or pushing to it. Even if you tried to, you would not be able to bring new code directly into OCA repos, because only the maintainers are able to do so, by merging Pull Requests. And that can only happen after a review by someone else. So no worries in that regard - you won't break anything.

      The challenge comes in getting your Pull Requests accepted by OCA, for which there are quite a lot of guidelines:

      https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst

      Then, you need to find at least 2 people that want to review your Pull Request. What can work is to review other people's pull requests, then ask them to review in return. A review does not have to be a code review - it can also be a functional review, which comes down to testing someone's (changes to) a module, either by installing them yourself somewhere, or testing them on "Runboat".

      Cheers and welcome to the OCA.

      -Tom

      On 1/28/23 14:32, Nils Coenen wrote:

      Dear OCA contributers,

      i just started getting into supporting oca modules. Or rather thats my goal. Up to now… just in theory of course. I already read a lot of theory and want to hop to the next step.

      Before stepping into practice i just wanted to make sure, that i can not do something wrong. As long as i push my commits to my git repo (forked from oca) there is nothing i can interfer with right?

      Also the pull request won´t take effect on oca repos, as long as is it checked and permitted by appropriate members right? I did understand it this way. But want to avoid any conflicts upfront.

      Probably  it will take some practical experience to adapt to the oca conventions in the required way. Looking forward to it!

       

      A short feedback on this would be great.

       

      Cheers Nils

       

      -- 
      Das Bild wurde vom Absender entfernt. https://nico-solutions.de/web/image/7246-1f069f8c/LOGO_BLUE_SIGNATURE.png?access_token=2624fe9d-a400-48f1-a466-954e1a9a9dbc

      NICO SOLUTIONS - ENGINEERING & IT 

      Kontakt (Contact): 
      Mail: info@nico-solutions.de 
      Web: https://nico-solutions.de

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by Nils Coenen - 04:51 - 28 Jan 2023
    • Re: Start with contributing, Git-rookie

      Hey Tom,

      many thanks for your reply.

      Ok.. so i will dig into it more offensive and focus more on reviewing other pull requests for networking, which makes perfect sense.

      Runboat is definitly something to get into. But i think it is not available for 16.0 if i am right. At the moment there are some tasks for me to do in 16.0.

      I´ll do my best to keep it as simple as possible for everybody.

      Constructive criticism is always welcome ;P

       

      Nils

       

      -- 

      NICO SOLUTIONS - ENGINEERING & IT 

       

      Von: Tom Blauwendraat <notifications@odoo-community.org>
      Antworten an: "Odoo Community Association (OCA) Contributors" <contributors@odoo-community.org>
      Datum: Samstag, 28. Januar 2023 um 15:42
      An: Contributors <contributors@odoo-community.org>
      Betreff: Re: Start with contributing, Git-rookie

       

      Hi Nils! There is nothing you can break when opening a Pull Request to OCA, or pushing to it. Even if you tried to, you would not be able to bring new code directly into OCA repos, because only the maintainers are able to do so, by merging Pull Requests. And that can only happen after a review by someone else. So no worries in that regard - you won't break anything.

      The challenge comes in getting your Pull Requests accepted by OCA, for which there are quite a lot of guidelines:

      https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst

      Then, you need to find at least 2 people that want to review your Pull Request. What can work is to review other people's pull requests, then ask them to review in return. A review does not have to be a code review - it can also be a functional review, which comes down to testing someone's (changes to) a module, either by installing them yourself somewhere, or testing them on "Runboat".

      Cheers and welcome to the OCA.

      -Tom

      On 1/28/23 14:32, Nils Coenen wrote:

      Dear OCA contributers,

      i just started getting into supporting oca modules. Or rather thats my goal. Up to now… just in theory of course. I already read a lot of theory and want to hop to the next step.

      Before stepping into practice i just wanted to make sure, that i can not do something wrong. As long as i push my commits to my git repo (forked from oca) there is nothing i can interfer with right?

      Also the pull request won´t take effect on oca repos, as long as is it checked and permitted by appropriate members right? I did understand it this way. But want to avoid any conflicts upfront.

      Probably  it will take some practical experience to adapt to the oca conventions in the required way. Looking forward to it!

       

      A short feedback on this would be great.

       

      Cheers Nils

       

      -- 
      Das Bild wurde vom Absender entfernt. https://nico-solutions.de/web/image/7246-1f069f8c/LOGO_BLUE_SIGNATURE.png?access_token=2624fe9d-a400-48f1-a466-954e1a9a9dbc

      NICO SOLUTIONS - ENGINEERING & IT 

      Kontakt (Contact): 
      Mail: info@nico-solutions.de 
      Web: https://nico-solutions.de

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by Nils Coenen - 04:20 - 28 Jan 2023
    • Re: Start with contributing, Git-rookie

      Hi Nils! There is nothing you can break when opening a Pull Request to OCA, or pushing to it. Even if you tried to, you would not be able to bring new code directly into OCA repos, because only the maintainers are able to do so, by merging Pull Requests. And that can only happen after a review by someone else. So no worries in that regard - you won't break anything.

      The challenge comes in getting your Pull Requests accepted by OCA, for which there are quite a lot of guidelines:

      https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst

      Then, you need to find at least 2 people that want to review your Pull Request. What can work is to review other people's pull requests, then ask them to review in return. A review does not have to be a code review - it can also be a functional review, which comes down to testing someone's (changes to) a module, either by installing them yourself somewhere, or testing them on "Runboat".

      Cheers and welcome to the OCA.

      -Tom

      On 1/28/23 14:32, Nils Coenen wrote:

      Dear OCA contributers,

      i just started getting into supporting oca modules. Or rather thats my goal. Up to now… just in theory of course. I already read a lot of theory and want to hop to the next step.

      Before stepping into practice i just wanted to make sure, that i can not do something wrong. As long as i push my commits to my git repo (forked from oca) there is nothing i can interfer with right?

      Also the pull request won´t take effect on oca repos, as long as is it checked and permitted by appropriate members right? I did understand it this way. But want to avoid any conflicts upfront.

      Probably  it will take some practical experience to adapt to the oca conventions in the required way. Looking forward to it!

       

      A short feedback on this would be great.

       

      Cheers Nils

       

      -- 
      https://nico-solutions.de/web/image/7246-1f069f8c/LOGO_BLUE_SIGNATURE.png?access_token=2624fe9d-a400-48f1-a466-954e1a9a9dbc

      NICO SOLUTIONS - ENGINEERING & IT 

      Kontakt (Contact): 
      Mail: info@nico-solutions.de 
      Web: https://nico-solutions.de

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by Tom Blauwendraat - 03:40 - 28 Jan 2023
  • snippets for editor in website_sale_product_description 
    Hi,

i would like to know if there is any way i could provide HTML snippets, 
for the editor used in the description field here?:

https://github.com/OCA/e-commerce/tree/14.0/website_sale_product_description

This way people could add things like blocks (image left with text on 
the right) without using HTML-Tables.

cheers


-- 
Maik Derstappen


derico - web development & consulting
>> Python - Plone - Odoo - Pyramid - Django

Maik Derstappen - Geschäftsführer

Laaver Weg 2 - 19273 Neuhaus/Elbe - Deutschland
Tel: +49 178 861 2 833 - +49 341 126 951 71 - E-Mail: md@derico.de - Web: http://derico.de
    by Maik Derstappen - 11:01 - 26 Jan 2023
  • How to lookup psc team for repo?
    I'm reading through the teams at https://odoo-community.org/psc-teams, but am not seeing who owns the queue repo. I'm currently clicking into each psc team and looking at their repo list, but there has to be a better way?
    by Adam Heinz - 03:06 - 25 Jan 2023

    6 replies 6 replies

  • Size of ir.translation table over total db size
    Hi all, 

    we've recently found out that on a "clean" db (not yet in production), with around 350 modules installed and no customer data imported, the ir.translation table occupies about 95% of the space - about 9GB. Just two languages are enabled.

    On another db in production since 2+ years, out of 7,5 GB of the db size, ir.translations occupies 21% of the space (1,6GB). Just one language is enabled here.

    We were a bit surprised to find out about the table size and we're looking for feedback on whether these proportions sound "regular" to you. 

    Thanks!

    --

    Francesco Foresti
    Sicurpharma Srl
    by Francesco Foresti - 07:11 - 24 Jan 2023

    7 replies 7 replies

    • Re: Size of ir.translation table over total db size
      Thank you all for your valuable responses, I'll let you know what we find out. 

      Cheers!

      Il giorno mer 25 gen 2023 alle ore 08:07 Martin Trigaux (Odoo) <notifications@odoo-community.org> ha scritto:
      On 24/01/2023 19:11, Francesco Foresti wrote:

      we've recently found out that on a "clean" db (not yet in production), with around 350 modules installed and no customer data imported, the ir.translation table occupies about 95% of the space - about 9GB. Just two languages are enabled.

      On another db in production since 2+ years, out of 7,5 GB of the db size, ir.translations occupies 21% of the space (1,6GB). Just one language is enabled here.

      Your clean db stats seems to the roof. On the Github PR odoo/odoo#45958 I measured the size with 7 languages installed on a new database. I did not have 350 modules installed but the size was measured in MB, not GB.
      I suspect one (or more) of the module is polluting the table. Check the entries based on the module field to find the culprit.

      On a production database, it may grow a lot but 1.6 Gb still seems excessive (I don't think we reached that size on odoo.com).
      On old database, orphan translations (pointing to records that no longer exists) may increase the size of the table unnecessarily but 2 years is not that old either.
      I would start by investigating what takes so much space in this table.

      Best,

      Martin

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe



      --

      Francesco Foresti
      Sicurpharma Srl
      +39 333 8123 790

      by Francesco Foresti - 09:50 - 25 Jan 2023
    • Re: Size of ir.translation table over total db size
      On 24/01/2023 19:11, Francesco Foresti wrote:

      we've recently found out that on a "clean" db (not yet in production), with around 350 modules installed and no customer data imported, the ir.translation table occupies about 95% of the space - about 9GB. Just two languages are enabled.

      On another db in production since 2+ years, out of 7,5 GB of the db size, ir.translations occupies 21% of the space (1,6GB). Just one language is enabled here.

      Your clean db stats seems to the roof. On the Github PR odoo/odoo#45958 I measured the size with 7 languages installed on a new database. I did not have 350 modules installed but the size was measured in MB, not GB.
      I suspect one (or more) of the module is polluting the table. Check the entries based on the module field to find the culprit.

      On a production database, it may grow a lot but 1.6 Gb still seems excessive (I don't think we reached that size on odoo.com).
      On old database, orphan translations (pointing to records that no longer exists) may increase the size of the table unnecessarily but 2 years is not that old either.
      I would start by investigating what takes so much space in this table.

      Best,

      Martin
      by Martin Trigaux - 08:06 - 25 Jan 2023
    • Re: Size of ir.translation table over total db size

      Good idea but vacuum full only in off peak times and after a proper backup (for the own safety) ;-)

      Best Frederik

      Am 24.01.23 um 20:51 schrieb Moises Lopez:
      Hi,

      There is an issue related with vacuum claim space in tables


      Also, you didn't mention the PG version used

      But try running a "vacuum full"


      On Tue 24 Jan 2023 at 12:11 p.m. Francesco Foresti <notifications@odoo-community.org> wrote:
      Hi all, 

      we've recently found out that on a "clean" db (not yet in production), with around 350 modules installed and no customer data imported, the ir.translation table occupies about 95% of the space - about 9GB. Just two languages are enabled.

      On another db in production since 2+ years, out of 7,5 GB of the db size, ir.translations occupies 21% of the space (1,6GB). Just one language is enabled here.

      We were a bit surprised to find out about the table size and we're looking for feedback on whether these proportions sound "regular" to you. 

      Thanks!

      --

      Francesco Foresti
      Sicurpharma Srl

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      --
      Moisés López Calderón
      Mobile: (+521) 477-752-22-30
      Twitter: @moylop260
      hangout: moylop260@vauxoo.com
      http://www.vauxoo.com - Odoo Gold Partner
      Twitter: @vauxoo

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      -- 
Dr.-Ing. Frederik Kramer
Geschäftsführer

initOS GmbH
Innungsstraße 7
21244 Buchholz i.d.N.

Phone:  +49 4181 13503-12
Fax:    +49 4181 13503-10
Mobil:  +49 179 3901819

Email: frederik.kramer@initos.com
Web:   www.initos.com

Geschäftsführung:
Dr.-Ing. Frederik Kramer & Dipl.-Ing. (FH) Torsten Francke

Sitz der Gesellschaft: Buchholz i.d.N.
Amtsgericht Tostedt, HRB 205226
Steuer-Nr: 15/200/53247
USt-IdNr.: DE815580155
      by Frederik Kramer. - 09:06 - 24 Jan 2023
    • Re: Size of ir.translation table over total db size
      Hi,

      There is an issue related with vacuum claim space in tables


      Also, you didn't mention the PG version used

      But try running a "vacuum full"


      On Tue 24 Jan 2023 at 12:11 p.m. Francesco Foresti <notifications@odoo-community.org> wrote:
      Hi all, 

      we've recently found out that on a "clean" db (not yet in production), with around 350 modules installed and no customer data imported, the ir.translation table occupies about 95% of the space - about 9GB. Just two languages are enabled.

      On another db in production since 2+ years, out of 7,5 GB of the db size, ir.translations occupies 21% of the space (1,6GB). Just one language is enabled here.

      We were a bit surprised to find out about the table size and we're looking for feedback on whether these proportions sound "regular" to you. 

      Thanks!

      --

      Francesco Foresti
      Sicurpharma Srl

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      --
      Moisés López Calderón
      Mobile: (+521) 477-752-22-30
      Twitter: @moylop260
      hangout: moylop260@vauxoo.com
      http://www.vauxoo.com - Odoo Gold Partner
      Twitter: @vauxoo
      by Moisés López Calderón - 08:50 - 24 Jan 2023
    • Re: Size of ir.translation table over total db size
      Maybe such a size is because there's a lot of translatable content in such DB (like big product descriptions including e-commerce and a lot of products).

      Regards.
      by Pedro M. Baeza - 08:31 - 24 Jan 2023

  • auditlog incompatible with partner_firstname
    What is the best way to raise issues that span multiple repositories? I entered https://github.com/OCA/server-tools/issues/2487 on the server-tools repository, but didn't duplicate it on the partner-contact repository. I've made a couple attempts to chase it down myself, but have been left scratching my head.
    by Adam Heinz - 06:15 - 24 Jan 2023