1. Mailing Lists
  2. Contributors
  3. Re: Should we use the new GitHub reactions?

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: external review tools (was Re: Should we use the new GitHub reactions?)

Re: Should we use the new GitHub reactions?

Avatar

Re: Should we use the new GitHub reactions?

by
Vauxoo, Moisés López Calderón
- 18/03/2016 15:01:20
FYI follow tool help us to automate the +1 rule in each PR

I don't know if is compatible with reactions.

2016-03-18 5:08 GMT-06:00 Lionel Sausin <ls@numerigraphe.com>:
Le 18/03/2016 01:53, Eric Caudal a écrit :
>
> Ideally we should have a +1 specific for "official reviewers"
>
Oh no, I think we do want reviews from everyone.
We already have too few reviewers, if they have to be "official" we'll 
fossilize the review team.

I'm OK for keeping the approvals in the comments, but with the new 
reactions system the "+1" is not a good mark anymore - too confusing.
Can't we just write "Ok to merge"?

_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe




--
Moisés López Calderón
Vauxoo - OpenERP's Gold Partner
Mobile: (+521) 477-752-22-30
Office: (+52) 477-773-33-46
web: http://www.vauxoo.com
twitter: @vauxoo
           @moylop260           

Reference