1. Mailing Lists
  2. Contributors
  3. Re: Should we use the new GitHub reactions?

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: Should we use the new GitHub reactions?

Re: external review tools (was Re: Should we use the new GitHub reactions?)

Avatar

Re: Should we use the new GitHub reactions?

by
Numérigraphe, Lionel Sausin
- 18/03/2016 12:05:47 
Le 18/03/2016 01:53, Eric Caudal a écrit :
>
> Ideally we should have a +1 specific for "official reviewers"
>
Oh no, I think we do want reviews from everyone.
We already have too few reviewers, if they have to be "official" we'll 
fossilize the review team.

I'm OK for keeping the approvals in the comments, but with the new 
reactions system the "+1" is not a good mark anymore - too confusing.
Can't we just write "Ok to merge"?

Reference