Contributors mailing list archives
contributors@odoo-community.org
Browse archives
Re: Start with contributing, Git-rookie
byHey Tom,
many thanks for your reply.
Ok.. so i will dig into it more offensive and focus more on reviewing other pull requests for networking, which makes perfect sense.
Runboat is definitly something to get into. But i think it is not available for 16.0 if i am right. At the moment there are some tasks for me to do in 16.0.
I´ll do my best to keep it as simple as possible for everybody.
Constructive criticism is always welcome ;P
Nils
--
NICO SOLUTIONS - ENGINEERING & IT
Von: Tom Blauwendraat <notifications@odoo-community.org>
Antworten an: "Odoo Community Association (OCA) Contributors" <contributors@odoo-community.org>
Datum: Samstag, 28. Januar 2023 um 15:42
An: Contributors <contributors@odoo-community.org>
Betreff: Re: Start with contributing, Git-rookie
Hi Nils! There is nothing you can break when opening a Pull Request to OCA, or pushing to it. Even if you tried to, you would not be able to bring new code directly into OCA repos, because only the maintainers are able to do so, by merging Pull Requests. And that can only happen after a review by someone else. So no worries in that regard - you won't break anything.
The challenge comes in getting your Pull Requests accepted by OCA, for which there are quite a lot of guidelines:
https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst
Then, you need to find at least 2 people that want to review your Pull Request. What can work is to review other people's pull requests, then ask them to review in return. A review does not have to be a code review - it can also be a functional review, which comes down to testing someone's (changes to) a module, either by installing them yourself somewhere, or testing them on "Runboat".
Cheers and welcome to the OCA.
-Tom
On 1/28/23 14:32, Nils Coenen wrote:
Dear OCA contributers,
i just started getting into supporting oca modules. Or rather thats my goal. Up to now… just in theory of course. I already read a lot of theory and want to hop to the next step.
Before stepping into practice i just wanted to make sure, that i can not do something wrong. As long as i push my commits to my git repo (forked from oca) there is nothing i can interfer with right?
Also the pull request won´t take effect on oca repos, as long as is it checked and permitted by appropriate members right? I did understand it this way. But want to avoid any conflicts upfront.
Probably it will take some practical experience to adapt to the oca conventions in the required way. Looking forward to it!
A short feedback on this would be great.
Cheers Nils
--
NICO SOLUTIONS - ENGINEERING & IT
Kontakt (Contact):
Mail: info@nico-solutions.de
Web: https://nico-solutions.de_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
Reference
-
Start with contributing, Git-rookie
byNICO SOLUTIONS - ENGINEERING & IT , Nils Coenen- 28/01/2023 14:30:18 - 1-
Re: Start with contributing, Git-rookie
byNICO SOLUTIONS - ENGINEERING & IT , Nils Coenen- 28/01/2023 16:49:18 - 0 -
Re: Start with contributing, Git-rookie
byNICO SOLUTIONS - ENGINEERING & IT , Nils Coenen- 28/01/2023 16:17:08 - 0 -
-
