1. Mailing Lists
  2. Contributors
  3. Re: Start with contributing, Git-rookie

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: Start with contributing, Git-rookie

Avatar

Re: Start with contributing, Git-rookie

by
Therp, Tom Blauwendraat
- 28/01/2023 15:36:50

Hi Nils! There is nothing you can break when opening a Pull Request to OCA, or pushing to it. Even if you tried to, you would not be able to bring new code directly into OCA repos, because only the maintainers are able to do so, by merging Pull Requests. And that can only happen after a review by someone else. So no worries in that regard - you won't break anything.

The challenge comes in getting your Pull Requests accepted by OCA, for which there are quite a lot of guidelines:

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst

Then, you need to find at least 2 people that want to review your Pull Request. What can work is to review other people's pull requests, then ask them to review in return. A review does not have to be a code review - it can also be a functional review, which comes down to testing someone's (changes to) a module, either by installing them yourself somewhere, or testing them on "Runboat".

Cheers and welcome to the OCA.

-Tom

On 1/28/23 14:32, Nils Coenen wrote:

Dear OCA contributers,

i just started getting into supporting oca modules. Or rather thats my goal. Up to now… just in theory of course. I already read a lot of theory and want to hop to the next step.

Before stepping into practice i just wanted to make sure, that i can not do something wrong. As long as i push my commits to my git repo (forked from oca) there is nothing i can interfer with right?

Also the pull request won´t take effect on oca repos, as long as is it checked and permitted by appropriate members right? I did understand it this way. But want to avoid any conflicts upfront.

Probably  it will take some practical experience to adapt to the oca conventions in the required way. Looking forward to it!

 

A short feedback on this would be great.

 

Cheers Nils

 

-- 
https://nico-solutions.de/web/image/7246-1f069f8c/LOGO_BLUE_SIGNATURE.png?access_token=2624fe9d-a400-48f1-a466-954e1a9a9dbc

NICO SOLUTIONS - ENGINEERING & IT 

Kontakt (Contact): 
Mail: info@nico-solutions.de 
Web: https://nico-solutions.de

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Reference