1. Mailing Lists
  2. Contributors
  3. Re: Question about PR contribution rules

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: Question about PR contribution rules

Avatar

Re: Question about PR contribution rules

by
Tecnativa. S. L., Pedro M. Baeza
- 05/01/2026 14:21:47
Hi, Tom, I think you are trying to make a gold thumb rule out of context of all the things people told you in the PRs.

There aren't hard-written rules, as this depends on the context and the things you are doing. It may be good to set use cases on the contribution guidelines for those possibilities, but others also said in the past that the contribution guidelines are very long and hard for adding more things...

In general, common sense should prevail, and more if you want the PR to be accepted. Put it easy to the reviewers! If the changes are a logical set, put it in one PR. Don't mix in a PR a module migration with other improvements, unless they are justified due to the version change. Don't put several unrelated improvements/fixes in the same PR for easing the reviewing/merging. Is this last one mandatory? No, you can pack them in several commits in the same PR, but then, that implies more effort for the reviewers to check it, so less chances to get it merged. What is not allowed (implicitly) is to mix in just one commit several unrelated things.

And the contrary case: when you are splitting one logical set into several commits because it follows your development flow, committing little changes of several few lines, then you are asked to squash together those commits, as split they make no sense when you are reviewing/blaming the commit history.

Please specify the links of such specific PRs to put the comments in context, but I have tried to make an overall landscape, and the summary is that... it depends on the context, hehe.

Regards.

Reference