1. Mailing Lists
  2. Contributors
  3. Re: Question about PR contribution rules

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: Question about PR contribution rules

Avatar

Re: Question about PR contribution rules

by
Acsone SA/NV, Denis Roussel
- 05/01/2026 14:01:43
Hello Tom,


1. -> I would say it should. This depends on:

    - If both modules should be bumped differently (e.g.: one patch and one minor), they should be split in different PR's.
    - Changes in modules should be grouped per module in PR's commits.

2. -> It can be done in the same PR if atomic (and/or functional) changes have been grouped in separate commits.

3. -> This is not mandatory IMHO, as said above, changes are grouped in separate commits (See: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message)


It's not written explicitly as it is linked to general development flows with git apart for the bump flow with ocabot. I would say it is maybe easier to understand for newcomers (the one thing for all) but should not be enforced like that.

My two cents


Le lun. 5 janv. 2026 à 13:47, Tom Blauwendraat <notifications@odoo-community.org> a écrit :
Hi all,

question - I've been told several times on OCA PR's that any PR should 
satisfy the following rules:

1. It needs to deal with only one module at a time, otherwise it should 
be split up

2. It needs to deal with one change only, otherwise it should be split up

3. It needs to be in one commit (unless there is good reason to have 
several commits, eg multiple authors or separating pre-commit from 
functional changes)

However, I can't find these rules in our contribution guidelines:

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review

Can someone point me to where this is written? Or is this not formalized 
and subject to PSC preference?

-Tom

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Reference