1. Mailing Lists
  2. Contributors
  3. new API vs merges upwards

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Leaving SFL and Odoo developement

Re: Stock Cancel in v8.0

Avatar

new API vs merges upwards

by
Leonardo Pistone
- 31/07/2015 11:42:13 
We hit this topic other times, but this time we have a practical example:

https://github.com/OCA/stock-logistics-workflow/pull/132/files#diff-cfbfcae8295adcadf086ea7bfa09b21dL185

What happened is that the v7 of a module was improved, and in the
merge upwards of 7 to 8, I resolved the conflict choosing the v7
version. In that specific case I thought that I was just throwing away
two trivial new API lines for a big win.

I do not think there is a good solution to that. Even the solution of
porting the method to v8 is not ideal: the fresh v7 code is in
production somewhere, and if it breaks we'll sure post a fix, bringing
us back at square one. The new API port will be unused by us for the
moment, hiding new bugs for a while.

Odoo SA does upwards merges regularly, but only because they did very
little porting to the new API. In our case, I'm not sure if it's worth
it.

What do you think on the subject?

Follow-Ups