1. Mailing Lists
  2. Contributors
  3. Re: Question about Module Structure

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: Question about Module Structure

Re: Question about Module Structure

Avatar

Re: Question about Module Structure

by
MoaHub, Graeme Gellatly
- 22/02/2018 20:40:10
Pedro,

git-subrepo is quite different to git subrepos/submodules.  Its kind of a parallel evolution of git stree.  I've used it for about 18 months.  Some things it fits perfectly, especially when you just need to pull in genuine external dependencies (i.e. js libs), or a real decoupled dependency required across multiple versions.  But it doesn't really fit Odoo's module structure as it is, plus it has some fun unresolved bugs that would really affect it in an OCA context.  But if you have time, it is worth a play with.  At the same time, the complexity of managing it beyond simple use just isn't worth it atm IMO.  As soon as you hit something that hasn't been considered, you are kneedeep in StackOverflow issuing 20 archaic git commands wondering what the hell it is that you are doing.

On Fri, Feb 23, 2018 at 7:02 AM, Pedro Manuel Baeza Romero <pedro.baeza@gmail.com> wrote:
GIT subrepos are very limited, as they freeze specific subrepos commits.

Having pip + docker deployment initiatives like https://github.com/Tecnativa/docker-odoo-base, I don't see that needed.

Regards.

2018-02-22 18:47 GMT+01:00 David Arnold <dar@xoe.solutions>:
Hello,

I think I've found the right frame and initiative to place my thoughts: https://docs.google.com/document/d/1wwnu7oe5cDTyjZH3hdKkGLnF6fH4jPP3RLMPAhm3gjs/edit#heading=h.7w9he6vxmsoc

It's a great document and initiative!

Best Regards,

David

El jue., 22 feb. 2018 a las 10:43, David Arnold (<dar@xoe.solutions>) escribió:
Addendum:
As an alternative solution to the organization problem could count to split out the one-module-one-repo into a oca-dev organization and then do tagged packages in oca which resembles the current structure (using precisely git subrepo approach). That way the impact of such a move is mitigated without leaving out the benefits.

El jue., 22 feb. 2018 a las 10:37, David Arnold (<dar@xoe.solutions>) escribió:
Dear OCA Members,
Dear OCA Steering Commitee,
Dear OCA Board,

I've tried on several occasions to work with OCA repos, but it somehow doesn't fit any simple, easy to remember development and upstream-commit workflow I've been able to come up with.

In despair, I tried to do a PoC of a one-module-one-repo structure https://github.com/xoes-oca

There is a extremely useful tool called git subrepo (combinable with git subhistory) I've found to be the perfect solution for the problem to incorporate upstream modules in own code, do improvements with close to 0 changes to your normal workflow and just git subrepo push to upstream those chages transparently and cleanly.


Problem is that doesn't work out of the box with topic repositories, so it basically breaks my ideally perfect workflow and then again going the extra mile is often too cumbersome in the heat of the battle.

If we would have one-module-one-repo the contributing workflow becomes as simple as that:
...Using hub by github (https://hub.github.com/)

hub fork git@github.com:oca/foo
git subrepo clone git@github.com:myuser/foo foo
# do some commits touching module foo within my current working dir
git subrepo push
hub pull-request
> Pull request created: https://github.com/oca/foo/pulls/208

Wouldn't that be something that's worth evaluating to boost contribution and ease of adaption?

I'm principally very in favor of the OCA iniciative, but honestly contributing has those (solvable) hurdles and gets rather cumbersome (for the new generation of iphone-ux-socialized programmers).

Let me know what you think about, I'd be happy to more closely integrate our development efforts with OCA one's.

And if there are concerns about code organization, I guess since github allowed for topics this can be easily replicated with using topic filters: https://github.com/search?q=topic%3Aproduct+org%3Axoes-oca&type=Repositories


Best Regards,

David A.
--
XOE Solutions DAVID ARNOLD
Gerente General
xoe.solutions
dar@xoe.solutions
+57 (315) 304 13 68
Confidentiality Note: This email may contain confidential and/or private information. If you received this email in error please delete and notify sender.
Environmental Consideration: Please avoid printing this email on paper, unless really necessary.
--
XOE Solutions DAVID ARNOLD
Gerente General
xoe.solutions
dar@xoe.solutions
+57 (315) 304 13 68
Confidentiality Note: This email may contain confidential and/or private information. If you received this email in error please delete and notify sender.
Environmental Consideration: Please avoid printing this email on paper, unless really necessary.
--
XOE Solutions DAVID ARNOLD
Gerente General
xoe.solutions
dar@xoe.solutions
+57 (315) 304 13 68
Confidentiality Note: This email may contain confidential and/or private information. If you received this email in error please delete and notify sender.
Environmental Consideration: Please avoid printing this email on paper, unless really necessary.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe


_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe


Reference