1. Mailing Lists
  2. Contributors
  3. Re: Additional information regarding how-to review module

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: Additional information regarding how-to review module

Re: Additional information regarding how-to review module

Avatar

Re: Additional information regarding how-to review module

by
ClosingAp Open Source Integrators Europe, LDA, Daniel Reis
- 30/10/2015 10:37:46
Looks good to me.

I defend a decentralized org around projects (the OCA PSCs) but I don't think we need mandatory PSC reviews.

IMO the most important responsibilities for PSCs are:
1) Feature curation (is this generic/relevant enough, is this the best project to host it)
2) PR & Issue housekeeping: even if not actually reviewing or fixing, regularly review the open issue/PR status and ask for action, provide guidance or try to unblock problems.

--DR

No dia 30/10/2015, às 10:23, Joël Grand-Guillaume <joel.grandguillaume@camptocamp.com> escreveu:

Hi,


I agree, I've rephrased it:

* Two reviewers must approve a merge proposal in order to be able to merge it
* 5 calendar days must be given to be able to merge it
* A MP can be merged in less that 5 calendar days if and only if it is approved
  by 3 reviewers. If you are in a hurry just send a mail at
  contributors@odoo-community.org or ask by IRC (FreeNode
  oca, openobject channel).
* At least one of the review above must be from a member of the PSC or having write access on the repository (here one of the OCA core maintainers can do the job: https://github.com/orgs/OCA/teams/core-maintainers)


Regards,

Joël




On Thu, Oct 29, 2015 at 11:38 PM, Eric Caudal <eric.caudal@elico-corp.com> wrote:

+1

--
Eric Caudal [Founder and CEO]
Skype: elico.corp. Phone: + 86 186 2136 1670 (Cell), + 86 21 6211 8017/27/37 (Office)
Elico Shanghai (Shenzhen/Singapore) Odoo Gold Partner, best Odoo Partner 2014 for APAC
On 10/30/2015 01:53 AM, Stefan Rijnhart wrote:
<blockquote cite="mid:56325994.1000203@opener.am" type="cite"> 
Yes, I was wondering about that as I don't think I am a PSC myself in
many projects, but I like to be active in the domain that I am currently
working on, moving from project to project. So +1 for Daniel's reasoning.

Stefan.


On 29-10-15 10:08, Daniel Reis wrote:
>
> Joël,
>
> This is an implicit requirement to reviews: only a person with write
> access can merge the PR.
> There is no chance for two "rogue" reviewers to approve a PR and have
> it merged - one person with write access is always needed to merge the PR.
>
> In principle this should be someone from the PSC, and in practice can
> be any OCA admin.
>
> IMO would should keep that flexibility and keep it as it is because:
>
> - Many project have no regular activity from their PSC, and may not
> even have a PSC formed.
> - If having an active PSC, I see no issues on having a non-PSC to de
> the final merge for fixes, minor changes or even complex reviews where
> the PSC already gave the OK.
>
> IMO this adds additional complexity that is not needed and won't bring
> any true benefits.
> I suggest instead to clarify that a person with write access is
> required for a review or final merge.
>
> --Daniel
>

-- 
Opener B.V. - Business solutions driven by open source collaboration

Stefan Rijnhart - Consultant/developer

mail: stefan@opener.am
tel: +31 (0) 20 3090 139
web: https://opener.am

_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe


_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe





--


camptocamp
INNOVATIVE SOLUTIONS
BY OPEN SOURCE EXPERTS

Joël Grand-Guillaume
Division Manager
Business Solutions

+41 21 619 10 28


Reference