1. Mailing Lists
  2. Contributors
  3. RE: Additional information regarding how-to review module

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: Additional information regarding how-to review module

Re: Additional information regarding how-to review module

Avatar

RE: Additional information regarding how-to review module

by
Moduon Team, S. L., Rafael Blasco (Moduon)
- 28/10/2015 14:56:16

+1

 

De: Joël Grand-Guillaume [mailto:joel.grandguillaume@camptocamp.com]
Enviado el: lunes, 26 de octubre de 2015 12:38
Para: Contributors
Asunto: Re: Additional information regarding how-to review module

 

Hi,

Tha'ts a good question ! I've updated the doc again with the following suggestion:

  • Two reviewers must approve a merge proposal in order to be able to merge it

  • 5 calendar days must be given to be able to merge it

  • A MP can be merged in less that 5 calendar days if and only if it is approved by 3 reviewers. If you are in a hurry just send a mail at contributors@odoo-community.org or ask by IRC (FreeNode oca, openobject channel).

  • At least one of the review above must be from a member of the PSC

Is everybody alright with this ?

 

Regards,

Joël



 

On Mon, Oct 26, 2015 at 11:53 AM, Andhitia Rama <andhitia.r@gmail.com> wrote:

@Daniel:

 

Thank your for your suggestion. Will try it ASAP.

 

One more question, i understand that PR need 3x +1 from reviewer to be merged. So, any github reviewer +1/-1 will take into consideration whether a PR will be merged/not? Or just +1/-1 from PSC? There are not any documentation in this page or this page regarding this matter.

 

On Mon, Oct 26, 2015 at 5:07 PM, Daniel Reis <dgreis@sapo.pt> wrote:

Lorenzo is correct, any person can submit reviews, you just need to have 
a Github account.
 
Not required, but IMO submitting a PR and going through the review 
process first is helpful to get you familiarized with the process.
 
--Daniel

_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe



 

--

 

 

Andhitia Rama

 

_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe




--

 

camptocamp

INNOVATIVE SOLUTIONS

BY OPEN SOURCE EXPERTS

 

Joël Grand-Guillaume

Division Manager

Business Solutions

 

+41 21 619 10 28

 

Reference