1. Mailing Lists
  2. Contributors
  3. Re: maintainer quality tools: pylint warnings and v9

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: maintainer quality tools: pylint warnings and v9

Avatar

Re: maintainer quality tools: pylint warnings and v9

by
Vauxoo, Moisés López Calderón
- 20/10/2015 21:12:54
IMHO 
We should have in beta messages:
  too-complex - Validation of Cyclomatic complexity
  duplicate-xml-record-id - By next issue mqt#276 by @guewen

And we can enable:
    api-one-multi-together,
    class-camelcase,
    copy-wo-api-one,
    dangerous-filter-wo-user,
    deprecated-module,
    incoherent-interpreter-exec-perm,
    manifest-deprecated-key,
    manifest-required-author,
    manifest-required-key,
    missing-readme,
    no-utf8-coding-comment,
    openerp-exception-warning,
    rst-syntax-error,
    translation-field,
    use-vim-comment,
    xml-syntax-error,

For more info of messages description see: pylint-odoo

If you are agree with me I have created next PR: MQT#284


2015-10-20 13:59 GMT-05:00 Moises Lopez <moylop260@vauxoo.com>:
Which ones message you want enable to raise error in build?

enabled2beta=api-one-multi-together,
    class-camelcase,
    copy-wo-api-one,
    dangerous-filter-wo-user,
    deprecated-module,
    duplicate-xml-record-id,
    incoherent-interpreter-exec-perm,
    manifest-deprecated-key,
    manifest-required-author,
    manifest-required-key,
    missing-readme,
    no-utf8-coding-comment,
    openerp-exception-warning,
    rst-syntax-error,
    too-complex,
    translation-field,
    use-vim-comment,
    xml-syntax-error,

We have other ones here:
  (Your feedback is welcome)

Other question, you want a raise in just modules changed or full branch?


2015-10-20 7:08 GMT-05:00 <Pedro@pad.odoo-community.org>:
I want to take the occasion to thank Moisés/Vauxoo (which I copy for noticing about the request) for the work done on this side that allows all the things you are requesting.

Regards.

2015-10-20 13:53 GMT+02:00 Daniel Reis <dgreis@sapo.pt>:
Yes, we should enable them ASAP for v9.
I've been peeking at the pylint warnings in the log and they seem to be 
working perfectly.

And I suggest also enabling them for v8 PRs, since now MQT is capable to 
do specific checks only for the changed modules.

/Daniel

Às 08:38 de 20/10/2015, Alexandre Fayolle escreveu:
> Hello all
>
>
> Do we want to raise the severity of (some) Pylint warnings on the v9 
> branches?
>
> They are currently not very visible (the builds are green so people 
> often won't read the travis build logs), but contain valuable 
> information (modules not ported to new API, valuable coding 
> conventions...)
>
> Thanks for your feedback
>
> -- 
> Alexandre Fayolle
> Chef de Projet
> Tel : + 33 (0)4 58 48 20 30

>
> Camptocamp France SAS
> Savoie Technolac, BP 352
> 73377 Le Bourget du Lac Cedex
> http://www.camptocamp.com
>
> _______________________________________________
> Mailing-List: http://odoo-community.org/groups/contributors-15
> Post to: mailto:contributors@odoo-community.org
> Unsubscribe: http://odoo-community.org/groups?unsubscribe
>

_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe


_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe




--
Moisés López Calderón
Vauxoo - OpenERP's Gold Partner
Mobile: (+521) 477-752-22-30
Office: (+52) 477-773-33-46
web: http://www.vauxoo.com
twitter: @vauxoo
           @moylop260           




--
Moisés López Calderón
Vauxoo - OpenERP's Gold Partner
Mobile: (+521) 477-752-22-30
Office: (+52) 477-773-33-46
web: http://www.vauxoo.com
twitter: @vauxoo
           @moylop260           

Reference