1. Mailing Lists
  2. Contributors
  3. Re: Reciprocity in PR opening vs reviews; banning contributors

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: Reciprocity in PR opening vs reviews; banning contributors

Avatar

Re: Reciprocity in PR opening vs reviews; banning contributors

by
MetricWise, Inc., Adam Heinz
- 23/01/2026 21:38:42
I understand where this is coming from, but have trouble believing that punishment will yield additional reviews. A small number of my own pull requests have been fixes for modules that I don't even use, because they were breaking the repository build. Under the proposed system, I would have to spend additional time reviewing pull requests (that I don't care about) to earn the privilege of fixing modules (that I don't care about).

Speaking outside of my own experience, some of my colleagues who entered academia have lamented a similar sort of tendency in graduate students to favor the creation and publication of novel work for their theses, rather than review or reproduce the work of their peers.

My best successes have been when another contributor and I accidentally worked on a fix or migration in parallel, then noticed each other and reviewed the better of the two prototypes. This suggests to me that perhaps a more granular ability to Watch a specific module instead of an entire repository could more easily put like-minded individuals in a position of mutual benefit (Jita Kyoei 自他共栄).

On Fri, Jan 23, 2026 at 2:58 PM Holger Brunn <notifications@odoo-community.org> wrote:
Hi all,

on the OCA days, we discussed that the current situation with having way too 
much input for way too few reviewers is untenable. This has not improved 
since, quite the opposite. It's really hard to find the gems in the noise.

Back then, I called for better automation for this, so here my proposal:

Have a github action that counts lines of PRs somebody opened in a repo, vs 
the lines of PRs the person reviewed in that repo. Everyone must review at 
least twice as much as they submit.

If after asking for more reviews, no reviews come, close the user's PRs 
automatically (in the repo, not all OCA) after some time.

Also add a manual mechanism for banning users who try to cheat with bullshit 
reviews or otherwise undesirable behavior. PRs by banned users are closed 
automatically.

I implemented both in
https://github.com/hbrunn/social/blob/18.0/.github/workflows/reciprocity.yml
resp
https://github.com/hbrunn/social/blob/18.0/.github/workflows/ban.yml

You can test this by creating PRs against my fork after cloning my version of 
the 18.0 branch.
Banning works by adding a handle to a file .banned.txt in the repo's root.

Before proposing this to oca-addons-repo-template, I'd like to hear some input 
from you.

Best regards,
Holger



-- 
Your partner for the hard Odoo problems
https://hunki-enterprises.com

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Reference