Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Avatar

Re: apologies for mass PR creation

by
Tecnativa. S. L., Pedro M. Baeza
- 14/06/2024 13:45:56
Thanks for the apologies. I think this kind of massive changes that has nothing to do with the community and that involves a lot of repositories, should be planned with the community (like now you are doing with this message).

Following that, anything done massively should have a pilot test to check that everything is OK instead of blindly performing 100 PRs. The commit message was not following the conventions, and that meant to double the number of pipelines to execute. I know this is not something that costs us directly (apart from a delay in all the real contributions checks), but we should also see for the environment not wasting CPU resources.

Well, I don't want to dig more into something that has no remedy. Just for future actions. Now, a less impacting way to do this is as some proposals:

- To be changed only for newer branches or when an update is done, like ForgeFlow did to pass from Eficent.
- Do it progressively.
- Do it directly for not having 3 checks: the PR one + the ocabot one + the merge one.

And I add another one: you can put `[ci skip]` at the end of the commit message for avoiding the check at all, but this only serves if you do directly the write or merge the PR without ocabot.

Regards.

Reference