1. Mailing Lists
  2. Contributors
  3. Re: OCA BOT can't merge PRs in OCA/l10n-italy branch 11.0

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: OCA BOT can't merge PRs in OCA/l10n-italy branch 11.0

Re: OCA BOT can't merge PRs in OCA/l10n-italy branch 11.0

Avatar

Re: OCA BOT can't merge PRs in OCA/l10n-italy branch 11.0

by
Acsone SA/NV, Denis Roussel
- 12/03/2021 16:45:32
Use the language exporter for new language and select the module :

image.png

It will generate a pot file.

Or use the (excellent) click-odoo-makepot ;-) https://github.com/acsone/click-odoo-contrib#click-odoo-makepot-stable



On Fri, Mar 12, 2021 at 4:17 PM Francesco Apruzzese <cescoap@gmail.com> wrote:
How can I test it?

Il giorno ven 12 mar 2021 alle ore 15:52 Roussel, Denis <denis.roussel@acsone.eu> ha scritto:
Great.

Did you test the pot generation to check if fields are removed?

Le ven. 12 mars 2021 à 15:47, Francesco Apruzzese <cescoap@gmail.com> a écrit :
@Denis Roussel

If I remove account_financial_report_abstract inherit, it works, too.

FYI https://github.com/OCA/l10n-italy/pull/2168

Il giorno ven 12 mar 2021 alle ore 13:07 Roussel, Denis <denis.roussel@acsone.eu> ha scritto:
Mmmmh, the problem is maybe there : https://github.com/OCA/l10n-italy/blob/11.0/l10n_it_account_balance_report/report/account_balance_report.py#L18

The final report is inheriting several times from the same model. 

report_trial_balance is already inheriting from account_financial_report_abstract

Is that wanted ?


On Fri, Mar 12, 2021 at 12:52 PM Francesco Apruzzese <cescoap@gmail.com> wrote:
How is it possible that an already merged PR gives these problems?

Revert 11.0 it's the last step. I prefer to search another approach, if it's possibile.

Il giorno gio 11 mar 2021 alle ore 15:42 Roussel, Denis <denis.roussel@acsone.eu> ha scritto:
That module has been merged by hand:


It is causing a lot of travis jobs and commits !

Could you do something about it (Revert and fixing should be a good first approach)?


On Thu, Mar 11, 2021 at 3:27 PM Stéphane Bidoul <stephane.bidoul@acsone.eu> wrote:
I'd try running travis on python 3.6. IIRC python started preserving dict insertion order with that version, and that may help making Odoo's pot export deterministic.

-sbi

On Thu, Mar 11, 2021 at 2:57 PM Francesco Apruzzese <cescoap@gmail.com> wrote:

Il giorno mar 2 mar 2021 alle ore 15:12 Lorenzo Battistini <elbaddy@gmail.com> ha scritto:
So, the best thing to do is to fix https://github.com/OCA/l10n-italy/issues/1921


On Tue, 2 Mar 2021 at 12:16, Stéphane Bidoul <stephane.bidoul@acsone.eu> wrote:
The test failure looks real although it does not appear with each run.

Regarding the pot file not stabilizing I'm not sure what to do. Maybe trying with python 3.6 ?

-sbi

On Tue, Mar 2, 2021 at 11:27 AM Francesco Apruzzese <cescoap@gmail.com> wrote:
Hi Stéphane.

Is there anything we need to do in our repo? 

Il giorno lun 1 mar 2021 alle ore 17:52 Stéphane Bidoul <stephane.bidoul@acsone.eu> ha scritto:
Hi Francesco,

For the second one, the error can be seen on the last commit here:


So it seems to be a real test error, but one that does not appear during all builds.
Also, it seems that Odoo's .pot file exporter has difficulties producing a stable result, with several commits updating the same .pot file.

I'd suggest first trying to understand the test failure, then we can see if the pot file issue needs addressing (maybe by upgrading to python 3.6).

-sbi



On Mon, Mar 1, 2021 at 2:21 PM Francesco Apruzzese <cescoap@gmail.com> wrote:
Can anyone help us to understand why the BOT can't merge this PR


or this one 


?

Thank you.
--

Francesco Apruzzese

Profilo professionale: http://it.linkedin.com/in/francescoapruzzese

Il contenuto di questo messaggio elettronico è riservato e tutelato dal segreto professionale ed è rivolto esclusivamente al/ai destinatario/i identificato/i. Pertanto è proibito leggerlo, copiarlo, divulgarlo o utilizzarlo da parte di chiunque salvo il/i destinatario/i. Se non siete il destinatario, vi invitiamo a cancellare il messaggio ed eventuali allegati dandocene immediatamente comunicazione scritta a mezzo posta elettronica.
This e-mail and any attachments are confidential and may contain information intended for the addressee(s) only. Reading, copying, disclosure or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail.

Non stampare questa email se non strettamente necessario. Aiuta te ed aiuta l'ambiente.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe



--

Francesco Apruzzese

Profilo professionale: http://it.linkedin.com/in/francescoapruzzese

Il contenuto di questo messaggio elettronico è riservato e tutelato dal segreto professionale ed è rivolto esclusivamente al/ai destinatario/i identificato/i. Pertanto è proibito leggerlo, copiarlo, divulgarlo o utilizzarlo da parte di chiunque salvo il/i destinatario/i. Se non siete il destinatario, vi invitiamo a cancellare il messaggio ed eventuali allegati dandocene immediatamente comunicazione scritta a mezzo posta elettronica.
This e-mail and any attachments are confidential and may contain information intended for the addressee(s) only. Reading, copying, disclosure or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail.

Non stampare questa email se non strettamente necessario. Aiuta te ed aiuta l'ambiente.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe



--

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe



--

Francesco Apruzzese

Profilo professionale: http://it.linkedin.com/in/francescoapruzzese

Il contenuto di questo messaggio elettronico è riservato e tutelato dal segreto professionale ed è rivolto esclusivamente al/ai destinatario/i identificato/i. Pertanto è proibito leggerlo, copiarlo, divulgarlo o utilizzarlo da parte di chiunque salvo il/i destinatario/i. Se non siete il destinatario, vi invitiamo a cancellare il messaggio ed eventuali allegati dandocene immediatamente comunicazione scritta a mezzo posta elettronica.
This e-mail and any attachments are confidential and may contain information intended for the addressee(s) only. Reading, copying, disclosure or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail.

Non stampare questa email se non strettamente necessario. Aiuta te ed aiuta l'ambiente.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe



--
__________________________________________
Denis Roussel
Software Engineer
Acsone SA, Succursale de Liège (Val Benoît)
Tel    : +32 2 888 31 49
Fax   : +32 2 888 31 59
Gsm : +32 472 22 00 57

Acsone sa/nv
Boulevard de la Woluwe 56 Woluwedal | B-1200 Brussels  | Belgium
Quai Banning, 6 (Val Benoît) | B-4000 Liège | Belgium
Zone Industrielle 22 | L-8287 Kehlen | Luxembourg

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe



--

Francesco Apruzzese

Profilo professionale: http://it.linkedin.com/in/francescoapruzzese

Il contenuto di questo messaggio elettronico è riservato e tutelato dal segreto professionale ed è rivolto esclusivamente al/ai destinatario/i identificato/i. Pertanto è proibito leggerlo, copiarlo, divulgarlo o utilizzarlo da parte di chiunque salvo il/i destinatario/i. Se non siete il destinatario, vi invitiamo a cancellare il messaggio ed eventuali allegati dandocene immediatamente comunicazione scritta a mezzo posta elettronica.
This e-mail and any attachments are confidential and may contain information intended for the addressee(s) only. Reading, copying, disclosure or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail.

Non stampare questa email se non strettamente necessario. Aiuta te ed aiuta l'ambiente.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe



--
__________________________________________
Denis Roussel
Software Engineer
Acsone SA, Succursale de Liège (Val Benoît)
Tel    : +32 2 888 31 49
Fax   : +32 2 888 31 59
Gsm : +32 472 22 00 57

Acsone sa/nv
Boulevard de la Woluwe 56 Woluwedal | B-1200 Brussels  | Belgium
Quai Banning, 6 (Val Benoît) | B-4000 Liège | Belgium
Zone Industrielle 22 | L-8287 Kehlen | Luxembourg

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe



--

Francesco Apruzzese

Profilo professionale: http://it.linkedin.com/in/francescoapruzzese

Il contenuto di questo messaggio elettronico è riservato e tutelato dal segreto professionale ed è rivolto esclusivamente al/ai destinatario/i identificato/i. Pertanto è proibito leggerlo, copiarlo, divulgarlo o utilizzarlo da parte di chiunque salvo il/i destinatario/i. Se non siete il destinatario, vi invitiamo a cancellare il messaggio ed eventuali allegati dandocene immediatamente comunicazione scritta a mezzo posta elettronica.
This e-mail and any attachments are confidential and may contain information intended for the addressee(s) only. Reading, copying, disclosure or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail.

Non stampare questa email se non strettamente necessario. Aiuta te ed aiuta l'ambiente.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe



--

Francesco Apruzzese

Profilo professionale: http://it.linkedin.com/in/francescoapruzzese

Il contenuto di questo messaggio elettronico è riservato e tutelato dal segreto professionale ed è rivolto esclusivamente al/ai destinatario/i identificato/i. Pertanto è proibito leggerlo, copiarlo, divulgarlo o utilizzarlo da parte di chiunque salvo il/i destinatario/i. Se non siete il destinatario, vi invitiamo a cancellare il messaggio ed eventuali allegati dandocene immediatamente comunicazione scritta a mezzo posta elettronica.
This e-mail and any attachments are confidential and may contain information intended for the addressee(s) only. Reading, copying, disclosure or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail.

Non stampare questa email se non strettamente necessario. Aiuta te ed aiuta l'ambiente.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe



--
__________________________________________
Denis Roussel
Software Engineer
Acsone SA, Succursale de Liège (Val Benoît)
Tel    : +32 2 888 31 49
Fax   : +32 2 888 31 59
Gsm : +32 472 22 00 57

Acsone sa/nv
Boulevard de la Woluwe 56 Woluwedal | B-1200 Brussels  | Belgium
Quai Banning, 6 (Val Benoît) | B-4000 Liège | Belgium
Zone Industrielle 22 | L-8287 Kehlen | Luxembourg

Reference