1. Mailing Lists
  2. Contributors
  3. Re: Accelerated approval of pull requests

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: Accelerated approval of pull requests

Avatar

Re: Accelerated approval of pull requests

by
Carlos Serra-Toro
- 08/02/2021 08:47:41
I'd say that rule is inspired from science, where you get three blind reviews for any research paper that you submit for publication. Here we get two transparent reviews, so the rule should be adjusted then: review 2 PRs, expect 1 PR reviewed.



camptocamp
INNOVATIVE SOLUTIONS
BY OPEN SOURCE EXPERTS

Carlos Serra-Toro
Senior Software Engineer
Business Solutions



On Fri, 5 Feb 2021 at 14:37, Rafael Blasco <rblasco@rbnpro.com> wrote:

+1

 

Review 3 PR and expect get reviewed 1 PR (Fayolle rules!). OCA’s traffic jump come from everyone expect reviews but don’t review.

 

Give fist receive later.

 

J

 

 

De: Holger Brunn
Enviado el: viernes, 5 de febrero de 2021 13:57
Para: Contributors <contributors@odoo-community.org>
Asunto: Re: Accelerated approval of pull requests

 

Hi Bastian,
 
 
> i am reaching out to you to request accelerated approval of two pull
 
> requests i recently created:
 
thank you for your efforts. As contributing as a collaborative effort, I suggest 
you review some other PRs, and then politely point those PRs' authors to your 
own PRs. Reviewing is work we need to share.
 
Best regards,
Holger
 

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Reference