1. Mailing Lists
  2. Contributors
  3. Re: Right way to do a new OCA module that depends on EE's LGPL module.

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: Right way to do a new OCA module that depends on EE's LGPL module.

Avatar

Re: Right way to do a new OCA module that depends on EE's LGPL module.

by
Ecosoft Co. Ltd., Kitti Upariphutthiphong
- 25/01/2021 12:18:33
Yes Pedro, "base_tier_validation" will serve us well, will use it with new approvals object (spending request sounds better).

We want this approvals as a helper window only. End user can request all spending in the same place and at after approval, will create all PR, EX and AV. So, as combined amount, it can go through the right approvals steps (versus smaller documents and get away with) and also for budget check in total amount too.

I saw, approvals and approvals_purchase, and I think it is intuitive for very end users.

On Mon, Jan 25, 2021 at 5:27 PM Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> wrote:
Kitti, `base_tier_validation` doesn't serve you as base for this?

Regards.

El lun, 25 ene 2021 a las 10:27, Kitti Upariphutthiphong (<kittiu@ecosoft.co.th>) escribió:
Hi Stephane,

Yes, then I think Odoo just forget it as you say, so it defaults to LGPL. But in any case, I will go with the option 2. Which is to create a new module from the beginning.

Thanks for your prompt reply.
Kitti U.

On Mon, Jan 25, 2021 at 3:47 PM Stéphane Bidoul <stephane.bidoul@acsone.eu> wrote:
> I have checked that "approvals", although in EE source code, its license is in CE, LGPL.

Have you checked that with Odoo ? Some EE modules don't have a license key, and when you load them in a database, the license field of ir.module.module defaults to LGPL.
But last time I reported that to Odoo it was quickly fixed.
So unless explicitly written otherwise I would assume that all the odoo/enterprise repo is under a proprietary license.

And you can't create a module that depends on both AGPL and proprietary code.

In any case adding code that depends on Odoo EE in OCA is not possible because the EE code is not public so we could not run CI, runbot etc.

Best regards,

-sbi

--
Stéphane Bidoul | @SBidoul
Acsone sa/nv | http://acsone.eu/ | +32 2 888 3120

On Mon, Jan 25, 2021 at 4:32 AM Kitti Upariphutthiphong <kittiu@ecosoft.co.th> wrote:
Dear community,

Got some questions about licensing.

There are modules that we want to extend but they are in EE14 --> "approvals", "approvals_purchase".
Where approvals is a simple module for approving something. And approvals_purchase allow creating purchase order at the end of process.

They are quite simple. But what we need is to create modules "approvals_purchase_request" and "approvals_hr_expense".

I have checked that "approvals", although in EE source code, its license is in CE, LGPL.

What is the right way to deal with this?
  1. Just include approvals in OCA and continue the new module (as it is LGPL, not sure)
  2. We can't use "approvals", and so, we have to first create something similar to it, may be renaming it, add/remove some feature etc. and make it pure OCA module first before continue our needing module.

Thank you!
Kitti U.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Reference