1. Mailing Lists
  2. Contributors
  3. Re: Pull request modifying two modules?

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: Pull request modifying two modules?

Re: Pull request modifying two modules?

Avatar

Re: Pull request modifying two modules?

by
ClosingAp Open Source Integrators Europe, LDA, Daniel Reis
- 01/10/2020 17:50:00 
Thank you Pedro, I'll be sure to let my friend know that ;-)

Seriously now, it is a fix in two closely related modules, and I don't 
see a case where one could be merged and the other not.
Two PRs world would be more confusing than helpful.
Still, making it in separate commits seems wise advice.

Thanks
Daniel


On 01/10/2020 16:12, Pedro M. Baeza (Tecnativa) wrote:

> Yes, bot does it correctly thanks to the great work of Stephane Bidoul :)

>

> Now, about the guidelines, you can do that on a PR if the task is very 

> related. Think if a separation in several commits is advisable or not 

> anyway.

>

> Regards.

>

> _______________________________________________

> Mailing-List: https://odoo-community.org/groups/contributors-15 

> <https://odoo-community.org/groups/contributors-15>

> Post to: mailto:contributors@odoo-community.org

> Unsubscribe: https://odoo-community.org/groups?unsubscribe 

> <https://odoo-community.org/groups?unsubscribe>

>

Reference