1. Mailing Lists
  2. Contributors
  3. RE: Stale PR closing

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: Stale PR closing

Re: Stale PR closing

Avatar

RE: Stale PR closing

by
Moduon Team, S. L., Rafael Blasco (Moduon)
- 22/09/2019 17:51:19 
I would say again

:+1 18 months (:-1 less than this time)

PD: OCAbot could make auto-milestones PRs.... the work of labeling PRs for
PSC is also work and it could be done by OCAbot



> By the way, according to

> https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst

> it’s 6 months and no questions asked :)

Yes, but this is not automatic. This rule could be applied by a human that
is a PSC. OCABot must be much more cautious

Let’s say a contributor XxX make PR, this contributor get reviews, fix
everything, all bots green with 100% coverage and after this nobody review
it. Futhermore this contributor XxX apply all the time the OCA Rule
reviewing 3 PR per 1 PR the contributor XxX make. So XxX have 5 PRs without
review all green and 100% coverage but XxX reviewed 15 PR to other
contributors.

After 1 year, one new contributor comes and say, hey! Travis is red because
other different contributors make other PRS, merged and they did something
wrong o just PR need to be rebased… The original author miss the email o
just that PR was and is absolutely perfect and XxX, say automatic closing?
“OCA is nor for me, I did everything I must but nobody review it”


> We have 2 general cases:

I would say we have quite more general cases.

Off-topic for Odoo days: After thinking some time I think the solution it's
not closing PRs is limit the PR that can be done based on revisions. No
revision, no PR. The OCA Rule (3 review per PR) has sense, and the OCA grow
because reviewers more than pull-requesters.


Thank you!


De: Alexey Pelykh [mailto:alexey.pelykh@gmail.com]
Enviado el: jueves, 19 de septiembre de 2019 11:57
Para: Contributors <contributors@odoo-community.org>
Asunto: Re: Stale PR closing

We have 2 general cases:
1. There was no review at all, or not enough reviews. It’s very unfortunate,
but it still makes a PR stale. And this should be somehow addressed by bot
as well, e.g. calling for reviewers after 3 months and if no-one was
interested - well, it is what it is?
2. There were reviews that were not addressed - this one can just be closed
as abandoned by author.


On Sep 19, 2019, at 10:41, Graeme Gellatly <gdgellatly@gmail.com> wrote:

You misread it by not checking the section it was under. Can be closed if no
activity in response to the review. You can't just arbitrarily close an
unreviewed PR. There is a big discussion somewhere where that was agreed,
but it was years ago now.

On Thu, Sep 19, 2019 at 8:02 PM Alexey Pelykh <alexey.pelykh@gmail.com>
wrote:
By the way, according to
https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst
it’s 6 months and no questions asked :)


On Aug 29, 2019, at 18:16, Stéphane Bidoul <stephane.bidoul@acsone.eu>
wrote:

I'm in favor to move forward with this.

Alexey was kind enough to do a PR, which includes adding a "stale 🗃" label
so they are easy to find.

Note PR merged by /ocabot merge (virtually all of them these days) are
labeled as "merged 🎉" so they too are easy to find even in case a rebase
has been done.

12 months is a reasonably long time. And if anyone is still interested it's
easy to (ask to) reopen to get a new one year lease.

@Graeme Gellatly does this address your concerns?

-sbi



On Thu, Aug 29, 2019 at 6:27 PM Alexey Pelykh <alexey.pelykh@gmail.com>
wrote:
We can implement just-labeling initially, at least to see the amount of
impact. Personally, I don’t see any harm in closing PR that had 0 comments
for 12 months, assuming it’s valuable and reviewers are doing their part of
the deal.


On Aug 29, 2019, at 18:17, Joël Grand-Guillaume
<joel.grandguillaume@camptocamp.com> wrote:

For your case @Graeme Gellatly may be we can just add a label "Close by bot"
so it's still pretty easy to find them right ?

Because today, the fact so many PRs remain open for months if not years is a
real issue I think.

Any how, we all agree there is something to do here. The OCA days is
probably the best place to discuss it right ;)

On Thu, Aug 29, 2019 at 2:36 PM Daniel Reis <dgreis@sapo.pt> wrote:
If we do this, we need to make sure that closed PR really means that the PR
was not merged.
I see on the Odoo repo may closed PRs that had their code manually merged -
not sure if we have this in the OCA.

What if the bot just regularly (monthly?) pinged the followers.
People would manually close a stale PR if that makes sense.
Daniel

No dia 29/08/2019, às 12:12, Kitti Upariphutthiphong <kittiu@ecosoft.co.th>
escreveu:
Or once it hit 12 months of inactivity, ocabot can auto assign to any active
contributors (i..e, 2 person) to review it?

After that like 3 months, if still no activity, close it.


On Thu, Aug 29, 2019 at 4:17 PM Eduardo Magdalena <emagdalena@c2i.es> wrote:
+1 12 months - 18 months. First add a comment or label as a warning, telling
that the PR will be closed an the closed if there are no activity 6 months
after






Un saludo,
Eduardo Magdalena
Fundador & CEO
✉   emagdalena@c2i.es
✆  +34 678 713 373

C2i Change 2 improve
Optimización de procesos
    www.c2i.es


   Averigua a quién conocemos en común





☑ ¿Por qué no organizamos una reunión online?


Este correo y sus archivos asociados son privados y confidenciales y van
dirigidos exclusivamente a su destinatario. Si recibe este correo sin ser el
destinatario del mismo le rogamos proceda a su eliminación y lo ponga en
conocimiento de su emisor. La difusión por cualquier medio de su contenido
podría ser sancionada conforme a lo previsto en la legislación vigente, Ley
Orgánica 15/1999, de Protección de Datos de Carácter Personal. Le rogamos
que no imprima este correo ni sus documentos adjuntos, salvo que lo estime
necesario.



El jue., 29 ago. 2019 a las 3:32, Graeme Gellatly (<gdgellatly@gmail.com>)
escribió:
Hi,

I don't like the idea personally, especially on OCA wide level. I often pick
up abandoned PR's fix them up and resubmit them. At the very least I like to
go through them when porting modules to see if anything in there is value
that needs porting. If they are closed it is a hassle working out why it was
closed (superseded, abandoned etc).

Maybe for new to OCA modules, but for existing modules, a human should
really determine whether it is worth reviving IMO. I think a much better
application for a Bot is to find interested reviewers. Do some smart stuff
like

When a PR is submitted, crawl history and cc any past reviewer or committer
for that module (maybe even have a reviewer group so people can choose to
opt in) (maybe in past 18 months)

On Thu, Aug 29, 2019 at 10:41 AM Rafael Blasco <rafael.blasco@tecnativa.com>
wrote:
+1 18 months

De: Mignon, Laurent [mailto:laurent.mignon@acsone.eu]
Enviado el: martes, 27 de agosto de 2019 10:57
Para: Contributors <contributors@odoo-community.org>
Asunto: Re: Stale PR closing

+1

On Tue, Aug 27, 2019 at 10:27 AM Stéphane Bidoul <stephane.bidoul@acsone.eu>
wrote:
Hello Alexey,

+1

This is being tracked in: https://github.com/OCA/oca-github-bot/issues/10,
awaiting PR :)

If someone wants to work on this at #OCADays, I'll be happy to help.

-sbi

On Tue, Aug 27, 2019 at 10:16 AM Alexey Pelykh <alexey.pelykh@gmail.com>
wrote:
Dear community,

In OCA repositories there are PRs that have not been updated for years, and
are either abandoned by authors or by reviewers. Should we agree on policy
(and implement it via OCA Bot) to close PR/issue if there was no activity
for more than 6-12-18 months?

Kind regards,
Alexey
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe



-- 

camptocamp
INNOVATIVE SOLUTIONS
BY OPEN SOURCE EXPERTS

Joël Grand-Guillaume
Department Head
Business Solutions

+41 21 619 10 28
www.camptocamp.com


_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Reference